Skip to content

Commit db96812

Browse files
lmeyerovclaude
andcommitted
test(gfql): L3 wave-3 nits — output-json touch after --est, decline-branch docstring scope
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 86a4047 commit db96812

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

benchmarks/gfql/viz_filter_pipeline.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -291,15 +291,16 @@ def main() -> None:
291291
args = parser.parse_args()
292292
if args.runs < 1 or args.warmup < 0:
293293
parser.error("--runs must be >= 1 and --warmup >= 0")
294-
if args.output_json:
295-
# fail BEFORE a multi-minute sweep, not at the final write (wave-2 S4)
296-
with open(args.output_json, "a"):
297-
pass
298-
299294
if args.est:
300295
print_estimate(args.scale)
301296
return
302297

298+
if args.output_json:
299+
# fail BEFORE a multi-minute sweep, not at the final write (wave-2 S4;
300+
# after the --est early-return so estimate-only runs touch nothing)
301+
with open(args.output_json, "a"):
302+
pass
303+
303304
engines = [e.strip() for e in args.engines.split(",") if e.strip()]
304305
unknown = [e for e in engines if e not in KNOWN_ENGINES]
305306
if unknown:

graphistry/tests/compute/gfql/test_viz_pipeline_conformance.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -480,9 +480,10 @@ def test_case_regex_unicode_trick_matrix(label, query, pinned, mirror):
480480

481481
def test_categorical_searchany_decline_or_correct():
482482
"""Categorical column through searchAny via explicit columns=: pandas may decline
483-
clearly (honest NIE or GFQLValidationError); a non-pandas engine may only NIE or
484-
match the pandas oracle exactly — a SILENT WRONG answer is not acceptable, and a
485-
non-NIE crash class is not."""
483+
clearly (honest NIE or GFQLValidationError). When pandas answers, a non-pandas
484+
engine may only NIE or match the pandas oracle exactly — a SILENT WRONG answer is
485+
not acceptable, and a non-NIE crash class is not. (When pandas itself declines
486+
there is no oracle, so non-pandas engines are not checked.)"""
486487
g = _panel_graph()
487488
nd = _panel_nodes()
488489
q = "MATCH (n) WHERE searchAny(n, 'x', {columns: ['cat']}) RETURN n.id AS id"

0 commit comments

Comments
 (0)