Skip to content

Commit 6d65aad

Browse files
lmeyerovclaude
andcommitted
test(gfql/conformance): matrix cases for the #1673 scalar fns (floor/ceil/ceiling/round/toLower/toUpper)
The coverage ledger (cascaded from #1660) correctly flagged the new GFQL_SCALAR_FUNCTIONS entries as neither exercised nor waived. Real 4-engine parity-or-NIE cases beat waivers: each new function gets a cypher expression case through the standard matrix driver (chain + DAG surfaces). dgx: matrix + ledger 267 passed (cudf + polars-gpu lanes active). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 8843b0f commit 6d65aad

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

graphistry/tests/compute/gfql/test_engine_polars_conformance_matrix.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -221,6 +221,15 @@ def _cypher_expression_queries():
221221
("tostring_bool", "MATCH (n) RETURN n.id AS id, toString(n.flag) AS s"),
222222
("tostring_int", "MATCH (n) RETURN n.id AS id, toString(n.num) AS s"),
223223
("tostring_str", "MATCH (n) RETURN n.id AS id, toString(n.name) AS s"),
224+
# #1673 numeric/string scalar fns (native on polars per the #1675 lowering; the
225+
# coverage ledger requires every GFQL_SCALAR_FUNCTIONS entry exercised-or-waived)
226+
("floor", "MATCH (n) RETURN n.id AS id, floor(n.f) AS x"),
227+
("ceil", "MATCH (n) RETURN n.id AS id, ceil(n.f) AS x"),
228+
("ceiling", "MATCH (n) RETURN n.id AS id, ceiling(n.f) AS x"),
229+
("round", "MATCH (n) RETURN n.id AS id, round(n.f) AS x"),
230+
("round_p2", "MATCH (n) RETURN n.id AS id, round(n.f, 2) AS x"),
231+
("tolower", "MATCH (n) RETURN n.id AS id, toLower(n.name) AS s"),
232+
("toupper", "MATCH (n) RETURN n.id AS id, toUpper(n.name) AS s"),
224233
# NOTE: toString(float) is intentionally NOT here — polars declines it (NIE, covered by
225234
# test_tostring_float_honest_nie_polars), but cudf formats floats differently than pandas
226235
# (an orthogonal cudf float-repr divergence, like the list-literal element-order one), which

0 commit comments

Comments
 (0)