From 5ace7866b297c905f58d52ab47dcee080e728db2 Mon Sep 17 00:00:00 2001
From: sathish-palanivelu <palanivelu.sathishkumar@gmail.com>
Date: Fri, 11 Jul 2025 10:39:33 +0100
Subject: [PATCH] feat: azure add rate limit counter key

---
 src/lib/azure/services/api-management/main.ts          | 4 ++--
 src/test/azure/services/api-management-manager.test.ts | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/lib/azure/services/api-management/main.ts b/src/lib/azure/services/api-management/main.ts
index 420d38eb..cf9bfc93 100644
--- a/src/lib/azure/services/api-management/main.ts
+++ b/src/lib/azure/services/api-management/main.ts
@@ -402,8 +402,8 @@ export class AzureApiManagementManager {
 
       // Inject rate limiting policy (if configured)
       let rateLimitPolicy = ''
-      if (props.rateLimit) {
-        rateLimitPolicy = `<rate-limit-by-key calls="${props.rateLimit.calls}" renewal-period="${props.rateLimit.renewalPeriodInSecs}"/>`
+      if (props.rateLimit && scope.props.subscriptionId) {
+        rateLimitPolicy = `<rate-limit-by-key calls="${props.rateLimit.calls}" renewal-period="${props.rateLimit.renewalPeriodInSecs}" counter-key="${scope.props.subscriptionId}"/>`
       }
       const policyXmlContent = `<policies>
         <inbound>
diff --git a/src/test/azure/services/api-management-manager.test.ts b/src/test/azure/services/api-management-manager.test.ts
index a953e3c9..d3880982 100644
--- a/src/test/azure/services/api-management-manager.test.ts
+++ b/src/test/azure/services/api-management-manager.test.ts
@@ -34,6 +34,7 @@ const testStackProps: any = {
   skipStageForARecords: false,
   stage: 'dev',
   stageContextPath: 'src/test/aws/common/cdkEnv',
+  subscriptionId: 'subscriptionId',
 }
 
 class TestCommonStack extends CommonAzureStack {
@@ -255,7 +256,7 @@ describe('TestAzureApiManagementConstruct', () => {
         '${azurerm_api_management_api_operation.test-api-management-dev-apim-api-operation-test-get.operation_id}',
       resource_group_name: '${azurerm_api_management_api.test-api-management-dev-am-api.resource_group_name}',
       xml_content:
-        '<policies>\n        <inbound>\n          <base />\n          <rate-limit-by-key calls="25" renewal-period="1"/>\n          \n          <set-backend-service id="apim-generated-policy" backend-id="${azapi_resource.test-api-management-dev-am-be.name}" />\n        </inbound>\n        <backend>\n          <base />\n        </backend>\n        <outbound>\n          <base />\n          \n          \n        </outbound>\n        <on-error>\n            <base />\n        </on-error>\n      </policies>',
+        '<policies>\n        <inbound>\n          <base />\n          <rate-limit-by-key calls="25" renewal-period="1" counter-key="subscriptionId"/>\n          \n          <set-backend-service id="apim-generated-policy" backend-id="${azapi_resource.test-api-management-dev-am-be.name}" />\n        </inbound>\n        <backend>\n          <base />\n        </backend>\n        <outbound>\n          <base />\n          \n          \n        </outbound>\n        <on-error>\n            <base />\n        </on-error>\n      </policies>',
     })
   })
 })