test: login local auth disabled

Author: jmattheis

api/session_test.go

@@ -93,6 +93,21 @@ func (s *SessionSuite) Test_Login_Success() {
 	assert.Equal(s.T(), uint(auth.CookieMaxAge), clients[0].ExpiresAfterInactivitySeconds)
 }
 
+func (s *SessionSuite) Test_Login_LocalAuthDisabled() {
+	s.a.LocalAuthEnabled = false
+	s.ctx.Request = httptest.NewRequest("POST", "/auth/local/login", strings.NewReader("name=test-browser"))
+	s.ctx.Request.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+	s.ctx.Request.Header.Set("Authorization", "Basic "+base64.StdEncoding.EncodeToString([]byte("testuser:testpass")))
+
+	s.a.Login(s.ctx)
+
+	assert.Equal(s.T(), 403, s.recorder.Code)
+
+	for _, c := range s.recorder.Result().Cookies() {
+		assert.NotEqual(s.T(), auth.CookieName, c.Name)
+	}
+}
+
 func (s *SessionSuite) Test_Login_WrongPassword() {
 	s.ctx.Request = httptest.NewRequest("POST", "/auth/local/login", strings.NewReader("name=test-browser"))
 	s.ctx.Request.Header.Set("Content-Type", "application/x-www-form-urlencoded")

config/config_test.go

@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/gotify/server/v2/mode"
+	"github.com/rs/zerolog"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -21,7 +22,6 @@ func TestConfigEnv(t *testing.T) {
 	t.Setenv("GOTIFY_SERVER_CORS_ALLOWMETHODS", "GET,POST")
 	t.Setenv("GOTIFY_SERVER_CORS_ALLOWHEADERS", "Authorization,content-type")
 	t.Setenv("GOTIFY_SERVER_STREAM_ALLOWEDORIGINS", ".+.example.com,otherdomain.com")
-	t.Setenv(EnvLocalAuthEnabled, "false")
 
 	conf, _ := Get()
 	assert.Equal(t, 80, conf.Server.Port, "should use defaults")
@@ -33,17 +33,53 @@ func TestConfigEnv(t *testing.T) {
 	assert.Equal(t, []string{"GET", "POST"}, conf.Server.Cors.AllowMethods)
 	assert.Equal(t, []string{"Authorization", "content-type"}, conf.Server.Cors.AllowHeaders)
 	assert.Equal(t, []string{".+.example.com", "otherdomain.com"}, conf.Server.Stream.AllowedOrigins)
-	assert.False(t, conf.LocalAuthEnabled)
 }
 
-func TestRegistrationRequiresLocalAuth(t *testing.T) {
-	mode.Set(mode.TestDev)
-	t.Setenv(EnvLocalAuthEnabled, "false")
-	t.Setenv(EnvOIDCEnabled, "true")
-	t.Setenv(EnvRegistration, "true")
+func TestLocalAuthDisabled(t *testing.T) {
+	tests := []struct {
+		name   string
+		env    map[string]string
+		fatals []FutureLog
+	}{
+		{
+			name: "with oidc",
+			env:  map[string]string{EnvLocalAuthEnabled: "false", EnvOIDCEnabled: "true"},
+		},
+		{
+			name:   "without oidc",
+			env:    map[string]string{EnvLocalAuthEnabled: "false"},
+			fatals: []FutureLog{futureFatal("either local authentication or OIDC must be enabled")},
+		},
+		{
+			name: "with registration",
+			env: map[string]string{
+				EnvLocalAuthEnabled: "false",
+				EnvOIDCEnabled:      "true",
+				EnvRegistration:     "true",
+			},
+			fatals: []FutureLog{futureFatal("registration requires local authentication to be enabled")},
+		},
+	}
 
-	_, logs := Get()
-	assert.Contains(t, logs, futureFatal("registration requires local authentication to be enabled"))
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			mode.Set(mode.TestDev)
+			for key, value := range tc.env {
+				t.Setenv(key, value)
+			}
+
+			conf, logs := Get()
+			assert.False(t, conf.LocalAuthEnabled)
+
+			var fatals []FutureLog
+			for _, entry := range logs {
+				if entry.Level == zerolog.FatalLevel {
+					fatals = append(fatals, entry)
+				}
+			}
+			assert.Equal(t, tc.fatals, fatals)
+		})
+	}
 }
 
 func TestFile(t *testing.T) {