diff --git a/read.go b/read.go index 3bea68c..9c3ce52 100644 --- a/read.go +++ b/read.go @@ -63,19 +63,19 @@ func (c *Config) Exists(key string, findByPath ...bool) (ok bool) { } case []int: // is array(is from Set) i, err := strconv.Atoi(k) - if err != nil || i >= len(typeData) { + if err != nil || i < 0 || i >= len(typeData) { return false } item = typeData[i] case []string: // is array(is from Set) i, err := strconv.Atoi(k) - if err != nil || i >= len(typeData) { + if err != nil || i < 0 || i >= len(typeData) { return false } item = typeData[i] case []any: // is array(load from file) i, err := strconv.Atoi(k) - if err != nil || i >= len(typeData) { + if err != nil || i < 0 || i >= len(typeData) { return false } item = typeData[i] @@ -214,7 +214,7 @@ func (c *Config) GetValue(key string, findByPath ...bool) (value any, ok bool) { i, err := strconv.Atoi(k) // check slice index - if err != nil || len(typeData) <= i { + if err != nil || i < 0 || len(typeData) <= i { ok = false c.addError(err) return @@ -223,7 +223,7 @@ func (c *Config) GetValue(key string, findByPath ...bool) (value any, ok bool) { item = typeData[i] case []string: // is array(is from Set) i, err := strconv.Atoi(k) - if err != nil || len(typeData) <= i { + if err != nil || i < 0 || len(typeData) <= i { ok = false c.addError(err) return @@ -232,7 +232,7 @@ func (c *Config) GetValue(key string, findByPath ...bool) (value any, ok bool) { item = typeData[i] case []any: // is array(load from file) i, err := strconv.Atoi(k) - if err != nil || len(typeData) <= i { + if err != nil || i < 0 || len(typeData) <= i { ok = false c.addError(err) return diff --git a/read_test.go b/read_test.go index deaf395..9616080 100644 --- a/read_test.go +++ b/read_test.go @@ -499,3 +499,24 @@ func TestConfig_Duration_getter(t *testing.T) { is.Eq(7*time.Second, c.Duration("missing", 7*time.Second)) is.Eq(time.Duration(0), c.Duration("missing")) } + +func TestConfig_GetValue_negativeIndex(t *testing.T) { + is := assert.New(t) + + c := New("test-neg") + err := c.LoadData(map[string]any{ + "arr": []any{"a", "b", "c"}, + }) + is.NoErr(err) + + // A negative slice index must not panic; it is simply not found. + is.NotPanics(func() { + v, ok := c.GetValue("arr.-1") + is.False(ok) + is.Nil(v) + }) + + is.NotPanics(func() { + is.False(c.Exists("arr.-1")) + }) +} diff --git a/testdata/issues59.ini b/testdata/issues59.ini index afab97f..1eb9623 100644 --- a/testdata/issues59.ini +++ b/testdata/issues59.ini @@ -1,4 +1,4 @@ -; exported at 2025-08-20 14:11:56 +; exported at 2026-09-06 00:43:11 age = 123 baseKey = value @@ -9,8 +9,8 @@ multiWords = hello world name = app [map1] +key = val key1 = val1 key2 = val2 -key = val