Skip to content

Commit 8472b08

Browse files
authored
ci(bigtable): allow bulkTests profile to skip unit tests by removing explicit skipTests override (#13906)
The normal CI units is running the BigTable tests even though bigtable has their own split-units config. This seems to stem from bulkTest profile having the skipTests property be overwritten by BigTable's default config. This change updates it so that bulkTests profile can properly skip BigTable tests when enabled. When the profile is not enabled, the skipTests property defaults to `""` which is evaluated to false by default.
1 parent c18141d commit 8472b08

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

  • java-bigtable/google-cloud-bigtable

java-bigtable/google-cloud-bigtable/pom.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@
2020
<site.installationModule>google-cloud-bigtable</site.installationModule>
2121

2222
<!-- Enable the ability to skip unit tests and only run integration tests,
23-
while still respecting global skipTests override. -->
24-
<skipTests>false</skipTests>
23+
while still respecting global skipTests override and parent bulkTests profile.
24+
Do NOT set an explicit <skipTests>false</skipTests> here, as submodule property
25+
declarations override parent profile settings and prevent -PbulkTests from working. -->
2526
<skipUnitTests>${skipTests}</skipUnitTests>
2627
<skipITs>${skipTests}</skipITs>
2728
<!-- Configure test logging output. By default tests print info logs to stdout/err.

0 commit comments

Comments
 (0)