Skip to content

Commit 1dc342c

Browse files
authored
ci: quick-build profile skip shading (#14046)
Seeing this weird issue in the enforcer plugin: ``` 19:50:20:126 [ERROR] Could not acquire shared lock for artifacts: io.grpc:grpc-api:jar:1.82.3, com.google.code.findbugs:jsr305:jar:3.0.2, com.google.errorprone:error_prone_annotations:jar:2.48.0, io.grpc:grpc-stub:jar:1.82.3, ... in 900 SECONDS; consider using 'aether.syncContext.named.time' property to increase lock timeout to a value that fits your environment 19:50:20:126 [ERROR] org.eclipse.aether.SyncContext$FailedToAcquireLockException: Could not acquire shared lock for artifacts: ... in 900 SECONDS ``` Gemini is suggesting that not shading may end up speeding up some of the longer to build modules: - GAPIC Showcase Client: 16:28 min - GAPIC Generator Java: 16:14 min Try it out to see if running in the CIs via `quick-build` profile can help. Shading will continue to be run, but only skipped in the quick-build profile. EDIT: Looks like we have to shade the generator for now
1 parent bd2c879 commit 1dc342c

8 files changed

Lines changed: 16 additions & 0 deletions

File tree

google-cloud-pom-parent/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
<properties>
2323
<skipUnitTests>false</skipUnitTests>
2424
<checkstyle.header.file>java.header</checkstyle.header.file>
25+
<!-- maven-shade-plugin does not define a built-in user property for its skip parameter;
26+
shade.skip is declared here and mapped in shaded modules to allow quick-build to toggle it off. -->
27+
<shade.skip>false</shade.skip>
2528
</properties>
2629

2730
<developers>
@@ -72,6 +75,7 @@
7275
<fmt.skip>true</fmt.skip>
7376
<flatten.skip>true</flatten.skip>
7477
<mdep.analyze.skip>true</mdep.analyze.skip>
78+
<shade.skip>true</shade.skip>
7579
</properties>
7680
</profile>
7781
<profile>

java-bigquery/benchmark/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@
6161
<goal>shade</goal>
6262
</goals>
6363
<configuration>
64+
<skip>${shade.skip}</skip>
6465
<finalName>${uberjar.name}</finalName>
6566
<transformers>
6667
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">

java-bigtable/pom.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,6 +286,9 @@
286286
<groupId>org.apache.maven.plugins</groupId>
287287
<artifactId>maven-shade-plugin</artifactId>
288288
<version>3.6.0</version>
289+
<configuration>
290+
<skip>${shade.skip}</skip>
291+
</configuration>
289292
</plugin>
290293
<plugin>
291294
<groupId>org.apache.maven.plugins</groupId>

java-bigtable/test-proxy/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@
158158
<goal>shade</goal>
159159
</goals>
160160
<configuration>
161+
<skip>${shade.skip}</skip>
161162
<filters>
162163
<filter>
163164
<artifact>*:*</artifact>

java-cloud-bom/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@
2929

3030
<properties>
3131
<enforcer.skip>true</enforcer.skip>
32+
<!-- maven-shade-plugin does not define a built-in user property for its skip parameter;
33+
shade.skip is declared here and mapped in shaded modules to allow quick-build to toggle it off. -->
34+
<shade.skip>false</shade.skip>
3235
</properties>
3336

3437
<modules>
@@ -116,6 +119,7 @@
116119
<fmt.skip>true</fmt.skip>
117120
<flatten.skip>true</flatten.skip>
118121
<mdep.analyze.skip>true</mdep.analyze.skip>
122+
<shade.skip>true</shade.skip>
119123
</properties>
120124
</profile>
121125
<profile>

java-spanner-jdbc/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,7 @@
275275
<goal>shade</goal>
276276
</goals>
277277
<configuration>
278+
<skip>${shade.skip}</skip>
278279
<createSourcesJar>true</createSourcesJar>
279280
<shadeSourcesContent>true</shadeSourcesContent>
280281
<shadedArtifactAttached>true</shadedArtifactAttached>

java-storage-nio/google-cloud-nio/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@
129129
</dependency>
130130
</dependencies>
131131
<configuration>
132+
<skip>${shade.skip}</skip>
132133
<shadedArtifactAttached>true</shadedArtifactAttached>
133134
<relocations>
134135
<relocation>

java-storage/storage-shared-benchmarking/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
<goal>shade</goal>
6666
</goals>
6767
<configuration>
68+
<skip>${shade.skip}</skip>
6869
<finalName>${uberjar.name}</finalName>
6970
<transformers>
7071
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">

0 commit comments

Comments
 (0)