From c5766b410bdae1b0b7dbcc29672c2cac1a72f387 Mon Sep 17 00:00:00 2001 From: Scott Hart Date: Sat, 22 Aug 2026 13:43:08 -0400 Subject: [PATCH 1/3] chore(bigtable): fix some formatting and auto issues --- ...igtable_random_two_least_used_decorator.cc | 143 ++++++++---------- ...bigtable_random_two_least_used_decorator.h | 96 ++++++------ .../bigtable/internal/stub_manager_test.cc | 10 +- 3 files changed, 111 insertions(+), 138 deletions(-) diff --git a/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc b/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc index f13530b023ad0..60769ad256ea3 100644 --- a/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc +++ b/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc @@ -28,12 +28,10 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN namespace { template -class StreamingReadRpcTracking - : public google::cloud::internal::StreamingReadRpc { +class StreamingReadRpcTracking : public internal::StreamingReadRpc { public: - StreamingReadRpcTracking( - std::unique_ptr> child, - std::function on_destruction) + StreamingReadRpcTracking(std::unique_ptr> child, + std::function on_destruction) : child_(std::move(child)), on_destruction_(std::move(on_destruction)) {} ~StreamingReadRpcTracking() override { on_destruction_(); } @@ -47,16 +45,16 @@ class StreamingReadRpcTracking } private: - std::unique_ptr> child_; + std::unique_ptr> child_; std::function on_destruction_; }; template class AsyncStreamingReadRpcTracking - : public google::cloud::internal::AsyncStreamingReadRpc { + : public internal::AsyncStreamingReadRpc { public: AsyncStreamingReadRpcTracking( - std::unique_ptr> child, + std::unique_ptr> child, std::function on_destruction) : child_(std::move(child)), on_destruction_(std::move(on_destruction)) {} @@ -71,18 +69,16 @@ class AsyncStreamingReadRpcTracking } private: - std::unique_ptr> child_; + std::unique_ptr> child_; std::function on_destruction_; }; template class AsyncStreamingReadWriteRpcTracking - : public google::cloud::AsyncStreamingReadWriteRpc { + : public AsyncStreamingReadWriteRpc { public: AsyncStreamingReadWriteRpcTracking( - std::unique_ptr< - google::cloud::AsyncStreamingReadWriteRpc> - child, + std::unique_ptr> child, std::function on_destruction) : child_(std::move(child)), on_destruction_(std::move(on_destruction)) {} @@ -101,8 +97,7 @@ class AsyncStreamingReadWriteRpcTracking } private: - std::unique_ptr> - child_; + std::unique_ptr> child_; std::function on_destruction_; }; @@ -139,12 +134,11 @@ Response AsyncHelper(std::shared_ptr>& pool, } template -std::unique_ptr> -StreamingHelper( +std::unique_ptr> StreamingHelper( std::shared_ptr>& pool, std::shared_ptr const& operation_context, - std::function>(BigtableStub&)> + std::function< + std::unique_ptr>(BigtableStub&)> fn) { SelectedChannel selection = pool->GetChannelRandomTwoLeastUsed(); @@ -164,12 +158,10 @@ StreamingHelper( } template -std::unique_ptr> -AsyncStreamingHelper( +std::unique_ptr> AsyncStreamingHelper( std::shared_ptr>& pool, std::shared_ptr const& operation_context, - std::function>( + std::function>( BigtableStub&)> fn) { SelectedChannel selection = @@ -190,12 +182,12 @@ AsyncStreamingHelper( } template -std::unique_ptr> +std::unique_ptr> AsyncStreamingHelper( std::shared_ptr>& pool, std::shared_ptr const& operation_context, - std::function>(BigtableStub&)> + std::function>(BigtableStub&)> fn) { SelectedChannel selection = pool->GetChannelRandomTwoLeastUsed(); @@ -218,8 +210,8 @@ AsyncStreamingHelper( } // namespace -std::unique_ptr> +std::unique_ptr< + internal::StreamingReadRpc> BigtableRandomTwoLeastUsed::ReadRows( std::shared_ptr context, Options const& options, google::bigtable::v2::ReadRowsRequest const& request, @@ -233,8 +225,8 @@ BigtableRandomTwoLeastUsed::ReadRows( }); } -std::unique_ptr> +std::unique_ptr< + internal::StreamingReadRpc> BigtableRandomTwoLeastUsed::SampleRowKeys( std::shared_ptr context, Options const& options, google::bigtable::v2::SampleRowKeysRequest const& request, @@ -259,8 +251,8 @@ BigtableRandomTwoLeastUsed::MutateRow( }); } -std::unique_ptr> +std::unique_ptr< + internal::StreamingReadRpc> BigtableRandomTwoLeastUsed::MutateRows( std::shared_ptr context, Options const& options, google::bigtable::v2::MutateRowsRequest const& request, @@ -321,8 +313,8 @@ BigtableRandomTwoLeastUsed::PrepareQuery( }); } -std::unique_ptr> +std::unique_ptr< + internal::StreamingReadRpc> BigtableRandomTwoLeastUsed::ExecuteQuery( std::shared_ptr context, Options const& options, google::bigtable::v2::ExecuteQueryRequest const& request, @@ -336,12 +328,11 @@ BigtableRandomTwoLeastUsed::ExecuteQuery( }); } -std::unique_ptr> +std::unique_ptr< + internal::AsyncStreamingReadRpc> BigtableRandomTwoLeastUsed::AsyncReadRows( - google::cloud::CompletionQueue const& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue const& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::ReadRowsRequest const& request, std::shared_ptr operation_context) { return AsyncStreamingHelper( @@ -353,12 +344,11 @@ BigtableRandomTwoLeastUsed::AsyncReadRows( }); } -std::unique_ptr> BigtableRandomTwoLeastUsed::AsyncSampleRowKeys( - google::cloud::CompletionQueue const& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue const& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::SampleRowKeysRequest const& request, std::shared_ptr operation_context) { return AsyncStreamingHelper( @@ -373,9 +363,8 @@ BigtableRandomTwoLeastUsed::AsyncSampleRowKeys( future> BigtableRandomTwoLeastUsed::AsyncMutateRow( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::MutateRowRequest const& request, std::shared_ptr operation_context) { return AsyncHelper>>( @@ -387,12 +376,11 @@ BigtableRandomTwoLeastUsed::AsyncMutateRow( }); } -std::unique_ptr> +std::unique_ptr< + internal::AsyncStreamingReadRpc> BigtableRandomTwoLeastUsed::AsyncMutateRows( - google::cloud::CompletionQueue const& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue const& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::MutateRowsRequest const& request, std::shared_ptr operation_context) { return AsyncStreamingHelper( @@ -406,9 +394,8 @@ BigtableRandomTwoLeastUsed::AsyncMutateRows( future> BigtableRandomTwoLeastUsed::AsyncCheckAndMutateRow( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::CheckAndMutateRowRequest const& request, std::shared_ptr operation_context) { return AsyncHelper< @@ -424,9 +411,8 @@ BigtableRandomTwoLeastUsed::AsyncCheckAndMutateRow( future> BigtableRandomTwoLeastUsed::AsyncPingAndWarm( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::PingAndWarmRequest const& request, std::shared_ptr operation_context) { return AsyncHelper< @@ -441,9 +427,8 @@ BigtableRandomTwoLeastUsed::AsyncPingAndWarm( future> BigtableRandomTwoLeastUsed::AsyncReadModifyWriteRow( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::ReadModifyWriteRowRequest const& request, std::shared_ptr operation_context) { return AsyncHelper< @@ -459,9 +444,8 @@ BigtableRandomTwoLeastUsed::AsyncReadModifyWriteRow( future> BigtableRandomTwoLeastUsed::AsyncPrepareQuery( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::PrepareQueryRequest const& request, std::shared_ptr operation_context) { return AsyncHelper< @@ -487,13 +471,12 @@ BigtableRandomTwoLeastUsed::GetClientConfiguration( }); } -std::unique_ptr<::google::cloud::AsyncStreamingReadWriteRpc< - google::bigtable::v2::SessionRequest, - google::bigtable::v2::SessionResponse>> +std::unique_ptr< + AsyncStreamingReadWriteRpc> BigtableRandomTwoLeastUsed::AsyncOpenTable( - google::cloud::CompletionQueue const& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue const& cq, std::shared_ptr context, + internal::ImmutableOptions options, std::shared_ptr operation_context) { return AsyncStreamingHelper( @@ -505,13 +488,12 @@ BigtableRandomTwoLeastUsed::AsyncOpenTable( }); } -std::unique_ptr<::google::cloud::AsyncStreamingReadWriteRpc< - google::bigtable::v2::SessionRequest, - google::bigtable::v2::SessionResponse>> +std::unique_ptr< + AsyncStreamingReadWriteRpc> BigtableRandomTwoLeastUsed::AsyncOpenAuthorizedView( - google::cloud::CompletionQueue const& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue const& cq, std::shared_ptr context, + internal::ImmutableOptions options, std::shared_ptr operation_context) { return AsyncStreamingHelper( @@ -524,13 +506,12 @@ BigtableRandomTwoLeastUsed::AsyncOpenAuthorizedView( }); } -std::unique_ptr<::google::cloud::AsyncStreamingReadWriteRpc< - google::bigtable::v2::SessionRequest, - google::bigtable::v2::SessionResponse>> +std::unique_ptr< + AsyncStreamingReadWriteRpc> BigtableRandomTwoLeastUsed::AsyncOpenMaterializedView( - google::cloud::CompletionQueue const& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue const& cq, std::shared_ptr context, + internal::ImmutableOptions options, std::shared_ptr operation_context) { return AsyncStreamingHelper( diff --git a/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.h b/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.h index 373e7f59b2ff4..48ddd67cf0d77 100644 --- a/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.h +++ b/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.h @@ -39,14 +39,14 @@ class BigtableRandomTwoLeastUsed : public BigtableStub { return pool_; } - std::unique_ptr> + std::unique_ptr< + internal::StreamingReadRpc> ReadRows(std::shared_ptr context, Options const& options, google::bigtable::v2::ReadRowsRequest const& request, std::shared_ptr operation_context) override; - std::unique_ptr> + std::unique_ptr< + internal::StreamingReadRpc> SampleRowKeys(std::shared_ptr context, Options const& options, google::bigtable::v2::SampleRowKeysRequest const& request, @@ -57,8 +57,8 @@ class BigtableRandomTwoLeastUsed : public BigtableStub { google::bigtable::v2::MutateRowRequest const& request, OperationContext& operation_context) override; - std::unique_ptr> + std::unique_ptr< + internal::StreamingReadRpc> MutateRows(std::shared_ptr context, Options const& options, google::bigtable::v2::MutateRowsRequest const& request, @@ -84,73 +84,67 @@ class BigtableRandomTwoLeastUsed : public BigtableStub { google::bigtable::v2::PrepareQueryRequest const& request, OperationContext& operation_context) override; - std::unique_ptr> + std::unique_ptr< + internal::StreamingReadRpc> ExecuteQuery(std::shared_ptr context, Options const& options, google::bigtable::v2::ExecuteQueryRequest const& request, std::shared_ptr operation_context) override; - std::unique_ptr<::google::cloud::internal::AsyncStreamingReadRpc< - google::bigtable::v2::ReadRowsResponse>> - AsyncReadRows(google::cloud::CompletionQueue const& cq, + std::unique_ptr< + internal::AsyncStreamingReadRpc> + AsyncReadRows(CompletionQueue const& cq, std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + internal::ImmutableOptions options, google::bigtable::v2::ReadRowsRequest const& request, std::shared_ptr operation_context) override; - std::unique_ptr<::google::cloud::internal::AsyncStreamingReadRpc< + std::unique_ptr> AsyncSampleRowKeys( - google::cloud::CompletionQueue const& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue const& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::SampleRowKeysRequest const& request, std::shared_ptr operation_context) override; future> AsyncMutateRow( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::MutateRowRequest const& request, std::shared_ptr operation_context) override; - std::unique_ptr<::google::cloud::internal::AsyncStreamingReadRpc< - google::bigtable::v2::MutateRowsResponse>> - AsyncMutateRows(google::cloud::CompletionQueue const& cq, + std::unique_ptr< + internal::AsyncStreamingReadRpc> + AsyncMutateRows(CompletionQueue const& cq, std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + internal::ImmutableOptions options, google::bigtable::v2::MutateRowsRequest const& request, std::shared_ptr operation_context) override; future> AsyncCheckAndMutateRow( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::CheckAndMutateRowRequest const& request, std::shared_ptr operation_context) override; future> AsyncPingAndWarm( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::PingAndWarmRequest const& request, std::shared_ptr operation_context) override; future> AsyncReadModifyWriteRow( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::ReadModifyWriteRowRequest const& request, std::shared_ptr operation_context) override; future> AsyncPrepareQuery( - google::cloud::CompletionQueue& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue& cq, std::shared_ptr context, + internal::ImmutableOptions options, google::bigtable::v2::PrepareQueryRequest const& request, std::shared_ptr operation_context) override; @@ -159,30 +153,28 @@ class BigtableRandomTwoLeastUsed : public BigtableStub { google::bigtable::v2::GetClientConfigurationRequest const& request, OperationContext& operation_context) override; - std::unique_ptr<::google::cloud::AsyncStreamingReadWriteRpc< - google::bigtable::v2::SessionRequest, - google::bigtable::v2::SessionResponse>> - AsyncOpenTable(google::cloud::CompletionQueue const& cq, + std::unique_ptr< + AsyncStreamingReadWriteRpc> + AsyncOpenTable(CompletionQueue const& cq, std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + internal::ImmutableOptions options, std::shared_ptr operation_context) override; - std::unique_ptr<::google::cloud::AsyncStreamingReadWriteRpc< - google::bigtable::v2::SessionRequest, - google::bigtable::v2::SessionResponse>> + std::unique_ptr< + AsyncStreamingReadWriteRpc> AsyncOpenAuthorizedView( - google::cloud::CompletionQueue const& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue const& cq, std::shared_ptr context, + internal::ImmutableOptions options, std::shared_ptr operation_context) override; - std::unique_ptr<::google::cloud::AsyncStreamingReadWriteRpc< - google::bigtable::v2::SessionRequest, - google::bigtable::v2::SessionResponse>> + std::unique_ptr< + AsyncStreamingReadWriteRpc> AsyncOpenMaterializedView( - google::cloud::CompletionQueue const& cq, - std::shared_ptr context, - google::cloud::internal::ImmutableOptions options, + CompletionQueue const& cq, std::shared_ptr context, + internal::ImmutableOptions options, std::shared_ptr operation_context) override; private: diff --git a/google/cloud/bigtable/internal/stub_manager_test.cc b/google/cloud/bigtable/internal/stub_manager_test.cc index d8b2e7cdc750b..8e217e9f87c48 100644 --- a/google/cloud/bigtable/internal/stub_manager_test.cc +++ b/google/cloud/bigtable/internal/stub_manager_test.cc @@ -1,4 +1,3 @@ -#include "google/cloud/bigtable/internal/operation_context.h" // Copyright 2026 Google LLC // // Licensed under the Apache License, Version 2.0 (the "License"); @@ -13,8 +12,9 @@ // See the License for the specific language governing permissions and // limitations under the License. -#include "google/cloud/bigtable/instance_resource.h" #include "google/cloud/bigtable/internal/stub_manager.h" +#include "google/cloud/bigtable/instance_resource.h" +#include "google/cloud/bigtable/internal/operation_context.h" #include "google/cloud/bigtable/table_resource.h" #include "google/cloud/bigtable/testing/mock_bigtable_stub.h" #include "google/cloud/testing_util/scoped_log.h" @@ -43,7 +43,7 @@ TEST(StubManagerTest, NoAffinity) { EXPECT_CALL(*mock, MutateRow) .WillOnce([&](grpc::ClientContext&, Options const&, google::bigtable::v2::MutateRowRequest const& request, - auto const&) { + OperationContext&) { EXPECT_THAT(request.table_name(), Eq(expected_table_name)); return google::bigtable::v2::MutateRowResponse{}; }); @@ -69,7 +69,7 @@ TEST(StubManagerTest, AffinityToExistingInstance) { .WillOnce([instance_name = instance.FullName()]( grpc::ClientContext&, Options const&, google::bigtable::v2::MutateRowRequest const& request, - auto const&) { + OperationContext&) { EXPECT_THAT(request.table_name(), StartsWith(instance_name)); return google::bigtable::v2::MutateRowResponse{}; }); @@ -111,7 +111,7 @@ TEST(StubManagerTest, AffinityToMissingInstance) { .WillOnce([instance_name = std::string{instance_name}]( grpc::ClientContext&, Options const&, google::bigtable::v2::MutateRowRequest const& request, - auto const&) { + OperationContext&) { EXPECT_THAT(request.table_name(), StartsWith(instance_name)); return google::bigtable::v2::MutateRowResponse{}; }); From 85b57c82eb13e495022d7287255567bd76890625 Mon Sep 17 00:00:00 2001 From: Scott Hart Date: Sat, 22 Aug 2026 14:18:13 -0400 Subject: [PATCH 2/3] address review comments --- ...igtable_random_two_least_used_decorator.cc | 34 ++++++++----------- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc b/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc index 60769ad256ea3..2cb501b017754 100644 --- a/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc +++ b/google/cloud/bigtable/internal/bigtable_random_two_least_used_decorator.cc @@ -31,7 +31,7 @@ template class StreamingReadRpcTracking : public internal::StreamingReadRpc { public: StreamingReadRpcTracking(std::unique_ptr> child, - std::function on_destruction) + std::function on_destruction) : child_(std::move(child)), on_destruction_(std::move(on_destruction)) {} ~StreamingReadRpcTracking() override { on_destruction_(); } @@ -46,7 +46,7 @@ class StreamingReadRpcTracking : public internal::StreamingReadRpc { private: std::unique_ptr> child_; - std::function on_destruction_; + std::function on_destruction_; }; template @@ -55,7 +55,7 @@ class AsyncStreamingReadRpcTracking public: AsyncStreamingReadRpcTracking( std::unique_ptr> child, - std::function on_destruction) + std::function on_destruction) : child_(std::move(child)), on_destruction_(std::move(on_destruction)) {} ~AsyncStreamingReadRpcTracking() override { on_destruction_(); } @@ -70,7 +70,7 @@ class AsyncStreamingReadRpcTracking private: std::unique_ptr> child_; - std::function on_destruction_; + std::function on_destruction_; }; template @@ -79,7 +79,7 @@ class AsyncStreamingReadWriteRpcTracking public: AsyncStreamingReadWriteRpcTracking( std::unique_ptr> child, - std::function on_destruction) + std::function on_destruction) : child_(std::move(child)), on_destruction_(std::move(on_destruction)) {} ~AsyncStreamingReadWriteRpcTracking() override { on_destruction_(); } @@ -98,13 +98,13 @@ class AsyncStreamingReadWriteRpcTracking private: std::unique_ptr> child_; - std::function on_destruction_; + std::function on_destruction_; }; template Response UnaryHelper(std::shared_ptr>& pool, OperationContext& oc, - std::function fn) { + std::function const& fn) { SelectedChannel selection = pool->GetChannelRandomTwoLeastUsed(); oc.StubSelection(StubSelectionParams{ @@ -119,7 +119,7 @@ Response UnaryHelper(std::shared_ptr>& pool, template Response AsyncHelper(std::shared_ptr>& pool, std::shared_ptr const& operation_context, - std::function fn) { + std::function const& fn) { SelectedChannel selection = pool->GetChannelRandomTwoLeastUsed(); if (operation_context != nullptr) { @@ -137,9 +137,8 @@ template std::unique_ptr> StreamingHelper( std::shared_ptr>& pool, std::shared_ptr const& operation_context, - std::function< - std::unique_ptr>(BigtableStub&)> - fn) { + std::function>( + BigtableStub&)> const& fn) { SelectedChannel selection = pool->GetChannelRandomTwoLeastUsed(); if (operation_context != nullptr) { @@ -162,8 +161,7 @@ std::unique_ptr> AsyncStreamingHelper( std::shared_ptr>& pool, std::shared_ptr const& operation_context, std::function>( - BigtableStub&)> - fn) { + BigtableStub&)> const& fn) { SelectedChannel selection = pool->GetChannelRandomTwoLeastUsed(); if (operation_context != nullptr) { @@ -183,12 +181,10 @@ std::unique_ptr> AsyncStreamingHelper( template std::unique_ptr> -AsyncStreamingHelper( - std::shared_ptr>& pool, - std::shared_ptr const& operation_context, - std::function>(BigtableStub&)> - fn) { +AsyncStreamingHelper(std::shared_ptr>& pool, + std::shared_ptr const& operation_context, + std::function>(BigtableStub&)> const& fn) { SelectedChannel selection = pool->GetChannelRandomTwoLeastUsed(); if (operation_context != nullptr) { From b86c2dc726b67d6826f7970b83be3f8cd8abb1df Mon Sep 17 00:00:00 2001 From: Scott Hart Date: Sat, 22 Aug 2026 15:36:16 -0400 Subject: [PATCH 3/3] disable running geminidataanalytics quickstart in production --- google/cloud/geminidataanalytics/CMakeLists.txt | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/google/cloud/geminidataanalytics/CMakeLists.txt b/google/cloud/geminidataanalytics/CMakeLists.txt index 6c9a641884356..59699548a2806 100644 --- a/google/cloud/geminidataanalytics/CMakeLists.txt +++ b/google/cloud/geminidataanalytics/CMakeLists.txt @@ -31,8 +31,6 @@ if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS) $ GOOGLE_CLOUD_PROJECT GOOGLE_CLOUD_CPP_TEST_REGION) set_tests_properties( - geminidataanalytics_quickstart - PROPERTIES - LABELS "integration-test;quickstart" PASS_REGULAR_EXPRESSION - "Permanent error.*gcloud-cpp.retry.function=ListConversations") + geminidataanalytics_quickstart PROPERTIES DISABLED "True" LABELS + "integration-test;quickstart") endif ()