Skip to content

Commit 961a209

Browse files
authored
chore(storage): reduce deprecation warnings from tests (#16405)
1 parent 7ab3923 commit 961a209

4 files changed

Lines changed: 8 additions & 2 deletions

File tree

google/cloud/storage/internal/async/writer_connection_impl_test.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15+
// TODO(#16404): Remove deprecation disable include.
16+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1517
#include "google/cloud/storage/internal/async/writer_connection_impl.h"
1618
#include "google/cloud/mocks/mock_async_streaming_read_write_rpc.h"
1719
#include "google/cloud/storage/async/options.h"

google/cloud/storage/internal/checksum_helpers_test.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15+
// TODO(#16404): Remove deprecation disable include.
16+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1517
#include "google/cloud/storage/internal/checksum_helpers.h"
1618
#include "google/cloud/storage/internal/object_requests.h"
1719
#include <gtest/gtest.h>

google/cloud/storage/internal/object_requests_test.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15+
// TODO(#16404): Remove deprecation disable include.
16+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1517
#include "google/cloud/storage/internal/object_requests.h"
1618
#include "google/cloud/storage/internal/object_access_control_parser.h"
1719
#include "google/cloud/storage/internal/object_acl_requests.h"
@@ -189,7 +191,6 @@ TEST(ObjectRequestsTest, InsertObjectMediaUpdateContents) {
189191
EXPECT_EQ("new contents", request.payload());
190192
}
191193

192-
#include "google/cloud/internal/disable_deprecation_warnings.inc"
193194
TEST(ObjectRequestsTest, InsertObjectBackwardsCompat) {
194195
auto const payload =
195196
std::string("The quick brown fox jumps over the lazy dog");
@@ -201,7 +202,6 @@ TEST(ObjectRequestsTest, InsertObjectBackwardsCompat) {
201202
EXPECT_EQ(zebras, request.payload());
202203
EXPECT_EQ(zebras, request.contents());
203204
}
204-
#include "google/cloud/internal/diagnostics_pop.inc"
205205

206206
TEST(ObjectRequestsTest, Copy) {
207207
CopyObjectRequest request("source-bucket", "source-object", "my-bucket",

google/cloud/storage/internal/signed_url_requests_test.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15+
// TODO(#16404): Remove deprecation disable include.
16+
#include "google/cloud/internal/disable_deprecation_warnings.inc"
1517
#include "google/cloud/storage/internal/signed_url_requests.h"
1618
#include "google/cloud/internal/format_time_point.h"
1719
#include "google/cloud/internal/parse_rfc3339.h"

0 commit comments

Comments
 (0)