Skip to content

Commit 842dfb2

Browse files
authored
fix(storage): Use append_object_spec in EnrichSpan for ResumeAppendableUpload (#16296)
1 parent 858aa52 commit 842dfb2

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

google/cloud/storage/internal/async/connection_tracing.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@ class AsyncConnectionTracing : public storage::AsyncConnection {
125125
ResumeAppendableObjectUpload(AppendableUploadParams p) override {
126126
auto span = internal::MakeSpan(
127127
"storage::AsyncConnection::ResumeAppendableObjectUpload");
128-
EnrichSpan(*span, p.options,
129-
p.request.write_object_spec().resource().bucket());
128+
EnrichSpan(*span, p.options, p.request.append_object_spec().bucket());
130129
internal::OTelScope scope(span);
131130
return impl_->ResumeAppendableObjectUpload(std::move(p))
132131
.then([oc = opentelemetry::context::RuntimeContext::GetCurrent(),

google/cloud/storage/internal/async/connection_tracing_test.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -722,9 +722,12 @@ TEST(ConnectionTracing, ResumeAppendableObjectUploadSuccess) {
722722

723723
EXPECT_CALL(*mock, ResumeAppendableObjectUpload).WillOnce(expect_context(p));
724724
auto actual = MakeTracingAsyncConnection(std::move(mock));
725+
google::storage::v2::BidiWriteObjectRequest request;
726+
request.mutable_append_object_spec()->set_bucket("test-bucket");
725727
auto f = actual
726728
->ResumeAppendableObjectUpload(
727-
AsyncConnection::AppendableUploadParams{})
729+
AsyncConnection::AppendableUploadParams{request,
730+
TracingEnabled()})
728731
.then(expect_no_context);
729732

730733
auto mock_writer = std::make_unique<MockAsyncWriterConnection>();

0 commit comments

Comments
 (0)