Skip to content

Commit 2c5673e

Browse files
committed
fix clang tidy issues
1 parent 8998d11 commit 2c5673e

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

google/cloud/internal/external_account_integration_test.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
3131
namespace {
3232

3333
using ::google::cloud::internal::GetEnv;
34+
#ifdef GOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB
3435
using ::google::cloud::testing_util::IsOkAndHolds;
35-
36-
auto constexpr kEndpointThatUsesRAB = "storage.googleapis.com";
36+
#endif
3737

3838
MATCHER_P(NonEmptyHttpHeaderNameIs, header_name, "has non-empty header named") {
3939
return header_name == arg.name() && !arg.EmptyValues();
@@ -151,6 +151,7 @@ TEST(ExternalAccountIntegrationTest, ExternalAccountCredentials) {
151151

152152
TEST(ExternalAccountIntegrationTest, RABExternalAccountCredentials) {
153153
#ifdef GOOGLE_CLOUD_CPP_TESTING_ENABLE_RAB
154+
auto constexpr kEndpointThatUsesRAB = "storage.googleapis.com";
154155
auto contents = GetExternalAccountCredentialsContents();
155156
if (contents.empty()) GTEST_SKIP();
156157

@@ -175,7 +176,7 @@ TEST(ExternalAccountIntegrationTest, RABExternalAccountCredentials) {
175176
IsOkAndHolds(::testing::Contains(NonEmptyHttpHeaderNameIs(
176177
std::string{"x-allowed-locations"}))));
177178
#else
178-
GTEST_SKIP();
179+
GTEST_SKIP() << "RAB testing is not enabled";
179180
#endif
180181
} // namespace
181182
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END

0 commit comments

Comments
 (0)