removing unnecessary code

Author: bajajneha27

google/cloud/storage/internal/tracing_connection.cc

@@ -18,7 +18,6 @@
 #include "google/cloud/storage/parallel_upload.h"
 #include "google/cloud/internal/opentelemetry.h"
 #include "google/cloud/internal/rest_pure_background_threads_impl.h"
-#include <algorithm>
 #include <memory>
 #include <string>
 #include <utility>

google/cloud/storage/internal/tracing_connection_test.cc

@@ -67,7 +67,7 @@ TEST(TracingClientTest, Options) {
 TEST(TracingClientTest, CustomAsyncRunner) {
   TracingConnection::ResetCacheForTesting();
   bool invoked = false;
-  auto runner = [&invoked](std::function<void()> f) {
+  auto runner = [&invoked](std::function<void()> const& f) {
     invoked = true;
     f();
   };

google/cloud/storage/tests/object_plenty_clients_serially_integration_test.cc

@@ -17,7 +17,6 @@
 #include "google/cloud/storage/testing/storage_integration_test.h"
 #include "google/cloud/internal/getenv.h"
 #include "google/cloud/log.h"
-#include "google/cloud/opentelemetry_options.h"
 #include "google/cloud/status_or.h"
 #include "google/cloud/testing_util/expect_exception.h"
 #include "google/cloud/testing_util/status_matchers.h"
@@ -44,18 +43,26 @@ TEST_F(ObjectPlentyClientsSeriallyIntegrationTest, PlentyClientsSerially) {
   // own tests.
   if (UsingGrpc()) GTEST_SKIP();
 
-  auto options =
-      Options{}.set<google::cloud::OpenTelemetryTracingOption>(false);
+  // With the advent of Regional Access Boundaries, connecting to non-regional
+  // endpoints requires background calls to IAM. These background calls use
+  // additional file descriptors which causes this test to fail when using the
+  // default endpoint.
+  auto regional_bucket = google::cloud::internal::GetEnv(
+      "GOOGLE_CLOUD_CPP_STORAGE_TEST_DESTINATION");
+  if (!regional_bucket.has_value()) GTEST_SKIP();
+  bucket_name_ = *regional_bucket;
+  // The regional_bucket was created in the us-west2 region.
+  auto options = Options{}.set<RestEndpointOption>(
+      "https://storage.us-west2.rep.googleapis.com");
+  auto client = MakeIntegrationTestClient(options);
+
   auto object_name = MakeRandomObjectName();
   std::string expected = LoremIpsum();
 
-  {
-    auto client = MakeIntegrationTestClient(options);
-    StatusOr<ObjectMetadata> meta = client.InsertObject(
-        bucket_name_, object_name, expected, IfGenerationMatch(0));
-    ASSERT_STATUS_OK(meta);
-    ScheduleForDelete(*meta);
-  }
+  StatusOr<ObjectMetadata> meta = client.InsertObject(
+      bucket_name_, object_name, expected, IfGenerationMatch(0));
+  ASSERT_STATUS_OK(meta);
+  ScheduleForDelete(*meta);
 
   // Track the number of open files to ensure every client creates the same
   // number of file descriptors and none are leaked.

google/cloud/storage/tests/object_plenty_clients_simultaneously_integration_test.cc

@@ -16,7 +16,6 @@
 #include "google/cloud/storage/testing/object_integration_test.h"
 #include "google/cloud/storage/testing/storage_integration_test.h"
 #include "google/cloud/log.h"
-#include "google/cloud/opentelemetry_options.h"
 #include "google/cloud/status_or.h"
 #include "google/cloud/testing_util/expect_exception.h"
 #include "google/cloud/testing_util/status_matchers.h"
@@ -46,24 +45,21 @@ TEST_F(ObjectPlentyClientsSimultaneouslyIntegrationTest,
   // own tests.
   if (UsingGrpc()) GTEST_SKIP();
 
-  auto options =
-      Options{}.set<google::cloud::OpenTelemetryTracingOption>(false);
+  auto client = MakeIntegrationTestClient();
   auto object_name = MakeRandomObjectName();
   std::string expected = LoremIpsum();
 
-  {
-    auto client = MakeIntegrationTestClient(options);
-    StatusOr<ObjectMetadata> meta = client.InsertObject(
-        bucket_name_, object_name, expected, IfGenerationMatch(0));
-    ASSERT_STATUS_OK(meta);
-    ScheduleForDelete(*meta);
-  }
+  // Create the object, but only if it does not exist already.
+  StatusOr<ObjectMetadata> meta = client.InsertObject(
+      bucket_name_, object_name, expected, IfGenerationMatch(0));
+  ASSERT_STATUS_OK(meta);
+  ScheduleForDelete(*meta);
 
   auto num_fds_before_test = GetNumOpenFiles();
   std::vector<Client> read_clients;
   std::vector<ObjectReadStream> read_streams;
   for (int i = 0; i != 100; ++i) {
-    auto read_client = MakeIntegrationTestClient(options);
+    auto read_client = MakeIntegrationTestClient();
     auto stream = read_client.ReadObject(bucket_name_, object_name);
     char c;
     stream.read(&c, 1);