Skip to content

[Audit 2026-04-14] Build and CI blockers from static checks #53

Description

@yanghao1143

Summary

Static checks uncovered build/CI blockers and release pipeline hazards.

Findings

  • High | confirmed redundant condition in DAL fails vet/build checks.
    • Evidence: pkg/dal/dal.go:88
  • Medium-High | confirmed unreachable code reported by vet.
    • Evidence: sys/private/biz/menu_seed.go:37
  • High | probable panic-based error handling in data initialization can amplify transient failures.
    • Evidence: user/private/data/data.go:40

Suggested Direction

  • Fix vet blockers immediately to restore CI reliability.
  • Replace panic-on-init in data layer with controlled error returns.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions