Error Firestore: Nested transaction error

[manhnd-tda]

@54m
Hi, I encountered a nested transaction error when using Firestore with volcago v1.11.1.

I noticed that this issue might be related to commit Commit Modify. the following line was removed from InsertMultiWithTxFunc:

ctx = context.WithValue(ctx, transactionInProgressKey{}, 1)

Could you clarify:

• The reason behind this change?
• The recommended way to handle or avoid this error?

Thanks in advance!

[54m]

@manhnd-tda
This change was made to prevent NestedTransactionError by starting a separate transaction for uniqueness checks.

If you're encountering a NestedTransactionError, it's likely that you've already started a transaction at a higher level in your code. I recommend reviewing your transaction flow to identify where nesting might be occurring.

This could also be a potential bug. If possible, please share a code example that reproduces the issue so we can help troubleshoot it more effectively.

Thanks

[manhnd-tda]

@54m

Currently, the InsertMultiWithTx function calls beforeInsert, which in turn calls CheckUnique. Inside CheckUnique, the following logic is executed:

volcago/generator/templates/unique.go.tmpl

Lines 216 to 220 in e493a62

	if tx := ctx.Value(transactionInProgressKey{}); tx != nil {
	err = cb(ctx, tx.(*firestore.Transaction))
	} else {
	err = repo.firestoreClient.RunTransaction(ctx, cb)
	}

Since context.WithValue was not used to store transactionInProgressKey, the above logic triggers RunTransaction, leading to the "firestore: nested transaction" error.

My Suggestion:

Add the following line inside InsertMultiWithTx to ensure the transaction is properly passed in the context:

ctx = context.WithValue(ctx, transactionInProgressKey{}, tx)

This will prevent RunTransaction from being called again inside CheckUnique.