Skip to content
This repository was archived by the owner on Sep 1, 2022. It is now read-only.
This repository was archived by the owner on Sep 1, 2022. It is now read-only.

Community feedback #58

Description

@hectorsector

Reported by @derp-derp-derp in the GitHub community forum:

  1. https://github.com/derp-derp-derp/intro-react/pull/2#pullrequestreview-382243172
    Here it says "Then, at the bottom of our render method, we loop through out this.props.currList." I think that's supposed to say "we loop through our".

  2. https://github.com/derp-derp-derp/intro-react/pull/2#pullrequestreview-382252223
    Here it says "Take at the method on line 30 in src/App.jsx". I think that's supposed to say "Take a look at".

  3. https://github.com/derp-derp-derp/intro-react/pull/2#pullrequestreview-382252256
    Here it says "git commit -m "create addStudents method". The method is actually called addStudent, singular.

  4. https://github.com/derp-derp-derp/intro-react/pull/2#pullrequestreview-382258873
    Here it says "Navigate to src/List.jsx and take a look at the code between lines 18 and 25 in src/List.jsx.". The last bit " in src/List.jsx" seems redundant.

  5. At the end of the course there's a warning in the console "Warning: Each child in a list should have a unique “key” prop" forsrc/Table.jsx: https://imgur.com/a/xZsz3zn
    Here's the fix for that: https://github.com/derp-derp-derp/intro-react/pull/2/commits/bf4a32e1af0ec36f19fe4a398ee1d90a0dc1895...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions