Fix race condition in handleRemoveHistoryItem causing wrong current item on Windows

The `handleRemoveHistoryItem` method called `getCurrent()` after several async
operations. On Windows, VS Code fires `onDidChangeSelection` asynchronously
during awaits (after `refresh()` from `remove()`), which could change the
current item to an unexpected value before `getCurrent()` was called.

Fix by:
1. Capturing the current item *before* any async operations in
   `handleRemoveHistoryItem`, and restoring it afterwards if the item is still
   in history (i.e. it was not one of the removed items). Also add an explicit
   `setCurrentItem(current)` call before `reveal` to sync the internal state in
   case a deferred `onDidChangeSelection` changed it during the awaits.
2. Mocking `showInformationMessageWithAction` in the test to return immediately
   instead of calling the real VS Code API, which could trigger additional async
   event processing.

Fixes the failing "Test (windows-latest)" CI job:
  QueryHistoryManager › handleRemoveHistoryItem › when the item is a variant
  analysis › when in progress › when the item being removed is not selected
  › should not change the selection

Author: Copilot

extensions/ql-vscode/src/query-history/query-history-manager.ts

@@ -565,6 +565,13 @@ export class QueryHistoryManager extends DisposableObject {
   }
 
   async handleRemoveHistoryItem(items: QueryHistoryInfo[]) {
+    // Capture the current item before any async operations. VS Code may fire
+    // onDidChangeSelection asynchronously during awaits below (e.g. after the
+    // tree is refreshed by remove()), changing treeDataProvider.getCurrent() to
+    // an unexpected item. By saving it up front we can restore the correct
+    // selection afterwards.
+    const previousCurrent = this.treeDataProvider.getCurrent();
+
     await Promise.all(
       items.map(async (item) => {
         if (item.t === "local") {
@@ -602,8 +609,22 @@ export class QueryHistoryManager extends DisposableObject {
     );
 
     await this.writeQueryHistory();
-    const current = this.treeDataProvider.getCurrent();
+
+    // If the previously-current item is still in history (i.e. it was not one
+    // of the items being removed), keep it as the current item. Otherwise fall
+    // back to whatever getCurrent() returns, which was set by remove() when the
+    // current item itself was deleted.
+    const current =
+      previousCurrent !== undefined &&
+      this.treeDataProvider.allHistory.includes(previousCurrent)
+        ? previousCurrent
+        : this.treeDataProvider.getCurrent();
+
     if (current !== undefined) {
+      // Explicitly sync the internal current-item state before revealing, in
+      // case a deferred onDidChangeSelection event changed it during the awaits
+      // above.
+      this.treeDataProvider.setCurrentItem(current);
       await this.treeView.reveal(current, { select: true });
       await this.openQueryResults(current);
     }

extensions/ql-vscode/test/vscode-tests/no-workspace/query-history/query-history-manager.test.ts

@@ -331,10 +331,9 @@ describe("QueryHistoryManager", () => {
           .spyOn(dialog, "showBinaryChoiceDialog")
           .mockResolvedValue(true);
 
-        showInformationMessageWithActionSpy = jest.spyOn(
-          dialog,
-          "showInformationMessageWithAction",
-        );
+        showInformationMessageWithActionSpy = jest
+          .spyOn(dialog, "showInformationMessageWithAction")
+          .mockResolvedValue(false);
       });
 
       describe("when in progress", () => {