Stabilize browser tests around navigation

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d6d3b35e-d82a-424a-b0e1-ab8b46814964

Author: Dusty Greif

src/tests/functional/rendering_tests.ts

@@ -67,7 +67,7 @@ test("test reloads when tracked elements change", async ({ page }) => {
 })
 
 test("test reloads when tracked elements change due to failed form submission", async ({ page }) => {
-  await page.click("#tracked-asset-change-form button")
+  await Promise.all([page.waitForNavigation(), page.click("#tracked-asset-change-form button")])
   await page.evaluate(() => {
     window.addEventListener(
       "turbo:reload",
@@ -86,7 +86,7 @@ test("test reloads when tracked elements change due to failed form submission",
     )
   })
 
-  await page.click("#tracked-asset-change-form button")
+  await Promise.all([page.waitForNavigation(), page.click("#tracked-asset-change-form button")])
 
   const reason = await page.evaluate(() => localStorage.getItem("reason"))
   const unloaded = await page.evaluate(() => localStorage.getItem("unloaded"))

src/tests/functional/visit_tests.ts

@@ -44,7 +44,7 @@ test("test programmatically visiting a same-origin location", async ({ page }) =
 
 test("skip programmatically visiting a cross-origin location falls back to window.location", async ({ page }) => {
   const urlBeforeVisit = page.url()
-  await visitLocation(page, "about:blank")
+  await Promise.all([page.waitForNavigation(), visitLocation(page, "about:blank")])
 
   const urlAfterVisit = page.url()
   assert.notEqual(urlBeforeVisit, urlAfterVisit)
@@ -53,8 +53,7 @@ test("skip programmatically visiting a cross-origin location falls back to windo
 
 test("test visiting a location served with a non-HTML content type", async ({ page }) => {
   const urlBeforeVisit = page.url()
-  await visitLocation(page, "/src/tests/fixtures/svg.svg")
-  await nextBeat()
+  await Promise.all([page.waitForNavigation(), visitLocation(page, "/src/tests/fixtures/svg.svg")])
 
   const url = page.url()
   const contentType = await contentTypeOfURL(url)

src/tests/helpers/page.ts

@@ -161,17 +161,25 @@ export function propertyForSelector(page: Page, selector: string, propertyName:
 }
 
 async function readArray<T>(page: Page, identifier: string, length?: number): Promise<T[]> {
-  return page.evaluate(
-    ({ identifier, length }) => {
-      const records = (window as any)[identifier]
-      if (records != null && typeof records.splice == "function") {
-        return records.splice(0, typeof length === "undefined" ? records.length : length)
-      } else {
-        return []
-      }
-    },
-    { identifier, length }
-  )
+  try {
+    return await page.evaluate(
+      ({ identifier, length }) => {
+        const records = (window as any)[identifier]
+        if (records != null && typeof records.splice == "function") {
+          return records.splice(0, typeof length === "undefined" ? records.length : length)
+        } else {
+          return []
+        }
+      },
+      { identifier, length }
+    )
+  } catch (error) {
+    if (!(error instanceof Error) || !error.message.includes("Execution context was destroyed")) {
+      throw error
+    }
+    await nextBeat()
+    return readArray(page, identifier, length)
+  }
 }
 
 export function readEventLogs(page: Page, length?: number): Promise<EventLog[]> {

src/tests/helpers/trusted_type_setup.ts

@@ -15,5 +15,5 @@ test.beforeEach(async ({ page }, workerInfo) => {
 })
 
 test.afterEach(async ({ page }) => {
-  await page.evaluate(() => window.Turbo.setCSPTrustedTypesPolicy(null))
+  await page.evaluate(() => window.Turbo?.setCSPTrustedTypesPolicy(null))
 })