Skip to content

Commit 6237ced

Browse files
committed
docs(plan): include all pending modified files
1 parent a29fa7f commit 6237ced

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

1917-java-embed-rust-cli-runtime-remove-before-merge/1917-embed-cli-runtime-ignorance-reduction-plan.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -961,10 +961,11 @@ Every implementation step in this phase **must** follow this test-driven workflo
961961
3. **Refactor.** Clean up the implementation while keeping tests green. Run `mvn spotless:apply` to ensure formatting compliance.
962962
4. **Gate before proceeding.** All tests from the current step **and all prior steps** must pass (`mvn verify`) before moving to the next step. Do not proceed with a step if any prior step's tests are broken.
963963
5. **Coverage expectations per step:**
964-
- Every public method must have at least one test exercising the success path and one test exercising the primary failure/edge-case path.
965-
- Error handling paths (e.g., missing native binary, failed `host_start`, callback on closed connection) must have explicit tests — do not assume "it would throw."
966-
- Platform-specific behavior in this phase is limited to Ubuntu `linux-x64` only. Do not add implementation-specific tests for other OS/arch pairs in this phase.
967-
- Thread-safety-sensitive code (callback handling, stream bridging, shutdown draining) must have concurrency tests — e.g., multiple threads writing/reading simultaneously, shutdown during active callback.
964+
965+
- Every public method must have at least one test exercising the success path and one test exercising the primary failure/edge-case path.
966+
- Error handling paths (e.g., missing native binary, failed `host_start`, callback on closed connection) must have explicit tests — do not assume "it would throw."
967+
- Platform-specific behavior in this phase is limited to Ubuntu `linux-x64` only. Do not add implementation-specific tests for other OS/arch pairs in this phase.
968+
- Thread-safety-sensitive code (callback handling, stream bridging, shutdown draining) must have concurrency tests — e.g., multiple threads writing/reading simultaneously, shutdown during active callback.
968969

969970
6. **Test isolation.** Each step's tests must be runnable independently of whether a real `runtime.node` binary is present. Unit tests must use mocks, test doubles, or minimal test native libraries — never depend on the real runtime binary. Only E2E integration tests (step 4.7) require the real binary.
970971
7. **No skipping tests.** Do not annotate tests with `@Disabled` or `@Ignore` to work around failures. If a test cannot pass, fix the production code or fix the test.

0 commit comments

Comments
 (0)