Commit 5000d02
Close the two remaining reviewer findings on isTerminal
The automated reviewer raised two suppressed findings against the new
Tool.isTerminal field. Both were accurate.
Rust: Tool has a hand-written Debug impl that enumerates every other
serializable field, so is_terminal was silently missing from its output
and a terminal tool debug-printed identically to a plain one. Add the
field in declaration order, plus a test that fails if the hand-written
impl drifts again.
Python: dotnet, go, java, nodejs and rust all assert that isTerminal
reaches the wire on both the session.create and session.resume paths and
is omitted at its default. Python was the only SDK without that
coverage. Add the test, mirroring the adjacent tool-metadata test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 012f981 commit 5000d02
2 files changed
Lines changed: 58 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
793 | 793 | | |
794 | 794 | | |
795 | 795 | | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
| 834 | + | |
796 | 835 | | |
797 | 836 | | |
798 | 837 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
530 | 530 | | |
531 | 531 | | |
532 | 532 | | |
| 533 | + | |
533 | 534 | | |
534 | 535 | | |
535 | 536 | | |
| |||
7562 | 7563 | | |
7563 | 7564 | | |
7564 | 7565 | | |
| 7566 | + | |
| 7567 | + | |
| 7568 | + | |
| 7569 | + | |
| 7570 | + | |
| 7571 | + | |
| 7572 | + | |
| 7573 | + | |
| 7574 | + | |
| 7575 | + | |
| 7576 | + | |
| 7577 | + | |
| 7578 | + | |
| 7579 | + | |
| 7580 | + | |
| 7581 | + | |
| 7582 | + | |
| 7583 | + | |
7565 | 7584 | | |
0 commit comments