Fail approve-all in managed sessions

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: joshspicer

dotnet/README.md

@@ -37,7 +37,7 @@ using GitHub.Copilot;
 await using var client = new CopilotClient();
 await client.StartAsync();
 
-// ApproveAll approves ordinary requests; managed requests still require a human decision.
+// ApproveAll is only valid when managed settings are disabled.
 await using var session = await client.CreateSessionAsync(new SessionConfig
 {
     Model = "gpt-5",
@@ -125,7 +125,7 @@ Create a new conversation session.
 - `Provider` - Custom API provider configuration (BYOK)
 - `Streaming` - Enable streaming of response chunks (default: false)
 - `InfiniteSessions` - Configure automatic context compaction (see below)
-- `OnPermissionRequest` - Optional handler called before each tool execution to approve or deny it. When omitted, permission requests are emitted as events and left pending for manual resolution. `PermissionHandler.ApproveAll` approves ordinary requests automatically; requests with `ManagedApprovalRequired == true` remain pending for explicit resolution through a human-facing host flow. See [Permission Handling](#permission-handling) section.
+- `OnPermissionRequest` - Optional handler called before each tool execution to approve or deny it. When omitted, permission requests are emitted as events and left pending for manual resolution. `PermissionHandler.ApproveAll` approves requests when managed settings are disabled and throws when `EnableManagedSettings` is true. Custom handlers can inspect `ManagedApprovalRequired` for human-facing confirmation logic. See [Permission Handling](#permission-handling) section.
 - `OnUserInputRequest` - Handler for user input requests from the agent (enables ask_user tool). See [User Input Requests](#user-input-requests) section.
 - `Hooks` - Hook handlers for session lifecycle events. See [Session Hooks](#session-hooks) section.
 

dotnet/src/Client.cs

@@ -783,7 +783,9 @@ private CopilotSession InitializeSession(
             _logger,
             this);
         session.RegisterTools(config.Tools ?? []);
-        session.RegisterPermissionHandler(config.OnPermissionRequest);
+        session.RegisterPermissionHandler(
+            config.OnPermissionRequest,
+            config.EnableManagedSettings is true);
         session.RegisterMcpAuthHandler(config.OnMcpAuthRequest);
         session.RegisterCommands(config.Commands);
         session.RegisterElicitationHandler(config.OnElicitationRequest);

dotnet/src/PermissionHandlers.cs

@@ -10,22 +10,11 @@ namespace GitHub.Copilot;
 public static class PermissionHandler
 {
     /// <summary>
-    /// A permission handler that approves ordinary requests and leaves managed
-    /// requests pending for an explicit human decision.
+    /// A permission handler that approves requests when managed settings are disabled.
     /// </summary>
     public static Func<PermissionRequest, PermissionInvocation, Task<PermissionDecision>> ApproveAll { get; } =
-        (request, _) => Task.FromResult(
-            RequiresManagedApproval(request)
-                ? PermissionDecision.NoResult()
-                : PermissionDecision.ApproveOnce());
-
-    private static bool RequiresManagedApproval(PermissionRequest request) =>
-        request switch
-        {
-            PermissionRequestShell { ManagedApprovalRequired: true } => true,
-            PermissionRequestWrite { ManagedApprovalRequired: true } => true,
-            PermissionRequestRead { ManagedApprovalRequired: true } => true,
-            PermissionRequestUrl { ManagedApprovalRequired: true } => true,
-            _ => false,
-        };
+        (_, invocation) => invocation.ManagedSettingsEnabled
+            ? Task.FromException<PermissionDecision>(
+                new InvalidOperationException("ApproveAll cannot be used when managed settings are enabled"))
+            : Task.FromResult(PermissionDecision.ApproveOnce());
 }

dotnet/src/Session.cs

@@ -63,6 +63,7 @@ public sealed partial class CopilotSession : IAsyncDisposable
     private readonly CopilotClient _parentClient;
 
     private volatile Func<PermissionRequest, PermissionInvocation, Task<PermissionDecision>>? _permissionHandler;
+    private bool _managedSettingsEnabled;
     private volatile Func<McpAuthContext, Task<McpAuthResult?>>? _mcpAuthHandler;
     private volatile Func<UserInputRequest, UserInputInvocation, Task<UserInputResponse>>? _userInputHandler;
     private volatile Func<ElicitationContext, Task<ElicitationResult>>? _elicitationHandler;
@@ -557,13 +558,17 @@ internal void RegisterTools(ICollection<AIFunctionDeclaration> tools)
     /// Registers a handler for permission requests.
     /// </summary>
     /// <param name="handler">The permission handler function.</param>
+    /// <param name="managedSettingsEnabled">Whether managed settings are enabled for the session.</param>
     /// <remarks>
     /// When the assistant needs permission to perform certain actions (e.g., file operations),
     /// this handler is called to approve or deny the request.
     /// </remarks>
-    internal void RegisterPermissionHandler(Func<PermissionRequest, PermissionInvocation, Task<PermissionDecision>>? handler)
+    internal void RegisterPermissionHandler(
+        Func<PermissionRequest, PermissionInvocation, Task<PermissionDecision>>? handler,
+        bool managedSettingsEnabled)
     {
         _permissionHandler = handler;
+        _managedSettingsEnabled = managedSettingsEnabled;
     }
 
     internal void RegisterMcpAuthHandler(Func<McpAuthContext, Task<McpAuthResult?>>? handler)
@@ -590,7 +595,8 @@ internal async Task<PermissionDecision> HandlePermissionRequestAsync(JsonElement
 
         var invocation = new PermissionInvocation
         {
-            SessionId = SessionId
+            SessionId = SessionId,
+            ManagedSettingsEnabled = _managedSettingsEnabled
         };
 
         var permissionTimestamp = Stopwatch.GetTimestamp();
@@ -932,7 +938,8 @@ private async Task ExecutePermissionAndRespondAsync(string requestId, Permission
         {
             var invocation = new PermissionInvocation
             {
-                SessionId = SessionId
+                SessionId = SessionId,
+                ManagedSettingsEnabled = _managedSettingsEnabled
             };
 
             var permissionTimestamp = Stopwatch.GetTimestamp();

dotnet/src/Types.cs

@@ -833,6 +833,9 @@ public sealed class PermissionInvocation
     /// Identifier of the session that triggered the permission request.
     /// </summary>
     public string SessionId { get; set; } = string.Empty;
+
+    /// <summary>Whether managed settings are enabled for this session.</summary>
+    public bool ManagedSettingsEnabled { get; set; }
 }
 
 // ============================================================================

dotnet/test/Unit/PermissionHandlerTests.cs

@@ -41,7 +41,7 @@ public void PermissionEventExposesManagedApprovalRequired()
     }
 
     [Fact]
-    public async Task ApproveAllLeavesManagedRequestPending()
+    public async Task ApproveAllThrowsWhenManagedSettingsEnabled()
     {
         var request = new PermissionRequestRead
         {
@@ -50,9 +50,11 @@ public async Task ApproveAllLeavesManagedRequestPending()
             Path = "/workspace/file.txt",
         };
 
-        var decision = await PermissionHandler.ApproveAll(request, new PermissionInvocation());
-
-        Assert.IsType<PermissionDecisionNoResult>(decision);
+        await Assert.ThrowsAsync<InvalidOperationException>(() =>
+            PermissionHandler.ApproveAll(request, new PermissionInvocation
+            {
+                ManagedSettingsEnabled = true,
+            }));
     }
 
     [Fact]

go/README.md

@@ -55,7 +55,7 @@ func main() {
     }
     defer client.Stop()
 
-    // ApproveAll approves ordinary requests; managed requests still require a human decision.
+    // ApproveAll is only valid when managed settings are disabled.
     session, err := client.CreateSession(context.Background(), &copilot.SessionConfig{
         Model:               "gpt-5",
         OnPermissionRequest: copilot.PermissionHandler.ApproveAll,
@@ -215,7 +215,7 @@ Event types: `SessionLifecycleCreated`, `SessionLifecycleDeleted`, `SessionLifec
 - `Provider` (\*ProviderConfig): Custom API provider configuration (BYOK). See [Custom Providers](#custom-providers) section.
 - `Streaming` (*bool): Enable streaming delta events (nil = runtime default)
 - `InfiniteSessions` (\*InfiniteSessionConfig): Automatic context compaction configuration
-- `OnPermissionRequest` (PermissionHandlerFunc): Optional handler called before each tool execution to approve or deny it. When nil, permission requests are emitted as events and left pending for manual resolution. `copilot.PermissionHandler.ApproveAll` approves ordinary requests automatically; requests where `RequiresManagedApproval()` is `true` remain pending for explicit resolution through a human-facing host flow. See [Permission Handling](#permission-handling) section.
+- `OnPermissionRequest` (PermissionHandlerFunc): Optional handler called before each tool execution to approve or deny it. When nil, permission requests are emitted as events and left pending for manual resolution. `copilot.PermissionHandler.ApproveAll` approves requests when managed settings are disabled and returns an error when `EnableManagedSettings` is true. Custom handlers can inspect `RequiresManagedApproval()` for human-facing confirmation logic. See [Permission Handling](#permission-handling) section.
 - `OnUserInputRequest` (UserInputHandler): Handler for user input requests from the agent (enables ask_user tool). See [User Input Requests](#user-input-requests) section.
 - `Hooks` (\*SessionHooks): Hook handlers for session lifecycle events. See [Session Hooks](#session-hooks) section.
 - `Commands` ([]CommandDefinition): Slash-commands registered for this session. See [Commands](#commands) section.

go/client.go

@@ -907,6 +907,7 @@ func (c *Client) CreateSession(ctx context.Context, config *SessionConfig) (*Ses
 	// routed to a registered session.
 	initializeSession := func(sessionID string) (*Session, error) {
 		s := newSession(sessionID, c.client, "")
+		s.managedSettings = config.EnableManagedSettings != nil && *config.EnableManagedSettings
 
 		s.registerTools(config.Tools)
 		s.registerPermissionHandler(config.OnPermissionRequest)
@@ -1228,6 +1229,7 @@ func (c *Client) ResumeSessionWithOptions(ctx context.Context, sessionID string,
 	// Create and register the session before issuing the RPC so that
 	// events emitted by the CLI (e.g. session.start) are not dropped.
 	session := newSession(sessionID, c.client, "")
+	session.managedSettings = config.EnableManagedSettings != nil && *config.EnableManagedSettings
 
 	session.registerTools(config.Tools)
 	session.registerPermissionHandler(config.OnPermissionRequest)

go/permissions.go

@@ -1,18 +1,19 @@
 package copilot
 
 import (
+	"errors"
+
 	"github.com/github/copilot-sdk/go/rpc"
 )
 
 // PermissionHandler provides pre-built OnPermissionRequest implementations.
 var PermissionHandler = struct {
-	// ApproveAll approves ordinary permission requests. Requests that require
-	// managed approval remain pending for an explicit human decision.
+	// ApproveAll approves permission requests when managed settings are disabled.
 	ApproveAll PermissionHandlerFunc
 }{
-	ApproveAll: func(request PermissionRequest, _ PermissionInvocation) (rpc.PermissionDecision, error) {
-		if request.RequiresManagedApproval() {
-			return &rpc.PermissionDecisionNoResult{}, nil
+	ApproveAll: func(_ PermissionRequest, invocation PermissionInvocation) (rpc.PermissionDecision, error) {
+		if invocation.ManagedSettingsEnabled {
+			return nil, errors.New("ApproveAll cannot be used when managed settings are enabled")
 		}
 		return &rpc.PermissionDecisionApproveOnce{}, nil
 	},

go/permissions_test.go

@@ -28,17 +28,16 @@ func TestPermissionEventExposesManagedApprovalRequired(t *testing.T) {
 	}
 }
 
-func TestApproveAllLeavesManagedRequestPending(t *testing.T) {
-	required := true
+func TestApproveAllReturnsErrorWhenManagedSettingsEnabled(t *testing.T) {
 	decision, err := copilot.PermissionHandler.ApproveAll(
-		&copilot.PermissionRequestRead{ManagedApprovalRequired: &required},
-		copilot.PermissionInvocation{SessionID: "session-1"},
+		&copilot.PermissionRequestRead{},
+		copilot.PermissionInvocation{SessionID: "session-1", ManagedSettingsEnabled: true},
 	)
-	if err != nil {
-		t.Fatal(err)
+	if err == nil {
+		t.Fatal("expected an error")
 	}
-	if _, ok := decision.(*rpc.PermissionDecisionNoResult); !ok {
-		t.Fatalf("expected PermissionDecisionNoResult, got %T", decision)
+	if decision != nil {
+		t.Fatalf("expected no decision, got %T", decision)
 	}
 }