Commit 2e54b47
Close Go/.NET shell-test teardown gap
The "should kill shell process" e2e test exists in all five SDKs, but only
Node, Python and Rust destroy the session at the end of it. Go tears the whole
client down with client.ForceStop() and .NET simply ended at the last assert,
so neither ever exercised session.destroy after a session.shell.exec.
That gap is why Go and .NET stayed green on CLI 1.0.76-0 while Node, Python and
Rust hang: the hang is in session.destroy after a shell exec, and the two green
SDKs never made the call. Adding the teardown makes all five cover the same
sequence.
Verified locally against the same CLI binary (1.0.76-0, sha256 b8bfad2c...):
with the added Disconnect(), the Go test hangs past a 3-minute timeout where it
previously passed in seconds. The same test passes on CLI 1.0.73.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e615d062-bcb7-431e-aa9c-d3e47405723a1 parent 951d4bf commit 2e54b47
2 files changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
44 | 46 | | |
45 | 47 | | |
46 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
84 | 88 | | |
85 | 89 | | |
86 | 90 | | |
| |||
0 commit comments