shepherd-tasks-20260730-0204

Author: edburns

1917-java-embed-rust-cli-runtime-remove-before-merge/shepherd-tasks-20260730-0156/20260730-0200-post-mortem.md

@@ -0,0 +1,215 @@
+# Post-Mortem Report: Shepherd Task Batch [#2144](https://github.com/github/copilot-sdk/issues/2144), [#2145](https://github.com/github/copilot-sdk/issues/2145), [#2146](https://github.com/github/copilot-sdk/issues/2146), [#2147](https://github.com/github/copilot-sdk/issues/2147), [#2148](https://github.com/github/copilot-sdk/issues/2148), [#2149](https://github.com/github/copilot-sdk/issues/2149), [#2150](https://github.com/github/copilot-sdk/issues/2150), [#2151](https://github.com/github/copilot-sdk/issues/2151)
+
+**Campaign:** Java embed Rust CLI runtime shepherding (`shepherd-tasks-20260730-0156`)  
+**Report generated:** 2026-07-30 02:00 (local)  
+**Period covered:** 2026-07-30 01:56:50 -> 2026-07-30 02:00:02 (local)  
+**Script exit code:** 0  
+**Base branch:** `edburns/1917-java-embed-rust-cli-runtime-dd-3039145`
+
+## Table of Contents
+
+- [Section 1: Executive Summary](#section-1-executive-summary)
+- [Section 2: System Architecture](#section-2-system-architecture)
+  - [2.1 Copilot Coding Agent (CCA)](#21-copilot-coding-agent-cca)
+  - [2.2 Copilot Code Review Agent (CCRA)](#22-copilot-code-review-agent-ccra)
+  - [2.3 Local Copilot CLI (Shepherd)](#23-local-copilot-cli-shepherd)
+- [Section 3: Per-Task Metrics](#section-3-per-task-metrics)
+  - [Issue Legend](#issue-legend)
+  - [3.1 — Issue #2144 / PR #2152](#31--issue-2144--pr-2152)
+  - [3.2 — Issue #2145](#32--issue-2145)
+  - [3.3 — Issue #2146](#33--issue-2146)
+  - [3.4 — Issue #2147](#34--issue-2147)
+  - [3.5 — Issue #2148](#35--issue-2148)
+  - [3.6 — Issue #2149](#36--issue-2149)
+  - [3.7 — Issue #2150](#37--issue-2150)
+  - [3.8 — Issue #2151](#38--issue-2151)
+- [Section 4: Aggregate Statistics](#section-4-aggregate-statistics)
+- [Section 5: AI Credits and Token Usage](#section-5-ai-credits-and-token-usage)
+- [Section 6: Wall-Clock Timeline](#section-6-wall-clock-timeline)
+- [Section 7: Failure Analysis](#section-7-failure-analysis)
+- [Section 8: Observations and Recommendations](#section-8-observations-and-recommendations)
+
+---
+
+## Section 1: Executive Summary
+
+The run completed one task end-to-end and then stopped, yielding partial campaign completion: [#2144](https://github.com/github/copilot-sdk/issues/2144) was merged via [#2152](https://github.com/github/copilot-sdk/pull/2152), while [#2145](https://github.com/github/copilot-sdk/issues/2145)-[#2151](https://github.com/github/copilot-sdk/issues/2151) had no phase artifacts in this run directory.
+
+| Metric | Value |
+|--------|-------|
+| Target tasks | 8 ([#2144](https://github.com/github/copilot-sdk/issues/2144)-[#2151](https://github.com/github/copilot-sdk/issues/2151)) |
+| Tasks with completed phase 1 + phase 2 | 1/8 (12.5%) |
+| Merged PRs | 1 ([#2152](https://github.com/github/copilot-sdk/pull/2152)) |
+| Campaign elapsed (first start to final event) | ~3m 12s |
+| Phase 1 duration for completed task | 1m 13s |
+| Phase 2 duration for completed task | 1m 54s |
+| Total per-task duration ([#2144](https://github.com/github/copilot-sdk/issues/2144)) | 3m 07s |
+| Copilot review rounds observed (phase 2) | 1 |
+| Copilot review comments generated | 0 |
+| Idle markers in JSON logs | 2 (one in each phase session) |
+
+---
+
+## Section 2: System Architecture
+
+### 2.1 Copilot Coding Agent (CCA)
+
+CCA handled issue assignment-to-PR generation and produced draft PR [#2152](https://github.com/github/copilot-sdk/pull/2152) for task [#2144](https://github.com/github/copilot-sdk/issues/2144), targeting `edburns/1917-java-embed-rust-cli-runtime-dd-3039145`.
+
+### 2.2 Copilot Code Review Agent (CCRA)
+
+CCRA (`copilot-pull-request-reviewer[bot]`) posted a review entry indicating it was unable to review files for [#2152](https://github.com/github/copilot-sdk/pull/2152), resulting in zero actionable inline comments for the phase-2 fix loop.
+
+### 2.3 Local Copilot CLI (Shepherd)
+
+Local Copilot CLI orchestrated both skills (`from-assignment-to-ready`, then `from-ready-to-merged-to-base`), approved workflow gates, validated checks, adapted merge strategy (squash after merge-commit rejection), merged [#2152](https://github.com/github/copilot-sdk/pull/2152), and closed [#2144](https://github.com/github/copilot-sdk/issues/2144).
+
+---
+
+## Section 3: Per-Task Metrics
+
+### Issue Legend
+
+| Issue | PR | Notes |
+|------:|---:|-------|
+| [#2144](https://github.com/github/copilot-sdk/issues/2144) | [#2152](https://github.com/github/copilot-sdk/pull/2152) | Completed in this run; merged and issue closed |
+| [#2145](https://github.com/github/copilot-sdk/issues/2145) | — | No `phase1-task-*2145*` or `phase2-task-*2145*` artifact in this run directory |
+| [#2146](https://github.com/github/copilot-sdk/issues/2146) | — | No artifacts in this run directory |
+| [#2147](https://github.com/github/copilot-sdk/issues/2147) | — | No artifacts in this run directory |
+| [#2148](https://github.com/github/copilot-sdk/issues/2148) | — | No artifacts in this run directory |
+| [#2149](https://github.com/github/copilot-sdk/issues/2149) | — | No artifacts in this run directory |
+| [#2150](https://github.com/github/copilot-sdk/issues/2150) | — | No artifacts in this run directory |
+| [#2151](https://github.com/github/copilot-sdk/issues/2151) | — | No artifacts in this run directory |
+
+### 3.1 — Issue [#2144](https://github.com/github/copilot-sdk/issues/2144) / PR [#2152](https://github.com/github/copilot-sdk/pull/2152)
+
+| Metric | Value |
+|--------|-------|
+| Phase 1 session | `17b7a2f5-bf46-4ba8-b9a0-6f990aa14e48` |
+| Phase 1 start / duration | 01:56:50 / 1m 13s |
+| Phase 2 session | `1402e0e2-bfa1-4118-8169-1665f1f04b04` |
+| Phase 2 start / duration | 01:58:08 / 1m 54s |
+| Total duration | 3m 07s |
+| Review rounds | 1 |
+| Comments generated | 0 (`"Copilot wasn't able to review any files"`) |
+| Outcome | merged ([#2152](https://github.com/github/copilot-sdk/pull/2152)); issue closed ([#2144](https://github.com/github/copilot-sdk/issues/2144)) |
+
+### 3.2 — Issue [#2145](https://github.com/github/copilot-sdk/issues/2145)
+
+No phase artifacts were recorded for this issue in `shepherd-tasks-20260730-0156`.
+
+### 3.3 — Issue [#2146](https://github.com/github/copilot-sdk/issues/2146)
+
+No phase artifacts were recorded for this issue in `shepherd-tasks-20260730-0156`.
+
+### 3.4 — Issue [#2147](https://github.com/github/copilot-sdk/issues/2147)
+
+No phase artifacts were recorded for this issue in `shepherd-tasks-20260730-0156`.
+
+### 3.5 — Issue [#2148](https://github.com/github/copilot-sdk/issues/2148)
+
+No phase artifacts were recorded for this issue in `shepherd-tasks-20260730-0156`.
+
+### 3.6 — Issue [#2149](https://github.com/github/copilot-sdk/issues/2149)
+
+No phase artifacts were recorded for this issue in `shepherd-tasks-20260730-0156`.
+
+### 3.7 — Issue [#2150](https://github.com/github/copilot-sdk/issues/2150)
+
+No phase artifacts were recorded for this issue in `shepherd-tasks-20260730-0156`.
+
+### 3.8 — Issue [#2151](https://github.com/github/copilot-sdk/issues/2151)
+
+No phase artifacts were recorded for this issue in `shepherd-tasks-20260730-0156`.
+
+---
+
+## Section 4: Aggregate Statistics
+
+| Metric | Value |
+|--------|-------|
+| Tasks targeted | 8 |
+| Tasks with observed execution artifacts | 1 |
+| PRs merged | 1 ([#2152](https://github.com/github/copilot-sdk/pull/2152)) |
+| Issues closed | 1 ([#2144](https://github.com/github/copilot-sdk/issues/2144)) |
+| Success rate (target issues closed in this run) | 12.5% |
+| Total phase sessions exported | 2 (phase 1 + phase 2 for [#2144](https://github.com/github/copilot-sdk/issues/2144)) |
+| Total CCRA rounds | 1 |
+| Total CCRA comments | 0 |
+| Avg comments/round | 0.00 |
+| Idle markers | 2 |
+
+Convergence signal for the completed task was strong (single review round, zero fixes required), but campaign-level throughput was low because only one of eight issues progressed in this run directory.
+
+---
+
+## Section 5: AI Credits and Token Usage
+
+| Scope | Input tokens | Output tokens |
+|-------|--------------|---------------|
+| Phase 1 JSON (`phase1-task-20260730-0156-2144.json`) | 0 | 2,934 |
+| Phase 2 JSON (`phase2-task-20260730-0158-2144.json`) | 0 | 3,629 |
+| Aggregate for run directory phase JSONs | 0 | 6,563 |
+
+No explicit CCA/CCRA billing-credit totals were present in local artifacts. Token values above are measured from local Copilot CLI JSON event logs (`assistant.message.outputTokens`/`inputTokens` fields when present).
+
+---
+
+## Section 6: Wall-Clock Timeline
+
+| Time (local) | Event | Evidence |
+|--------------|-------|----------|
+| 01:56:50 | Phase 1 started for [#2144](https://github.com/github/copilot-sdk/issues/2144) | `phase1-task-20260730-0156-2144.md` header |
+| 01:58:03-01:58:04 | Phase 1 completed; [#2152](https://github.com/github/copilot-sdk/pull/2152) ready for review handoff | `SHEPHERD COMPLETE` in phase-1 MD |
+| 01:58:08 | Phase 2 started for [#2144](https://github.com/github/copilot-sdk/issues/2144) | `phase2-task-20260730-0158-2144.md` header |
+| 01:58:xx | Reviewer-request API attempts failed with HTTP 422 for `copilot-pull-request-reviewer` collaborator check | phase-2 MD command output |
+| 01:59:xx | CCRA review result indicated no reviewable files / 0 comments | phase-2 MD review output |
+| 01:59:xx | Merge via `--merge` rejected; repository requires non-merge strategy | `mergePullRequest` error in phase-2 MD |
+| 01:59:xx | Merge retried with `--squash` succeeded for [#2152](https://github.com/github/copilot-sdk/pull/2152) | phase-2 MD merge command output |
+| 02:00:xx | [#2144](https://github.com/github/copilot-sdk/issues/2144) closed; phase 2 marked complete | `gh issue close` + `SHEPHERD COMPLETE` |
+
+Overall run window observed in JSON timestamps: 01:56:52 -> 02:00:02 (~3m 11s).
+
+---
+
+## Section 7: Failure Analysis
+
+Campaign-level failure mode was **incomplete batch execution** (1/8 issues executed in this run directory), despite `SCRIPT_EXIT_CODE=0`.
+
+Observed signatures and handling:
+
+1. Reviewer request failure:
+   - `gh api ... requested_reviewers` returned HTTP 422 (`not a collaborator`) for `copilot-pull-request-reviewer`.
+   - Impact: explicit reviewer request path failed; process still progressed because a bot review event appeared.
+2. Merge strategy mismatch:
+   - `gh pr merge ... --merge` failed with `Merge commits are not allowed on this repository`.
+   - Impact: resolved in-run by fallback to `gh pr merge ... --squash`.
+3. Session termination marker:
+   - `Operation cancelled by user` appears at end of phase-2 export after successful merge/close messages.
+   - Impact: may indicate interactive cancellation after essential steps completed; no evidence of additional task execution afterward in this run directory.
+
+No timeout-based hard failure was observed in this run (no stalled polls; no nonzero tool execution records in phase JSON tool events).
+
+---
+
+## Section 8: Observations and Recommendations
+
+### What worked
+
+- End-to-end path for [#2144](https://github.com/github/copilot-sdk/issues/2144) converged quickly.
+- CI-gate approvals and checks completed cleanly.
+- Merge fallback (`--squash`) recovered from repository merge-policy rejection without manual intervention.
+
+### What did not work
+
+- Batch did not advance beyond the first issue in the provided task list.
+- Reviewer-request behavior is inconsistent with the configured reviewer identity and collaborator permissions.
+- Run-level observability is fragmented when only per-task phase artifacts exist without a unified batch log.
+
+### Recommendations
+
+1. Add an explicit post-task loop checkpoint in the shepherd driver script: after closing one issue, log and assert advancement to the next target issue ([#2145](https://github.com/github/copilot-sdk/issues/2145) here).
+2. Normalize review-request logic to a repository-supported path (or skip explicit request when bot auto-review is known to trigger), and treat HTTP 422 as a tracked warning with deterministic fallback.
+3. Detect repository merge policy before merge attempt and choose `--squash` up front when merge commits are disallowed.
+4. Emit a batch summary artifact listing each target issue and terminal status (`merged`, `failed`, `not-started`) to prevent ambiguity when exit code is zero.
+5. Capture a single top-level `*job-logs.txt` for each shepherd batch in the parent directory; none were present for this run.