fix: remove e2e tests for edge cases

Author: jiaxin.loh

AGENTS.md

@@ -13,6 +13,7 @@ You are an expert software developer handling this repo.
 **Note**:
 - Git CLI commands should be taken from `git.py`.
 - GitHub CLI commands should be taken from `github_cli.py`.
+- E2E tests in `tests/e2e/` cover the happy path only. Do not add failure, edge case, or error handling tests there.
 
 **File Structure**:
   - app/: CLI entry, commands, utils, configs, logging, hooks, __init__.py, cli.py, version.py

tests/e2e/commands/test_download.py

@@ -1,8 +1,7 @@
 import json
 from pathlib import Path
 
-from ..constants import EXERCISE_NAME, HANDS_ON_NAME
-from ..runner import BinaryRunner
+from ..constants import EXERCISE_NAME
 
 
 def test_download_exercise(downloaded_exercise_dir: Path) -> None:
@@ -19,68 +18,3 @@ def test_download_exercise(downloaded_exercise_dir: Path) -> None:
 def test_download_hands_on(downloaded_hands_on_dir: Path) -> None:
     """download creates the hands-on folder."""
     assert downloaded_hands_on_dir.is_dir()
-
-
-def test_download_blocks_when_already_downloaded(
-    runner: BinaryRunner, gitmastery_root: Path, downloaded_exercise_dir: Path
-) -> None:
-    """download refuses to overwrite an existing exercise folder."""
-    sentinel = downloaded_exercise_dir / "NOTES.md"
-    sentinel.write_text("local work")
-
-    try:
-        res = runner.run(["download", EXERCISE_NAME], cwd=gitmastery_root)
-
-        assert res.returncode != 0, (
-            f"Expected a non-zero exit code, got {res.returncode}\n"
-            f"stdout:\n{res.stdout}"
-        )
-        res.assert_stdout_contains("already have")
-        res.assert_stdout_contains("--force")
-
-        assert sentinel.is_file()
-        assert sentinel.read_text() == "local work"
-    finally:
-        sentinel.unlink()
-
-
-def test_download_hands_on_blocks_when_already_downloaded(
-    runner: BinaryRunner, gitmastery_root: Path, downloaded_hands_on_dir: Path
-) -> None:
-    """download refuses to overwrite an existing hands-on folder."""
-    sentinel = downloaded_hands_on_dir / "NOTES.md"
-    sentinel.write_text("local work")
-
-    try:
-        res = runner.run(["download", HANDS_ON_NAME], cwd=gitmastery_root)
-
-        assert res.returncode != 0, (
-            f"Expected a non-zero exit code, got {res.returncode}\n"
-            f"stdout:\n{res.stdout}"
-        )
-        res.assert_stdout_contains("--force")
-
-        assert sentinel.is_file()
-    finally:
-        sentinel.unlink()
-
-
-def test_download_force_overwrites(
-    runner: BinaryRunner, isolated_gitmastery_root: Path
-) -> None:
-    """download --force wipes the existing exercise folder and downloads it again."""
-    runner.run(
-        ["download", EXERCISE_NAME], cwd=isolated_gitmastery_root
-    ).assert_success()
-
-    exercise_dir = isolated_gitmastery_root / EXERCISE_NAME
-    sentinel = exercise_dir / "NOTES.md"
-    sentinel.write_text("local work")
-
-    runner.run(
-        ["download", EXERCISE_NAME, "--force"], cwd=isolated_gitmastery_root
-    ).assert_success()
-
-    assert not sentinel.exists()
-    assert (exercise_dir / ".gitmastery-exercise.json").is_file()
-    assert (exercise_dir / "README.md").is_file()

tests/e2e/conftest.py

@@ -53,17 +53,6 @@ def setup_gitmastery_root(
     yield from _make_gitmastery_root(runner, tmp_path_factory)
 
 
-@pytest.fixture
-def isolated_gitmastery_root(
-    runner: BinaryRunner, tmp_path_factory: pytest.TempPathFactory
-) -> Generator[Path, None, None]:
-    """
-    A throwaway Git-Mastery root for tests that overwrite a downloaded exercise,
-    so that they do not disturb the session-scoped fixtures below.
-    """
-    yield from _make_gitmastery_root(runner, tmp_path_factory)
-
-
 @pytest.fixture(scope="session")
 def downloaded_exercise_dir(runner: BinaryRunner, gitmastery_root: Path) -> Path:
     """