Improved error logging, moved log into exception branch

Author: angus-yxz

app/cli.py

@@ -53,14 +53,17 @@ def cli(ctx: click.Context, verbose: bool) -> None:
         # GitHub redirects to the tag of the latest release; without the redirect
         # there is no version to compare against
         location = response.headers.get("Location")
-        if location is not None:
+        if location is None:
+            warn(
+                "Unable to verify the latest version release: no redirect to the latest "
+                f"release tag (status {response.status_code})"
+            )
+        else:
             latest_version = Version.parse_version_string(location.rsplit("/", 1)[-1])
-    except (requests.exceptions.RequestException, ValueError):
-        latest_version = None
+    except (requests.exceptions.RequestException, ValueError) as e:
+        warn(f"Unable to verify the latest version release: {e}")
 
-    if latest_version is None:
-        warn("Unable to verify the latest version release")
-    elif current_version.is_behind(latest_version):
+    if latest_version is not None and current_version.is_behind(latest_version):
         warn(
             click.style(
                 f"Your version of Git-Mastery app {current_version} is behind the latest version {latest_version}.",

tests/e2e/test_version.py

@@ -7,20 +7,3 @@ def test_version(runner: BinaryRunner) -> None:
     res.assert_success()
     res.assert_stdout_contains("Git-Mastery app is")
     res.assert_stdout_matches(r"v\d+\.\d+\.\d+")
-
-
-def test_version_unreachable_release_check(runner: BinaryRunner) -> None:
-    """Commands still succeed when the latest release cannot be fetched."""
-    # Route the release check through a closed port so it cannot connect.
-    # NO_PROXY is cleared because an inherited value would bypass the proxy.
-    res = runner.run(
-        ["version"],
-        env={
-            "HTTP_PROXY": "http://127.0.0.1:1",
-            "HTTPS_PROXY": "http://127.0.0.1:1",
-            "NO_PROXY": "",
-        },
-    )
-    res.assert_success()
-    res.assert_stdout_contains("Unable to verify the latest version release")
-    res.assert_stdout_contains("Git-Mastery app is")