Skip to content

Commit ee6df73

Browse files
nicohrubeccodexLms24
authored
test(node): Port HTTP request suites to span streaming (#25191)
Run the HTTP request suites with the default span-streaming lifecycle. Part of #24135 --------- Co-authored-by: GPT-6 <codex@openai.com> Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
1 parent 4422cef commit ee6df73

12 files changed

Lines changed: 12 additions & 19 deletions

File tree

‎dev-packages/node-integration-tests/suites/tracing/requests/http-breadcrumbs/instrument.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
22
import { loggingTransport } from '@sentry-internal/node-integration-tests';
33

44
Sentry.init({
5-
traceLifecycle: 'static',
65
dsn: 'https://public@dsn.ingest.sentry.io/1337',
76
release: '1.0',
87
tracePropagationTargets: [/\/v0/, 'v1'],

‎dev-packages/node-integration-tests/suites/tracing/requests/http-maxed-out-sockets/instrument.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
22
import { loggingTransport } from '@sentry-internal/node-integration-tests';
33

44
Sentry.init({
5-
traceLifecycle: 'static',
65
dsn: 'https://public@dsn.ingest.sentry.io/1337',
76
release: '1.0',
87
tracesSampleRate: 1.0,

‎dev-packages/node-integration-tests/suites/tracing/requests/http-maxed-out-sockets/test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ describe('outgoing http with maxed-out agent sockets', () => {
2121
await createRunner()
2222
.withEnv({ SERVER_URL })
2323
.expect({
24-
transaction: {
25-
// we're not too concerned with the actual transaction here since this is tested elsewhere
24+
span: {
25+
// Span contents are tested elsewhere.
2626
},
2727
})
2828
.start()

‎dev-packages/node-integration-tests/suites/tracing/requests/http-no-trace-propagation/instrument.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
22
import { loggingTransport } from '@sentry-internal/node-integration-tests';
33

44
Sentry.init({
5-
traceLifecycle: 'static',
65
dsn: 'https://public@dsn.ingest.sentry.io/1337',
76
release: '1.0',
87
integrations: [Sentry.httpIntegration({ tracePropagation: false, spans: false })],

‎dev-packages/node-integration-tests/suites/tracing/requests/http-no-tracing-no-spans/instrument.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
22
import { loggingTransport } from '@sentry-internal/node-integration-tests';
33

44
Sentry.init({
5-
traceLifecycle: 'static',
65
dsn: 'https://public@dsn.ingest.sentry.io/1337',
76
release: '1.0',
87
tracePropagationTargets: [/\/v0/, 'v1'],

‎dev-packages/node-integration-tests/suites/tracing/requests/http-no-tracing/instrument.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
22
import { loggingTransport } from '@sentry-internal/node-integration-tests';
33

44
Sentry.init({
5-
traceLifecycle: 'static',
65
dsn: 'https://public@dsn.ingest.sentry.io/1337',
76
release: '1.0',
87
tracePropagationTargets: [/\/v0/, 'v1'],

‎dev-packages/node-integration-tests/suites/tracing/requests/http-sampled-no-active-span/instrument.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
22
import { loggingTransport } from '@sentry-internal/node-integration-tests';
33

44
Sentry.init({
5-
traceLifecycle: 'static',
65
dsn: 'https://public@dsn.ingest.sentry.io/1337',
76
release: '1.0',
87
tracesSampleRate: 1.0,

‎dev-packages/node-integration-tests/suites/tracing/requests/http-sampled/instrument.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
22
import { loggingTransport } from '@sentry-internal/node-integration-tests';
33

44
Sentry.init({
5-
traceLifecycle: 'static',
65
dsn: 'https://public@dsn.ingest.sentry.io/1337',
76
release: '1.0',
87
tracesSampleRate: 1.0,

‎dev-packages/node-integration-tests/suites/tracing/requests/http-sampled/test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ describe('outgoing http', () => {
3131
await createRunner()
3232
.withEnv({ SERVER_URL })
3333
.expect({
34-
transaction: {
35-
// we're not too concerned with the actual transaction here since this is tested elsewhere
34+
span: {
35+
// Span contents are tested elsewhere, we just want to know that a span envelope was sent
3636
},
3737
})
3838
.start()

‎dev-packages/node-integration-tests/suites/tracing/requests/http-unsampled/instrument.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import * as Sentry from '@sentry/node';
22
import { loggingTransport } from '@sentry-internal/node-integration-tests';
33

44
Sentry.init({
5-
traceLifecycle: 'static',
65
dsn: 'https://public@dsn.ingest.sentry.io/1337',
76
release: '1.0',
87
tracePropagationTargets: [/\/v0/, 'v1'],

0 commit comments

Comments
 (0)