Skip to content

Valid Actions don't incur reward due to typo (ChessEnvV1) #22

Description

@Japple42

line 254, there's a comment that says "valid action reward"
line 255, reward = INVALID_ACTION_REWARD

I logged stuff. every action, even if valid, incurs a negative reward (or has that negative reward added)
If I set the pawn's value to 100, if it gets captured it's worth 90, as an example

All you need to do to fix this is remove IN, so that it's set to "reward = VALID_ACTION_REWARD"

also, please fix the queen promotion. It still isn't.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions