Skip to content

bug: PR #551 broke test_huggingface — catalog/repo mismatch for requirement_check #687

Description

@planetf1

PR #551 (3e47d15) renamed requirement_checkrequirement-check in the catalog and moved the repo from rag-intrinsics-lib to granitelib-core-r1.0. This breaks test_huggingface.py (18/19 ERROR).

cc @ink-pad @mnagired @jakelorocco

Reproduced on LSF with:

uv sync --all-extras --group dev --group notebook --group docs && uv run --all-extras --group dev pytest test/backends/test_huggingface.py --durations=0 -v

Investigation

The immediate error is a ValueError — the test uses IntrinsicAdapter("requirement_check", ...) but the catalog now only has requirement-check. We attempted fixing the underscore→hyphen naming in the test, which got past the catalog lookup, but then hit a deeper problem:

The R1 repo (granitelib-core-r1.0) only has:

  • requirement-check/granite-4.0-micro/lora/

It does not have:

  • Any Granite 3.3 adapters (test uses granite-3.3-8b-instruct)
  • Any alora adapters (test fixture defaults to alora)

So even switching to Granite 4 in the test wouldn't work — there's no alora variant in the R1 repo.

The old repo (rag-intrinsics-lib) still has both lora and alora for granite-3.3-{2b,8b}-instruct under the requirement_check (underscore) name.

Additionally, stale underscore references remain in huggingface.py:385 and requirement.py:76.

Suggested fix

Add the old catalog entry back alongside the new one so both repos are accessible, or migrate the test to Granite 4 once alora adapters are published (#359).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions