Fix INI description parsing dropping descriptions containing "word="#28
Merged
Merged
Conversation
Settings.Bind() re-reads settings.ini to recover setting descriptions from the comment lines above each key. The detection regex (INIKeyValuePairPattern) was unanchored, so Regex.Match scanned the entire line and matched any embedded "word=" sequence -- a description such as "...is set to Enabled=false in the database..." was misclassified as a key/value pair, causing the real description for the following setting to be discarded.
Anchor the pattern at the start of the line ('^') so only lines that actually begin with an (optionally commented) key=value are treated as settings. This fixes both the GeneratedRegex (NET) and Regex (non-NET) paths since they share the constant.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings.Bind() re-reads settings.ini to recover setting descriptions from the comment lines above each key. The detection regex (INIKeyValuePairPattern) was unanchored, so Regex.Match scanned the entire line and matched any embedded "word=" sequence -- a description such as "...is set to Enabled=false in the database..." was misclassified as a key/value pair, causing the real description for the following setting to be discarded.
Anchor the pattern at the start of the line ('^') so only lines that actually begin with an (optionally commented) key=value are treated as settings. This fixes both the GeneratedRegex (NET) and Regex (non-NET) paths since they share the constant.