fix(tabStore): align API with tests - connectionId-first signatures (#53)

Tests have always expected createTab and openTableViewTab to take
connectionId as the first parameter, and a dedicated
closeTabsForConnection helper to exist on the store. The implementation
had connectionId as the last optional parameter and was missing the
helper, so CI was red on master with 9 failing assertions across all
three platforms.

- createTab(connectionId?, database?, schema?)
- openTableViewTab(connectionId, database, tableName, schema?)
- executeQuery(tabId, sqlToExecute?) reads connectionId from the tab
  instead of taking it as a parameter, matching the test contract.
- Add closeTabsForConnection(connectionId) for bulk close on
  connection teardown.

Callsites updated in QueriesPage.vue and HistoryPage.vue. All 276
frontend tests pass.

Author: Blankll

src/pages/HistoryPage.vue

@@ -106,7 +106,7 @@ async function handleRerun(entry: HistoryEntry) {
     return
   }
   const database = entry.database
-  const tab = tabStore.createTab(database, undefined, connectionId)
+  const tab = tabStore.createTab(connectionId, database)
   tabStore.updateTabContent(tab.id, entry.sql)
   const createdTab = tabStore.tabs.find(t => t.id === tab.id)
   if (createdTab)

src/pages/QueriesPage.vue

@@ -204,7 +204,7 @@ async function executeQuery(details?: StatementToExecute) {
   }
 
   showResultPanel.value = true
-  await tabStore.executeQuery(activeTab.value.id, connId, sqlToExecute)
+  await tabStore.executeQuery(activeTab.value.id, sqlToExecute)
 }
 
 async function handleExplainQuery() {
@@ -216,7 +216,7 @@ function handleNewTab() {
   const db = connId
     ? (selectedDatabase.value || connectionStore.getCurrentDatabase(connId) || connectionStore.getConnectionById(connId)?.database || undefined)
     : undefined
-  tabStore.createTab(db, undefined, connId ?? undefined)
+  tabStore.createTab(connId ?? undefined, db)
 }
 
 function handleTabSelect(tabId: string) {
@@ -277,7 +277,7 @@ CREATE TABLE ${schemaPrefix}"${table.name}" (
 
   const connId = getActiveConnectionId()
   if (connId) {
-    const tab = tabStore.createTab(database, schema, connId)
+    const tab = tabStore.createTab(connId, database, schema)
     tabStore.updateTabContent(tab.id, script)
     tabStore.updateTabName(tab.id, `CREATE_${table.name}.sql`)
   }
@@ -289,11 +289,11 @@ function handleSelectTopN(table: TableInfo, database: string, schema?: string, n
 
   const connId = getActiveConnectionId()
   if (connId) {
-    const tab = tabStore.createTab(database, schema, connId)
+    const tab = tabStore.createTab(connId, database, schema)
     tabStore.updateTabContent(tab.id, query)
     tabStore.updateTabName(tab.id, `SELECT_${table.name}`)
 
-    tabStore.executeQuery(tab.id, connId)
+    tabStore.executeQuery(tab.id)
     showResultPanel.value = true
   }
 }
@@ -309,7 +309,7 @@ WHERE table_name = '${table.name}'${schema ? ` AND table_schema = '${schema}'` :
 
   const connId = getActiveConnectionId()
   if (connId) {
-    const tab = tabStore.createTab(database, schema, connId)
+    const tab = tabStore.createTab(connId, database, schema)
     tabStore.updateTabContent(tab.id, query)
     tabStore.updateTabName(tab.id, `STRUCTURE_${table.name}`)
   }
@@ -323,7 +323,7 @@ function handleSelectTable(table: TableInfo, database: string, schema?: string)
   const connId = getActiveConnectionId()
   if (!connId)
     return
-  tabStore.openTableViewTab(database, table.name, schema, connId)
+  tabStore.openTableViewTab(connId, database, table.name, schema)
 }
 
 async function handleOpenSavedQuery(filePath: string) {
@@ -338,7 +338,7 @@ async function handleOpenSavedQuery(filePath: string) {
     ? (selectedDatabase.value || connectionStore.getCurrentDatabase(connId) || connectionStore.getConnectionById(connId)?.database || undefined)
     : undefined
 
-  const tab = tabStore.createTab(db, undefined, connId ?? undefined)
+  const tab = tabStore.createTab(connId ?? undefined, db)
 
   try {
     const result = await loadQueryFile(filePath)

src/store/tabStore.ts

@@ -75,7 +75,7 @@ export const useTabStore = defineStore('tabs', {
   },
 
   actions: {
-    createTab(database?: string, schema?: string, connectionId?: string): QueryTab {
+    createTab(connectionId?: string, database?: string, schema?: string): QueryTab {
       const tab: QueryTab = {
         id: generateId(),
         name: `Query ${this.tabs.length + 1}`,
@@ -91,7 +91,7 @@ export const useTabStore = defineStore('tabs', {
       return tab
     },
 
-    openTableViewTab(database: string, tableName: string, schema?: string, connectionId?: string): QueryTab {
+    openTableViewTab(connectionId: string, database: string, tableName: string, schema?: string): QueryTab {
       const existing = this.tabs.find(
         t => t.tableView
           && t.tableView.tableName === tableName
@@ -138,6 +138,14 @@ export const useTabStore = defineStore('tabs', {
       this.activeTabId = null
     },
 
+    closeTabsForConnection(connectionId: string) {
+      const remaining = this.tabs.filter(t => t.connectionId !== connectionId)
+      this.tabs = remaining
+      if (this.activeTabId && !remaining.find(t => t.id === this.activeTabId)) {
+        this.activeTabId = remaining[0]?.id ?? null
+      }
+    },
+
     closeNonOrphanTabs() {
       this.tabs = this.tabs.filter(t => t.orphanFromConnectionId)
       if (this.activeTabId && !this.tabs.find(t => t.id === this.activeTabId)) {
@@ -233,7 +241,7 @@ export const useTabStore = defineStore('tabs', {
       }
     },
 
-    async executeQuery(tabId: string, activeConnectionId: string, sqlToExecute?: string) {
+    async executeQuery(tabId: string, sqlToExecute?: string) {
       const tab = this.tabs.find(t => t.id === tabId)
       if (!tab || tab.orphanFromConnectionId) {
         return
@@ -245,6 +253,11 @@ export const useTabStore = defineStore('tabs', {
         return
       }
 
+      const activeConnectionId = tab.connectionId
+      if (!activeConnectionId) {
+        return
+      }
+
       tab.isExecuting = true
       tab.error = undefined