-
Notifications
You must be signed in to change notification settings - Fork 1
Code review #9
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Description
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
PolynomialSurface::fitcan be made to take in astd::spaninstead of a vector reference.PolynomialSurface::getCoefficientscan have it's implementation put in the header for better inlining.doubleif you like, things like Eigen::MatrixXd can then be replaced withEigen::Matrix<T, Dynamic, Dynamic>.numTermscan be madeconsteval.const, same as some variables in them likecoeffsinfit.PolynomialSurface::evaluateyou can replace the for loop and result with this:can be replaced with: