// Bug: If msg.value is sufficiently large, then contributions[msg.sender] will overflow
// and the user will have managed to contribute WAY more than MAX_CONTRIBUTION.
Not sure this is accurate - i.e. you'd need more ETH than exists in circulation today in order to overflow contributions[msg.sender].
I agree that in practice it is better to check overflows with any arithmetic in Solidity, but you could argue this is an exception ;-).
Not sure this is accurate - i.e. you'd need more ETH than exists in circulation today in order to overflow
contributions[msg.sender].I agree that in practice it is better to check overflows with any arithmetic in Solidity, but you could argue this is an exception ;-).