Skip to content

Support node.machine.sapcloud.io/effective-creation-timeout on MachineDeployment #1098

@elankath

Description

@elankath

How to categorize this issue?

/area auto-scaling
/area control-plane
/kind enhancement
/priority 2

What would you like to be added:

MachineDeployment can be annotated with node.machine.sapcloud.io/effective-creation-timeout
If this is done, then this annotation is copied to child MachineSet(s). The MachineSet controller should use this annotation value to set the Machine.Spec.MachineConfiguration.MachineCreationTimeout when creating a new Machine object.

Doing the above ensures that the reconcileMachineHealth of the MachineController will change the Machine phase to Failed once the effecive creation timeout of a Pending Machine has expired.

Why is this needed:

We want the gardener dependency watchdog to be able to dynamically adapt the machine creation timeouts to the real values taken for a machine to be provisioned and join the cluster. This is being done in gardener/dependency-watchdog#201. However, we need support for such a facility in the MCM.

Metadata

Metadata

Assignees

Labels

kind/enhancementEnhancement, improvement, extensionpriority/2Priority (lower number equals higher priority)

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions