Gameplay
New description
"); + assert.equal(target.querySelector("img"), null); + assert.equal(target.textContent, "New description"); + } finally { delete globalThis.DOMParser; } +}); + +test("Steam GIFs suspend decoding outside the viewport and resume near it", async () => { + const { load } = createModuleLoader({}); + const { renderSteamDescription } = await import(await load("src/lib/features/library/steam-description.ts")); + globalThis.DOMParser = dom.window.DOMParser; + const observers = []; + globalThis.IntersectionObserver = class { + constructor(callback, options) { this.callback = callback; this.options = options; this.targets = new Set(); observers.push(this); } + observe(target) { this.targets.add(target); } + disconnect() { this.targets.clear(); this.disconnected = true; } + intersect(target, isIntersecting) { this.callback([{ target, isIntersecting }]); } + }; + const target = document.createElement("div"); + try { + const renderer = renderSteamDescription(target, '
');
+ const [gif, image] = target.querySelectorAll("img");
+ assert.equal(observers.length, 1);
+ assert.equal(observers[0].options.rootMargin, "300px 0px");
+ assert.deepEqual([...observers[0].targets], [gif]);
+ Object.defineProperties(gif, { complete: { configurable: true, value: true }, naturalWidth: { configurable: true, value: 640 }, naturalHeight: { configurable: true, value: 360 } });
+ observers[0].intersect(gif, false);
+ gif.dispatchEvent(new dom.window.Event("load"));
+ assert.equal(gif.hasAttribute("src"), false, "offscreen GIFs release their animated source after loading");
+ assert.equal(gif.getAttribute("width"), "640");
+ assert.equal(gif.getAttribute("height"), "360");
+ observers[0].intersect(gif, true);
+ assert.equal(gif.src, "https://shared.fastly.steamstatic.com/demo.gif");
+ assert.equal(image.src, "https://shared.fastly.steamstatic.com/demo.png", "static images stay loaded");
+ renderer.destroy();
+ assert.equal(observers[0].disconnected, true);
+ } finally { delete globalThis.DOMParser; delete globalThis.IntersectionObserver; }
+});
+
+test("Steam descriptions reject untrusted image sources", async () => {
+ const { load } = createModuleLoader({});
+ const { renderSteamDescription } = await import(await load("src/lib/features/library/steam-description.ts"));
+ globalThis.DOMParser = dom.window.DOMParser;
+ const target = document.createElement("div");
+ try {
+ for (const src of ["http://cdn.steamstatic.com/a.gif", "https://steamstatic.com.evil.test/a.png", "https://evilsteamstatic.com/a.png", "https://user@steamstatic.com/a.png", "https://steamstatic.com:444/a.png", "https://evil.test/a.png", "file:///tmp/a.png", "data:image/svg+xml,test", "javascript:alert(1)", "//cdn.steamstatic.com/a.png", "/image.png", ""]) {
+ renderSteamDescription(target, `Safe text
Safe text
'); + assert.equal(target.querySelector("video,source"), null); + assert.equal(target.textContent, "Safe text"); + renderSteamDescription(target, ``); + assert.equal(target.querySelector("video").src, safe); + } finally { delete globalThis.DOMParser; } +}); + +test("Steam video animations respect reduced motion", async () => { + const { load } = createModuleLoader({}); + const { renderSteamDescription } = await import(await load("src/lib/features/library/steam-description.ts")); + globalThis.DOMParser = dom.window.DOMParser; + const previousMatchMedia = globalThis.matchMedia; + globalThis.matchMedia = () => ({ matches: true }); + try { + const target = document.createElement("div"); + renderSteamDescription(target, ''); + const video = target.querySelector("video"); + assert.ok(video); + assert.equal(video.autoplay, false); + assert.equal(video.controls, false); + } finally { globalThis.matchMedia = previousMatchMedia; delete globalThis.DOMParser; } +}); + test("library removal stops at the first failed game and keeps the library", async () => { const calls = []; globalThis.removalFixture = { calls, fail: "b", libraries: [] }; diff --git a/scripts/test_module_loader.mjs b/scripts/test_module_loader.mjs index df927e7..3de3d60 100644 --- a/scripts/test_module_loader.mjs +++ b/scripts/test_module_loader.mjs @@ -23,7 +23,7 @@ export function createModuleLoader(mocks) { const modules = new Map(); async function resolveImports(code, path) { - for (const match of [...code.matchAll(/(?:from\s*|import\s*)["']([^"']+)["']/g)]) { + for (const match of [...code.matchAll(/(?:from\s*|import\s*|import\(\s*)["']([^"']+)["']/g)]) { const specifier = match[1]; const resolved = specifier.startsWith(".") ? new URL(specifier, `file:///${path}`).pathname.slice(1) : null; const url = resolved === null diff --git a/scripts/test_steam_trailer.mjs b/scripts/test_steam_trailer.mjs new file mode 100644 index 0000000..88ead54 --- /dev/null +++ b/scripts/test_steam_trailer.mjs @@ -0,0 +1,41 @@ +import assert from "node:assert/strict"; +import { test } from "node:test"; +import { JSDOM } from "jsdom"; +import { createModuleLoader, dataModule } from "./test_module_loader.mjs"; +const dom=new JSDOM(''); +const {load}=createModuleLoader({"src/lib/i18n":dataModule("export const t=value=>value;"),"hls.js":dataModule(`export default class Hls { + static Events={ERROR:"error"};static ErrorTypes={NETWORK_ERROR:"network",MEDIA_ERROR:"media"};static isSupported(){return true;} + constructor(){globalThis.trailerFixture.hls=this;this.restarts=[];this.recoveries=0;this.destroyed=0;} + on(_event,callback){this.callback=callback;}loadSource(){}attachMedia(){}startLoad(time){this.restarts.push(time);}recoverMediaError(){this.recoveries++;}destroy(){this.destroyed++;} +}`)}); +const {loadSteamTrailer}=await import(await load("src/lib/services/steam-trailer.ts")); +const movie={id:1,name:"Test",thumbnail:null,hls:"https://video.akamai.steamstatic.com/movie.m3u8",mp4:null,webm:null}; +const settle=()=>new Promise(resolve=>setImmediate(resolve)); +function video(){const v=dom.window.document.createElement("video");v.pause=()=>{};v.load=()=>{};return v;} + +test("stream resets retry twice at the current position, then fail once",async()=>{ + globalThis.trailerFixture={};const v=video();v.currentTime=12.5;const errors=[]; + const destroy=loadSteamTrailer(v,movie,message=>errors.push(message));await settle(); + try { + const hls=globalThis.trailerFixture.hls; + v.dispatchEvent(new dom.window.Event("error"));assert.equal(errors.length,0,"HLS owns recovery while attached"); + for(let i=0;i<2;i++)hls.callback("error",{fatal:true,type:"network",details:"Connection reset by peer"}); + assert.deepEqual(hls.restarts,[12.5,12.5]);assert.equal(errors.length,0); + hls.callback("error",{fatal:true,type:"network",details:"Connection reset by peer"}); + hls.callback("error",{fatal:true,type:"network",details:"Connection reset by peer"}); + assert.equal(errors.length,1);assert.equal(hls.destroyed,1); + } finally {destroy();delete globalThis.trailerFixture;} +}); +test("decoder recovery shares the finite recovery budget",async()=>{ + globalThis.trailerFixture={};const errors=[];const destroy=loadSteamTrailer(video(),movie,message=>errors.push(message));await settle(); + try { + const hls=globalThis.trailerFixture.hls; + hls.callback("error",{fatal:true,type:"media",details:"decoder"});assert.equal(hls.recoveries,1); + hls.callback("error",{fatal:true,type:"network",details:"reset"});assert.equal(hls.restarts.length,1); + hls.callback("error",{fatal:true,type:"media",details:"decoder"});assert.equal(errors.length,1); + } finally {destroy();delete globalThis.trailerFixture;} +}); +test("switching trailers cancels pending setup and ignores late failures",async()=>{ + globalThis.trailerFixture={};const errors=[];const v=video();const destroy=loadSteamTrailer(v,movie,message=>errors.push(message));destroy();await settle(); + assert.equal(globalThis.trailerFixture.hls,undefined);v.dispatchEvent(new dom.window.Event("error"));assert.deepEqual(errors,[]);delete globalThis.trailerFixture; +}); diff --git a/scripts/test_steam_video_loop.mjs b/scripts/test_steam_video_loop.mjs new file mode 100644 index 0000000..3b68f6c --- /dev/null +++ b/scripts/test_steam_video_loop.mjs @@ -0,0 +1,86 @@ +import assert from "node:assert/strict"; +import { test } from "node:test"; +import { JSDOM } from "jsdom"; +import { createModuleLoader } from "./test_module_loader.mjs"; + +const dom = new JSDOM(""); +Object.defineProperty(globalThis, "document", { configurable: true, value: dom.window.document }); +const frames = new Map(); +let frameId = 0; +globalThis.requestAnimationFrame = callback => { frames.set(++frameId, callback); return frameId; }; +globalThis.cancelAnimationFrame = id => frames.delete(id); +dom.window.HTMLMediaElement.prototype.pause = function () {}; +const originalContext = dom.window.HTMLCanvasElement.prototype.getContext; +dom.window.HTMLCanvasElement.prototype.getContext = () => ({ drawImage() {} }); +const { load } = createModuleLoader({}); +const { createSteamVideoSurface } = await import(await load("src/lib/features/library/steam-description-video.ts")); + +function fixture(frameCallbacks = true) { + const video = document.createElement("video"); + const callbacks = new Map(); + let id = 0; + if (frameCallbacks) { + video.requestVideoFrameCallback = callback => { callbacks.set(++id, callback); return id; }; + video.cancelVideoFrameCallback = value => callbacks.delete(value); + } + Object.defineProperties(video, { videoWidth: { value: 600 }, videoHeight: { value: 170 }, readyState: { value: 4, configurable: true }, seeking: { value: false, configurable: true }, paused: { value: false, configurable: true } }); + const surface = createSteamVideoSurface(video); + document.body.append(surface.element); + const canvas = surface.element.querySelector("canvas"); + return { video, surface, canvas, callbacks, frame() { + const queue = frameCallbacks ? callbacks : frames; + const pending = [...queue.values()]; queue.clear(); + for (const callback of pending) callback(0, {}); + }, cleanup() { surface.destroy(); surface.element.remove(); frames.clear(); } }; +} + +test("a video loop holds the last frame while the native player seeks", () => { + const f = fixture(); + try { + assert.equal(f.canvas.hidden, true, "the native poster remains visible before a decoded frame"); + f.frame(); + assert.equal(f.canvas.hidden, false); + assert.equal(f.canvas.width, 600); + assert.equal(f.canvas.height, 170); + Object.defineProperty(f.video, "seeking", { value: true }); + Object.defineProperty(f.video, "readyState", { value: 1 }); + f.frame(); + assert.equal(f.canvas.hidden, false, "the decoded surface must remain visible over the native player's empty loop frame"); + assert.equal(f.canvas.width, 600, "seeking must not clear the retained canvas"); + Object.defineProperty(f.video, "seeking", { value: false }); + Object.defineProperty(f.video, "readyState", { value: 4 }); + f.frame(); + assert.equal(f.canvas.hidden, false); + f.surface.destroy(); + assert.equal(f.callbacks.size, 0, "unmounting cancels pending frame callbacks"); + } finally { f.cleanup(); } +}); + +test("older players paint while playing and stop their fallback clock on pause", () => { + const f = fixture(false); + try { + f.video.dispatchEvent(new dom.window.Event("playing")); + f.frame(); + assert.equal(f.canvas.hidden, false); + f.video.dispatchEvent(new dom.window.Event("pause")); + assert.equal(frames.size, 0); + f.video.dispatchEvent(new dom.window.Event("playing")); + assert.equal(frames.size, 1); + f.surface.destroy(); + assert.equal(frames.size, 0); + f.video.dispatchEvent(new dom.window.Event("playing")); + assert.equal(frames.size, 0, "destroy removes playback listeners"); + } finally { f.cleanup(); } +}); + +test("players without a canvas context retain native playback", () => { + dom.window.HTMLCanvasElement.prototype.getContext = () => null; + try { + const f = fixture(); + try { + assert.equal(f.surface.element.contains(f.video), true); + assert.equal(f.canvas, null); + assert.equal(f.callbacks.size, 0); + } finally { f.cleanup(); } + } finally { dom.window.HTMLCanvasElement.prototype.getContext = originalContext; } +}); diff --git a/src-tauri/src/steam_details.rs b/src-tauri/src/steam_details.rs index 4faf20b..f7622c5 100644 --- a/src-tauri/src/steam_details.rs +++ b/src-tauri/src/steam_details.rs @@ -17,6 +17,7 @@ const CACHE_LIMIT: u32 = 128; const MAX_DETAILS_BYTES: usize = 512 * 1024; const STALE_SECONDS: i64 = 3 * 24 * 60 * 60; const MAX_SCREENSHOTS: usize = 8; +const MAX_MOVIES: usize = 8; #[derive(Debug, Deserialize, Serialize, PartialEq, Eq)] #[serde(rename_all = "camelCase")] @@ -65,6 +66,18 @@ pub struct Assets { pub capsule: Option{t("Nessun dato Steam disponibile per questo titolo.", $language)}
{:else} - {#if screenshots.length > 0} -{error}
+ +