Skip to content

Commit 2fe5f85

Browse files
rvanooaryan9600
andauthored
Apply suggestions from code review
Co-authored-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com> Signed-off-by: Rob van Oostrum <rvanoo@gmail.com>
1 parent 00892a3 commit 2fe5f85

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

pkg/controller/scheduler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,8 @@ func (c *Controller) advanceCanary(name string, namespace string) {
347347
if err != nil {
348348
c.recordEventWarningf(cd, "%v", err)
349349
if !retriable {
350-
c.recordEventWarningf(cd, "Rolling back %s.%s canary not ready", cd.Name, cd.Namespace)
351-
c.alert(cd, "Rolling back canary not ready", false, flaggerv1.SeverityError)
350+
c.recordEventWarningf(cd, "Rolling back since %s.%s canary is not ready", cd.Name, cd.Namespace)
351+
c.alert(cd, "Rolling back since canary is not ready", false, flaggerv1.SeverityError)
352352
c.rollback(cd, canaryController, meshRouter, scalerReconciler)
353353
}
354354
return

0 commit comments

Comments
 (0)