kola: Make RunTests return on runtime failures

So that the deferred flight.Destroy() is called. The only caller terminates the
application on failure anyway.

Author: Jeremi Piotrowski

cmd/kola/kola.go

@@ -134,13 +134,11 @@ func runRun(cmd *cobra.Command, args []string) {
 
 	// needs to be after RunTests() because harness empties the directory
 	if err := writeProps(); err != nil {
-		fmt.Fprintf(os.Stderr, "%v\n", err)
-		os.Exit(1)
+		plog.Fatal(err)
 	}
 
 	if runErr != nil {
-		fmt.Fprintf(os.Stderr, "%v\n", runErr)
-		os.Exit(1)
+		plog.Fatal(runErr)
 	}
 }
 

kola/harness.go

@@ -432,7 +432,7 @@ func RunTests(patterns []string, channel, offering, pltfrm, outputDir string, ss
 
 		version, err := getClusterSemver(flight, outputDir)
 		if err != nil {
-			plog.Fatal(err)
+			return fmt.Errorf("getClusterSemver: %w	", err)
 		}
 
 		// If the version is > 3033, we can safely use user-data instead of custom-data for
@@ -453,7 +453,7 @@ func RunTests(patterns []string, channel, offering, pltfrm, outputDir string, ss
 		// one more filter pass now that we know real version
 		tests, err = FilterTests(tests, patterns, channel, offering, pltfrm, *version)
 		if err != nil {
-			plog.Fatal(err)
+			return fmt.Errorf("FilterTests: %v", err)
 		}
 	}