12/26(木)19:30から『FBC忘年会2024』を開催します！ご参加お待ちしております😃', metadata[:html] + assert_includes metadata[:html], '
12/26(木)19:30から『FBC忘年会2024』を開催します！ご参加お待ちしております😃' + end + end + + test '#metadata does not garble text for specific domains' do + VCR.use_cassette 'link_card/metadata/not_garble_text' do + params = { url: 'https://www.youtube.com/watch?v=8LudKmk7yPM', tweet: nil } + card = LinkCard::Card.new(params[:url], params[:tweet]) + metadata = card.metadata + + assert_equal 'YouTube', metadata[:site_name] + assert_equal 'https://www.youtube.com', metadata[:site_url] + assert_equal '角谷トーク2023 本編', metadata[:title] + assert_includes metadata[:description], 'フィヨルドブートキャンプの顧問、角谷信太郎氏によるプログラミング学習者に向けたトークイベント' + end + end + + test '#metadata does not cache failed fetch' do + store = ActiveSupport::Cache::MemoryStore.new + params = { url: 'https://www.youtube.com/watch?v=8LudKmk7yPM', tweet: nil } + card = LinkCard::Card.new(params[:url], params[:tweet]) + metadata = { title: '角谷トーク2023 本編' } + requests = [nil, metadata] + + Rails.stub(:cache, store) do + card.stub(:request, -> { requests.shift }) do + assert_nil card.metadata + assert_equal metadata, card.metadata + end end end end diff --git a/test/models/metadata_test.rb b/test/models/metadata_test.rb new file mode 100644 index 00000000000..7b5dd84305f --- /dev/null +++ b/test/models/metadata_test.rb @@ -0,0 +1,43 @@ +# frozen_string_literal: true + +require 'test_helper' + +class MetadataTest < ActiveSupport::TestCase + test '#fetch falls back to YouTube oEmbed when YouTube page fetch fails' do + url = 'https://www.youtube.com/watch?v=8LudKmk7yPM' + stub_request(:get, url).to_return(status: 403, body: 'Forbidden') + stub_request(:get, 'https://www.youtube.com/oembed') + .with(query: { url:, format: 'json' }) + .to_return( + status: 200, + body: { + title: '角谷トーク2023 本編', + thumbnail_url: 'https://i.ytimg.com/vi/8LudKmk7yPM/hqdefault.jpg' + }.to_json + ) + + metadata = Metadata.new(url).fetch + + assert_equal '角谷トーク2023 本編', metadata[:title] + assert_equal 'https://i.ytimg.com/vi/8LudKmk7yPM/hqdefault.jpg', metadata[:images] + assert_equal 'YouTube', metadata[:site_name] + assert_equal 'https://www.youtube.com', metadata[:site_url] + end + + test '#fetch returns nil when page fetch raises network error' do + url = 'https://example.com/' + stub_request(:get, url).to_raise(SocketError) + + assert_nil Metadata.new(url).fetch + end + + test '#fetch returns nil when YouTube oEmbed raises network error' do + url = 'https://www.youtube.com/watch?v=8LudKmk7yPM' + stub_request(:get, url).to_return(status: 403, body: 'Forbidden') + stub_request(:get, 'https://www.youtube.com/oembed') + .with(query: { url:, format: 'json' }) + .to_raise(Net::OpenTimeout) + + assert_nil Metadata.new(url).fetch + end +end diff --git a/test/models/pair_work_test.rb b/test/models/pair_work_test.rb index 755836068a7..582b35af3d9 100644 --- a/test/models/pair_work_test.rb +++ b/test/models/pair_work_test.rb @@ -167,4 +167,22 @@ class PairWorkTest < ActiveSupport::TestCase assert_not pair_work.reserve(invalid_params_reserved_at) assert_includes pair_work.errors.full_messages, '希望した日時は提案されたスケジュールに含まれていません' end + + test '#unmatch' do + travel_to Time.zone.local(2025, 1, 2, 0, 59, 59) do + pair_work = pair_works(:pair_work2) + pair_work.unmatch + assert_nil pair_work.reserved_at + assert_nil pair_work.buddy + end + end + + test '#unmatch fails when reverved_at before or at current time' do + travel_to Time.zone.local(2025, 1, 2, 1, 0, 0) do + pair_work = pair_works(:pair_work2) + pair_work.unmatch + assert_not_nil pair_work.reserved_at + assert_not_nil pair_work.buddy + end + end end diff --git a/test/models/pjord_test.rb b/test/models/pjord_test.rb index c1c30b3baa3..f1a631cb606 100644 --- a/test/models/pjord_test.rb +++ b/test/models/pjord_test.rb @@ -15,6 +15,7 @@ class PjordTest < ActiveSupport::TestCase mock_chat.expect(:with_instructions, mock_chat, [String]) mock_chat.expect(:with_tool, mock_chat, [BootcampSearchTool]) mock_chat.expect(:with_tool, mock_chat, [UserInfoTool]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) mock_chat.expect(:ask, mock_content, [String]) RubyLLM.stub(:chat, mock_chat) do @@ -31,6 +32,7 @@ class PjordTest < ActiveSupport::TestCase mock_chat.expect(:with_instructions, mock_chat, [String]) mock_chat.expect(:with_tool, mock_chat, [BootcampSearchTool]) mock_chat.expect(:with_tool, mock_chat, [UserInfoTool]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) mock_chat.expect(:ask, mock_content, [String]) RubyLLM.stub(:chat, mock_chat) do @@ -39,6 +41,79 @@ class PjordTest < ActiveSupport::TestCase end end + test '.respond removes internal preamble from response' do + mock_content = Minitest::Mock.new + mock_content.expect(:content, "\n検索結果を踏まえて、日報へのコメントを作成します。\n\n少しずつ進められていますね。") + + mock_chat = Minitest::Mock.new + mock_chat.expect(:with_instructions, mock_chat, [String]) + mock_chat.expect(:with_tool, mock_chat, [BootcampSearchTool]) + mock_chat.expect(:with_tool, mock_chat, [UserInfoTool]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) + mock_chat.expect(:ask, mock_content, [String]) + + RubyLLM.stub(:chat, mock_chat) do + response = Pjord.respond(message: 'test') + assert_equal '少しずつ進められていますね。', response + end + end + + test '.respond extracts body from structured response' do + mock_content = Minitest::Mock.new + mock_content.expect(:content, '{"body":"公開する本文です。"}') + + mock_chat = Minitest::Mock.new + mock_chat.expect(:with_instructions, mock_chat, [String]) + mock_chat.expect(:with_tool, mock_chat, [BootcampSearchTool]) + mock_chat.expect(:with_tool, mock_chat, [UserInfoTool]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) + mock_chat.expect(:ask, mock_content, [String]) + + RubyLLM.stub(:chat, mock_chat) do + response = Pjord.respond(message: 'test') + assert_equal '公開する本文です。', response + end + end + + test '.respond returns original response when JSON is not an object' do + mock_content = Minitest::Mock.new + mock_content.expect(:content, '["公開する本文です。"]') + + mock_chat = Minitest::Mock.new + mock_chat.expect(:with_instructions, mock_chat, [String]) + mock_chat.expect(:with_tool, mock_chat, [BootcampSearchTool]) + mock_chat.expect(:with_tool, mock_chat, [UserInfoTool]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) + mock_chat.expect(:ask, mock_content, [String]) + + RubyLLM.stub(:chat, mock_chat) do + response = Pjord.respond(message: 'test') + assert_equal '["公開する本文です。"]', response + end + end + + test '.respond returns nil when structured response cannot be converted to a hash' do + content = Struct.new(:body) do + def to_h + ['公開する本文です。'] + end + end.new + + mock_content = Minitest::Mock.new + mock_content.expect(:content, content) + + mock_chat = Minitest::Mock.new + mock_chat.expect(:with_instructions, mock_chat, [String]) + mock_chat.expect(:with_tool, mock_chat, [BootcampSearchTool]) + mock_chat.expect(:with_tool, mock_chat, [UserInfoTool]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) + mock_chat.expect(:ask, mock_content, [String]) + + RubyLLM.stub(:chat, mock_chat) do + assert_nil Pjord.respond(message: 'test') + end + end + test '.respond raises on API error for job retry' do RubyLLM.stub(:chat, ->(*) { raise StandardError, 'API error' }) do assert_raises(StandardError) do diff --git a/test/models/practice_test.rb b/test/models/practice_test.rb index 8f2514a039b..a1a63c97d47 100644 --- a/test/models/practice_test.rb +++ b/test/models/practice_test.rb @@ -87,4 +87,65 @@ class PracticeTest < ActiveSupport::TestCase practice.update!(source_id: 99_999) end end + + test '#grant_course? returns true when practice has source' do + assert Practice.new(source_id: 1).grant_course? + assert_not Practice.new(source_id: nil).grant_course? + end + + test '#reports_count sums reports of self and source when include_source is true' do + source_practice = practices(:practice67) + practice = practices(:practice68) + initial_count = practice.reports_count(include_source: true) + + Report.create!( + user: users(:komagata), + title: '日報が存在しないRailsコースのコピー元プラクティスの日報', + description: '日報が存在しないRailsコースのコピー元プラクティスの日報です。', + practices: [source_practice], + reported_on: Time.zone.today + ) + Report.create!( + user: users(:komagata), + title: '日報が存在しない給付金コースのプラクティスの日報', + description: '日報が存在しない給付金コースのプラクティスの日報です。', + practices: [practice], + reported_on: Time.zone.today - 1 + ) + + assert_equal initial_count + 2, practice.reports_count(include_source: true) + end + + test '#reports_count counts only self reports when include_source is false' do + practice = practices(:practice67) + initial_count = practice.reports_count(include_source: false) + + Report.create!( + user: users(:komagata), + title: '日報が存在しないRailsコースのコピー元プラクティスの日報', + description: '日報が存在しないRailsコースのコピー元プラクティスの日報です。', + practices: [practice], + reported_on: Time.zone.today + ) + + assert_equal initial_count + 1, practice.reports_count(include_source: false) + end + + test '#reports_count does not double count reports when associated with both source and practice' do + source_practice = practices(:practice67) + practice = practices(:practice68) + initial_count = practice.reports_count(include_source: false) + initial_count_including_source = practice.reports_count(include_source: true) + + Report.create!( + user: users(:komagata), + title: '日報が存在しないRailsコースのコピー元プラクティス、日報が存在しない給付金コースのプラクティスの両方に関連する日報', + description: '日報が存在しないRailsコースのプラクティス、日報が存在しない給付金コースのプラクティスの両方に関連する日報です。', + practices: [source_practice, practice], + reported_on: Time.zone.today + ) + + assert_equal initial_count + 1, practice.reports_count(include_source: false) + assert_equal initial_count_including_source + 1, practice.reports_count(include_source: true) + end end diff --git a/test/models/product_ai_reviewer/github_code_fetcher_test.rb b/test/models/product_ai_reviewer/github_code_fetcher_test.rb new file mode 100644 index 00000000000..4f35495cc51 --- /dev/null +++ b/test/models/product_ai_reviewer/github_code_fetcher_test.rb @@ -0,0 +1,70 @@ +# frozen_string_literal: true + +require 'test_helper' +require 'supports/mock_env_helper' + +class ProductAiReviewer::GithubCodeFetcherTest < ActiveSupport::TestCase + include MockEnvHelper + + setup do + Rails.cache.clear + end + + test '.fetch converts GitHub blob links to raw URLs and returns code entries' do + github_url = 'https://github.com/fjordllc/bootcamp/blob/main/app/models/product.rb' + raw_url = 'https://raw.githubusercontent.com/fjordllc/bootcamp/main/app/models/product.rb' + + assert_equal raw_url, ProductAiReviewer::GithubCodeFetcher.send(:raw_github_url, github_url) + end + + test '.fetch ignores non-code GitHub links' do + assert_empty ProductAiReviewer::GithubCodeFetcher.fetch('https://github.com/fjordllc/bootcamp/issues/1') + end + + test '.fetch normalizes fetched body encoding to UTF-8' do + binary_body = 'class Product < ApplicationRecord; end'.b + normalized_body = ProductAiReviewer::GithubCodeFetcher.send(:normalize_body, binary_body) + + assert_equal Encoding::UTF_8, normalized_body.encoding + assert_equal 'class Product < ApplicationRecord; end', normalized_body + end + + test '.fetch scrubs invalid bytes from fetched body' do + invalid_body = "valid\xFFinvalid".b + normalized_body = ProductAiReviewer::GithubCodeFetcher.send(:normalize_body, invalid_body) + + assert_equal Encoding::UTF_8, normalized_body.encoding + assert normalized_body.valid_encoding? + assert_equal 'valid�invalid', normalized_body + end + + test '.fetch sends Pjord GitHub token when it is configured' do + mock_env('PJORD_GITHUB_TOKEN' => 'token-for-pjord') do + headers = ProductAiReviewer::GithubCodeFetcher.send(:github_request_headers) + + assert_equal 'Bearer token-for-pjord', headers['Authorization'] + end + end + + test '.fetch uses explicit timeouts for GitHub requests' do + github_url = 'https://raw.githubusercontent.com/fjordllc/bootcamp/main/app/models/product.rb' + captured_options = nil + + Net::HTTP.stub(:start, lambda { |_host, _port, *args, **kwargs, &block| + captured_options = kwargs.presence || args.first || {} + response = Net::HTTPSuccess.new('1.1', '200', 'OK') + http = Minitest::Mock.new + http.expect(:get, response, ['/fjordllc/bootcamp/main/app/models/product.rb', { 'User-Agent' => 'fjord-bootcamp-pjord' }]) + response.define_singleton_method(:body) { 'class Product < ApplicationRecord; end' } + + block.call(http) + }) do + body = ProductAiReviewer::GithubCodeFetcher.send(:fetch_url, github_url) + + assert_equal 'class Product < ApplicationRecord; end', body + end + + assert_equal ProductAiReviewer::GithubCodeFetcher::OPEN_TIMEOUT, captured_options[:open_timeout] + assert_equal ProductAiReviewer::GithubCodeFetcher::READ_TIMEOUT, captured_options[:read_timeout] + end +end diff --git a/test/models/product_ai_reviewer_test.rb b/test/models/product_ai_reviewer_test.rb new file mode 100644 index 00000000000..f8dc72472bd --- /dev/null +++ b/test/models/product_ai_reviewer_test.rb @@ -0,0 +1,138 @@ +# frozen_string_literal: true + +require 'test_helper' + +class ProductAiReviewerTest < ActiveSupport::TestCase + test '.review asks latest Opus model with product review context' do + product = products(:product1) + mock_content = Struct.new(:content).new({ body: 'レビュー本文' }) + mock_chat = Minitest::Mock.new + asked_message = nil + instructions = nil + + mock_chat.expect(:with_instructions, mock_chat) do |text| + instructions = text + true + end + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) + mock_chat.expect(:ask, mock_content) do |message| + asked_message = message + true + end + + RubyLLM.stub(:chat, lambda { |model:| + assert_equal ProductAiReviewer::MODEL, model + mock_chat + }) do + assert_equal 'レビュー本文', ProductAiReviewer.review(product) + end + + assert_includes asked_message, product.user.login_name + assert_includes asked_message, product.practice.title + assert_includes asked_message, product.body + assert_includes asked_message, product.practice.submission_answer.description + assert_includes asked_message, products(:product15).body + assert_includes instructions, Pjord::SYSTEM_PROMPT + assert_includes instructions, '語尾に「ピヨ」など特徴的な語尾は付けず' + assert_includes instructions, '提出物にレビューコメントを書いてください。' + mock_chat.verify + end + + test '.review handles user without course' do + product = products(:product1) + product.user.update_column(:course_id, nil) # rubocop:disable Rails/SkipsModelValidations + mock_content = Struct.new(:content).new({ body: 'レビュー本文' }) + mock_chat = Minitest::Mock.new + asked_message = nil + + mock_chat.expect(:with_instructions, mock_chat, [String]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) + mock_chat.expect(:ask, mock_content) do |message| + asked_message = message + true + end + + RubyLLM.stub(:chat, mock_chat) do + assert_equal 'レビュー本文', ProductAiReviewer.review(product) + end + + assert_includes asked_message, '進捗率: 不明' + mock_chat.verify + end + + test '.review truncates long text in prompt' do + product = products(:product1) + product.update!(body: 'a' * (ProductAiReviewer::PROMPT_TEXT_LIMIT + 1)) + mock_content = Struct.new(:content).new({ body: 'レビュー本文' }) + mock_chat = Minitest::Mock.new + asked_message = nil + + mock_chat.expect(:with_instructions, mock_chat, [String]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) + mock_chat.expect(:ask, mock_content) do |message| + asked_message = message + true + end + + RubyLLM.stub(:chat, mock_chat) do + assert_equal 'レビュー本文', ProductAiReviewer.review(product) + end + + assert_includes asked_message, 'a' * ProductAiReviewer::PROMPT_TEXT_LIMIT + assert_not_includes asked_message, 'a' * (ProductAiReviewer::PROMPT_TEXT_LIMIT + 1) + mock_chat.verify + end + + test '.review includes fetched GitHub code linked from product body' do + product = products(:product1) + github_url = 'https://github.com/fjordllc/bootcamp/blob/main/app/models/product.rb' + product.update!(body: "コードはこちらです。\n#{github_url}") + mock_content = Struct.new(:content).new({ body: 'レビュー本文' }) + mock_chat = Minitest::Mock.new + asked_message = nil + + mock_chat.expect(:with_instructions, mock_chat, [String]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) + mock_chat.expect(:ask, mock_content) do |message| + asked_message = message + true + end + + github_code = [{ url: github_url, language: 'rb', body: 'class Product < ApplicationRecord; end' }] + ProductAiReviewer::GithubCodeFetcher.stub(:fetch, github_code) do + RubyLLM.stub(:chat, mock_chat) do + assert_equal 'レビュー本文', ProductAiReviewer.review(product) + end + end + + assert_includes asked_message, '## 提出物内のGitHubリンク先コード' + assert_includes asked_message, "### #{github_url}" + assert_includes asked_message, '```rb' + assert_includes asked_message, 'class Product < ApplicationRecord; end' + mock_chat.verify + end + + test '.review ignores non-code GitHub links in product body' do + product = products(:product1) + product.update!(body: 'https://github.com/fjordllc/bootcamp/issues/1') + mock_content = Struct.new(:content).new({ body: 'レビュー本文' }) + mock_chat = Minitest::Mock.new + asked_message = nil + + mock_chat.expect(:with_instructions, mock_chat, [String]) + mock_chat.expect(:with_schema, mock_chat, [PjordResponse]) + mock_chat.expect(:ask, mock_content) do |message| + asked_message = message + true + end + + ProductAiReviewer::GithubCodeFetcher.stub(:fetch, []) do + RubyLLM.stub(:chat, mock_chat) do + assert_equal 'レビュー本文', ProductAiReviewer.review(product) + end + end + + assert_includes asked_message, "## 提出物内のGitHubリンク先コード\nなし" + mock_chat.verify + end +end diff --git a/test/models/question_auto_closer_test.rb b/test/models/question_auto_closer_test.rb index 05a3058a964..9b24f82a60a 100644 --- a/test/models/question_auto_closer_test.rb +++ b/test/models/question_auto_closer_test.rb @@ -1,65 +1,56 @@ # frozen_string_literal: true require 'test_helper' +require 'supports/question_auto_closer_helper' class QuestionAutoCloserTest < ActiveSupport::TestCase - AUTO_CLOSE_WARNING_MESSAGE = 'このQ&Aは1ヶ月間コメントがありませんでした。1週間後に自動的にクローズされます。' + include QuestionAutoCloserHelper + + WARNING_MESSAGE = 'このQ&Aは1ヶ月間更新がありませんでした。このまま更新がなければ1週間後に自動的にクローズされます。' AUTO_CLOSE_MESSAGE = '自動的にクローズしました。' - test '.post_warning' do - created_at = Time.zone.local(2025, 10, 1, 0, 0, 0) - question = Question.create!( - title: '自動クローズテスト', - description: 'テスト', - user: users(:kimura), - created_at:, - updated_at: created_at - ) + test 'posts warning for inactive questions' do + question = create_question + question_auto_closer = QuestionAutoCloser.new - travel_to created_at.advance(months: 1, days: -1) do + travel_to question.created_at.advance(months: 1, days: -1) do assert_no_difference -> { question.answers.count } do - QuestionAutoCloser.post_warning + question_auto_closer.post_warning end end - travel_to created_at.advance(months: 1) do + travel_to question.created_at.advance(months: 1) do assert_difference -> { question.answers.count }, 1 do - QuestionAutoCloser.post_warning + question_auto_closer.post_warning end answer = question.answers.last assert_equal users(:pjord), answer.user - assert_equal AUTO_CLOSE_WARNING_MESSAGE, answer.description + assert_equal WARNING_MESSAGE, answer.description end end - test '.close_and_select_best_answer' do - created_at = Time.zone.local(2025, 10, 1, 0, 0, 0) - question = Question.create!( - title: '自動クローズテスト', - description: 'テスト', - user: users(:kimura), - created_at:, - updated_at: created_at - ) + test 'auto-closes inactive questions' do + question = create_question + question_auto_closer = QuestionAutoCloser.new - warned_at = created_at.advance(months: 1) + warned_at = question.created_at.advance(months: 1) system_user = users(:pjord) question.answers.create!( user: system_user, - description: AUTO_CLOSE_WARNING_MESSAGE, + description: WARNING_MESSAGE, created_at: warned_at, updated_at: warned_at ) travel_to warned_at.advance(weeks: 1, days: -1) do assert_no_difference -> { question.answers.count } do - QuestionAutoCloser.close_and_select_best_answer + question_auto_closer.close_inactive_questions end end travel_to warned_at.advance(weeks: 1) do assert_difference -> { question.answers.count }, 1 do - QuestionAutoCloser.close_and_select_best_answer + question_auto_closer.close_inactive_questions end answer = question.answers.last assert_equal system_user, answer.user @@ -69,37 +60,24 @@ class QuestionAutoCloserTest < ActiveSupport::TestCase end test 'does not post warning for WIP questions' do - created_at = Time.zone.local(2025, 10, 1, 0, 0, 0) - question = Question.create!( - title: 'WIPの質問', - description: 'テスト', - user: users(:kimura), - wip: true, - created_at:, - updated_at: created_at - ) + question = create_question(wip: true) + question_auto_closer = QuestionAutoCloser.new - travel_to created_at.advance(months: 1) do + travel_to question.created_at.advance(months: 1) do assert_no_difference -> { question.answers.count } do - QuestionAutoCloser.post_warning + question_auto_closer.post_warning end end end test 'does not close WIP questions' do - created_at = Time.zone.local(2025, 10, 1, 0, 0, 0) - question = Question.create!( - title: '公開から1ヶ月後WIPにする質問', - description: 'テスト', - user: users(:kimura), - created_at:, - updated_at: created_at - ) + question = create_question + question_auto_closer = QuestionAutoCloser.new - warned_at = created_at.advance(months: 1) + warned_at = question.created_at.advance(months: 1) question.answers.create!( user: users(:pjord), - description: AUTO_CLOSE_WARNING_MESSAGE, + description: WARNING_MESSAGE, created_at: warned_at, updated_at: warned_at ) @@ -107,28 +85,229 @@ class QuestionAutoCloserTest < ActiveSupport::TestCase travel_to warned_at.advance(weeks: 1) do assert_no_difference -> { question.answers.count } do - QuestionAutoCloser.close_and_select_best_answer + question_auto_closer.close_inactive_questions end end end - test 'resets warning countdown when the question is updated' do - created_at = Time.zone.local(2025, 10, 1, 0, 0, 0) - question = Question.create!( - title: '後日公開する質問', - description: 'テスト', - user: users(:kimura), - wip: true, - created_at:, - updated_at: created_at + test 'does not post warning for solved questions' do + question = create_question + question_auto_closer = QuestionAutoCloser.new + + solved_at = question.created_at.advance(days: 1) + CorrectAnswer.create!( + question:, + user: users(:komagata), + description: 'ベストアンサーです', + created_at: solved_at, + updated_at: solved_at + ) + + travel_to solved_at.advance(months: 1) do + assert_no_difference -> { question.answers.count } do + question_auto_closer.post_warning + end + end + end + + test 'does not post auto-close messages for auto-closed questions' do + # 「未解決である」の条件と警告の文言のチェックのいずれか一方を外しても自動クローズ機能は仕様通り振る舞う + # 誤って両方の条件を外すとこのテストケースが失敗する + question = create_question + question_auto_closer = QuestionAutoCloser.new + + warned_at = question.created_at.advance(months: 1) + system_user = users(:pjord) + question.answers.create!( + user: system_user, + description: WARNING_MESSAGE, + created_at: warned_at, + updated_at: warned_at + ) + closed_at = warned_at.advance(weeks: 1) + CorrectAnswer.create!( + question:, + user: system_user, + description: AUTO_CLOSE_MESSAGE, + created_at: closed_at, + updated_at: closed_at ) - updated_at = created_at.advance(months: 1) + travel_to closed_at.advance(weeks: 1) do + assert_no_difference -> { question.answers.count } do + question_auto_closer.close_inactive_questions + end + end + end + + test 'does not auto-close questions without any warning messages' do + question = create_question + question_auto_closer = QuestionAutoCloser.new + + question.answers.create!( + user: users(:komagata), + description: '回答しました', + created_at: question.created_at, + updated_at: question.created_at + ) + + travel_to question.created_at.advance(weeks: 1) do + assert_no_difference -> { question.answers.count } do + question_auto_closer.close_inactive_questions + end + end + end + + test 'resets warning countdown when the question is updated' do + question = create_question(wip: true) + question_auto_closer = QuestionAutoCloser.new + + updated_at = question.created_at.advance(months: 1) question.update!(wip: false, updated_at:) travel_to updated_at do assert_no_difference -> { question.answers.count } do - QuestionAutoCloser.post_warning + question_auto_closer.post_warning + end + end + end + + test 'resets auto-close countdown when the question is updated' do + question = create_question + question_auto_closer = QuestionAutoCloser.new + + warned_at = question.created_at.advance(months: 1) + question.answers.create!( + user: users(:pjord), + description: WARNING_MESSAGE, + created_at: warned_at, + updated_at: warned_at + ) + updated_at = warned_at.advance(days: 1) + question.update!(description: '質問内容を更新しました', updated_at:) + + travel_to warned_at.advance(weeks: 1) do + assert_no_difference -> { question.answers.count } do + question_auto_closer.close_inactive_questions + end + end + end + + test 'resets auto-close countdown when a new answer is added' do + question = create_question + question_auto_closer = QuestionAutoCloser.new + + warned_at = question.created_at.advance(months: 1) + question.answers.create!( + user: users(:pjord), + description: WARNING_MESSAGE, + created_at: warned_at, + updated_at: warned_at + ) + added_at = warned_at.advance(days: 1) + question.answers.create!( + user: users(:komagata), + description: '回答しました', + created_at: added_at, + updated_at: added_at + ) + + travel_to warned_at.advance(weeks: 1) do + assert_no_difference -> { question.answers.count } do + question_auto_closer.close_inactive_questions + end + end + end + + test 'auto-closes questions that have been reopened after auto-closing' do + question = create_question + question_auto_closer = QuestionAutoCloser.new + + warned_at = question.created_at.advance(months: 1) + system_user = users(:pjord) + question.answers.create!( + user: system_user, + description: WARNING_MESSAGE, + created_at: warned_at, + updated_at: warned_at + ) + closed_at = warned_at.advance(weeks: 1) + auto_close_comment = CorrectAnswer.create!( + question:, + user: system_user, + description: AUTO_CLOSE_MESSAGE, + created_at: closed_at, + updated_at: closed_at + ) + reopened_at = closed_at.advance(days: 1) + auto_close_comment.update!(type: nil, updated_at: reopened_at) + question.answers.create!( + user: users(:kimura), + description: '回答を再募集します', + created_at: reopened_at, + updated_at: reopened_at + ) + + travel_to reopened_at.advance(months: 1, days: -1) do + assert_no_difference -> { question.answers.count } do + question_auto_closer.post_warning + end + end + + again_warned_at = reopened_at.advance(months: 1) + travel_to again_warned_at do + assert_difference -> { question.answers.count }, 1 do + question_auto_closer.post_warning + end + answer = question.answers.last + assert_equal system_user, answer.user + assert_equal WARNING_MESSAGE, answer.description + end + + travel_to again_warned_at.advance(weeks: 1, days: -1) do + assert_no_difference -> { question.answers.count } do + question_auto_closer.close_inactive_questions + end + end + + travel_to again_warned_at.advance(weeks: 1) do + assert_difference -> { question.answers.count }, 1 do + question_auto_closer.close_inactive_questions + end + answer = question.answers.last + assert_equal system_user, answer.user + assert_equal AUTO_CLOSE_MESSAGE, answer.description + assert answer.is_a?(CorrectAnswer) + end + end + + test 'emits a notification when an warning message is posted' do + question = create_question + question_auto_closer = QuestionAutoCloser.new + + travel_to question.created_at.advance(months: 1) do + assert_notification('answer.create') do + question_auto_closer.post_warning + end + end + end + + test 'emits notifications when an auto-close message is posted' do + question = create_question + question_auto_closer = QuestionAutoCloser.new + + warned_at = question.created_at.advance(months: 1) + system_user = users(:pjord) + question.answers.create!( + user: system_user, + description: WARNING_MESSAGE, + created_at: warned_at, + updated_at: warned_at + ) + + travel_to warned_at.advance(weeks: 1) do + assert_notifications_count(/\w*answer.save/, 2) do + question_auto_closer.close_inactive_questions end end end diff --git a/test/models/regular_event_skip_date_test.rb b/test/models/regular_event_skip_date_test.rb new file mode 100644 index 00000000000..9b545e814ce --- /dev/null +++ b/test/models/regular_event_skip_date_test.rb @@ -0,0 +1,16 @@ +# frozen_string_literal: true + +require 'test_helper' + +class RegularEventSkipDateTest < ActiveSupport::TestCase + test 'invalid when skip_on already exists for the same regular_event' do + regular_event = regular_events(:regular_event7) + + regular_event.regular_event_skip_dates.create!(skip_on: '2026-06-01', reason: '既存') + + duplicate_skip_date = regular_event.regular_event_skip_dates.build(skip_on: '2026-06-01', reason: '重複') + + assert_not duplicate_skip_date.valid? + assert_includes duplicate_skip_date.errors[:skip_on], '(2026-06-01)は既に登録されています' + end +end diff --git a/test/models/regular_event_test.rb b/test/models/regular_event_test.rb index 2d41b986bd2..8e6ab88fb3b 100644 --- a/test/models/regular_event_test.rb +++ b/test/models/regular_event_test.rb @@ -81,6 +81,19 @@ class RegularEventTest < ActiveSupport::TestCase end end + test '#next_event_date returns next holding date excluding custom skip date' do + regular_event = regular_events(:regular_event1) + + travel_to Time.zone.local(2026, 4, 1, 0, 0, 0) do + regular_event.regular_event_skip_dates.create!( + skip_on: Date.new(2026, 4, 5), + reason: '主催都合により休み' + ) + + assert_equal Date.new(2026, 4, 12), regular_event.next_event_date + end + end + test '#cancel_participation' do regular_event = regular_events(:regular_event1) participant = regular_event_participations(:regular_event_participation1).user @@ -173,6 +186,7 @@ class RegularEventTest < ActiveSupport::TestCase regular_events = RegularEvent.scheduled_on_without_ended(today_date) regular_event_in_progress = regular_events(:regular_event36) regular_event_ended = regular_events(:regular_event37) + assert_includes regular_events, regular_event_in_progress assert_not_includes regular_events, regular_event_ended end @@ -186,4 +200,94 @@ class RegularEventTest < ActiveSupport::TestCase assert_includes regular_events, regular_event_scheduled_for_tomorrow end end + + test '#skip_event? returns true when the date is in regular_event_skip_dates' do + regular_event = regular_events(:regular_event7) + regular_event.regular_event_skip_dates.create!(skip_on: Date.new(2026, 4, 8), reason: '主催都合のため') + + assert regular_event.skip_event?(Date.new(2026, 4, 8)) + end + + test '#skip_event? returns true on a holiday when hold_national_holiday is false' do + regular_event = regular_events(:regular_event7) + regular_event.update!(hold_national_holiday: false) + + assert regular_event.skip_event?(Date.new(2026, 4, 29)) + end + + test '#skip_event? returns false on a holiday when hold_national_holiday is true' do + regular_event = regular_events(:regular_event7) + regular_event.update!(hold_national_holiday: true) + + assert_not regular_event.skip_event?(Date.new(2026, 4, 29)) + end + + test '#skip_event? returns false on a non-holiday date with no skip date' do + regular_event = regular_events(:regular_event7) + regular_event.update!(hold_national_holiday: false) + + assert_not regular_event.skip_event?(Date.new(2026, 4, 8)) + end + + test '.date_match_the_rules? matches weekly weekday rule' do + regular_event = regular_events(:regular_event7) # 毎週水曜開催イベント + + # 2026-04-22は水曜 + assert regular_event.date_match_the_rules?(Date.new(2026, 4, 22), regular_event.regular_event_repeat_rules) + end + + test '.date_match_the_rules? matches first weekday rule' do + regular_event = regular_events(:regular_event2) # 第1月曜開催イベント + + # 2026-04-06は第1月曜 + assert regular_event.date_match_the_rules?(Date.new(2026, 4, 6), regular_event.regular_event_repeat_rules) + end + + test '.date_match_the_rules? matches second weekday rule' do + regular_event = regular_events(:regular_event3) # 第2月曜開催イベント + + # 2026-04-13は第2月曜 + assert regular_event.date_match_the_rules?(Date.new(2026, 4, 13), regular_event.regular_event_repeat_rules) + end + + test '.date_match_the_rules? matches third weekday rule' do + regular_event = regular_events(:regular_event4) # 第3火曜開催イベント + + # 2026-04-21は第3火曜 + assert regular_event.date_match_the_rules?(Date.new(2026, 4, 21), regular_event.regular_event_repeat_rules) + end + + test '.date_match_the_rules? matches fourth weekday rule' do + regular_event = regular_events(:regular_event6) # 第4月曜開催イベント + + # 2026-04-27は第4月曜 + assert regular_event.date_match_the_rules?(Date.new(2026, 4, 27), regular_event.regular_event_repeat_rules) + end + + test '.date_match_the_rules? returns false when date does not match rule' do + regular_event = regular_events(:regular_event7) # 毎週水曜開催イベント + + # 2026-04-23は木曜 + assert_not regular_event.date_match_the_rules?(Date.new(2026, 4, 23), regular_event.regular_event_repeat_rules) + end + + test '#validate_skip_on_uniqueness' do + travel_to Time.zone.local(2026, 4, 1, 10, 0, 0) do + regular_event = regular_events(:regular_event7) + + regular_event.regular_event_skip_dates.build(skip_on: Date.new(2026, 4, 8)) + regular_event.regular_event_skip_dates.build(skip_on: Date.new(2026, 4, 8)) + + assert_not regular_event.save + assert_includes regular_event.errors[:base], 'スキップする日に重複した日付が含まれています' + end + end + + test '.not_finished exclude wip and finished events' do + events = RegularEvent.not_finished + wip_event = regular_events(:regular_event42) + finished_event = regular_events(:regular_event39) + assert_not_includes events, wip_event + assert_not_includes events, finished_event + end end diff --git a/test/models/report_notifier_test.rb b/test/models/report_notifier_test.rb new file mode 100644 index 00000000000..e1eaa50abbb --- /dev/null +++ b/test/models/report_notifier_test.rb @@ -0,0 +1,60 @@ +# frozen_string_literal: true + +require 'test_helper' + +class ReportNotifierTest < ActiveSupport::TestCase + test 'notifies mention target only when report is initially posted' do + author = users(:machida) + receiver = users(:kimura) + report = build_wip_report(author, title: '初めて提出したら、', description: "@#{receiver.login_name} に通知する") + + assert_notify_only_when_initially_posted(report, -> { AbstractNotifier::Testing::Driver.enqueued_deliveries.count }) + end + + test 'notifies company advisor only when report is initially posted' do + author = users(:kensyu) + report = build_wip_report(author, title: '研修生が日報を作成し提出した時', description: 'アドバイザーに通知を飛ばす') + + assert_notify_only_when_initially_posted(report, -> { AbstractNotifier::Testing::Driver.deliveries.count }) + end + + test 'notifies follower only when report is initially posted' do + following = Following.find_by!(follower: users(:kensyu), followed: users(:muryou)) + author = following.followed + report = build_wip_report(author, title: '初めて提出した時だけ', description: 'フォローされているユーザーに通知を飛ばす') + + assert_notify_only_when_initially_posted(report, -> { AbstractNotifier::Testing::Driver.enqueued_deliveries.count }) + end + + private + + def build_wip_report(user, title:, description:) + user.reports.destroy_all + Report.create!( + user:, + title:, + description:, + reported_on: Date.current, + wip: true, + published_at: nil + ) + end + + def assert_notify_only_when_initially_posted(report, notification_count) + notifier = ReportNotifier.new + + assert_no_difference notification_count do + notifier.call('report.create', Time.current, Time.current, 'unique_id', report:) + end + + report.update!(wip: false, description: "#{report.description}\n公開") + assert_difference notification_count, 1 do + notifier.call('report.update', Time.current, Time.current, 'unique_id', report:) + end + + report.reload.update!(description: "#{report.description}\n更新") + assert_no_difference notification_count do + notifier.call('report.update', Time.current, Time.current, 'unique_id', report:) + end + end +end diff --git a/test/models/report_test.rb b/test/models/report_test.rb index 2c64e8b351e..8b69e6693da 100644 --- a/test/models/report_test.rb +++ b/test/models/report_test.rb @@ -73,4 +73,20 @@ class ReportTest < ActiveSupport::TestCase assert_empty unchecked_report.checks assert_includes Report.unchecked, unchecked_report end + + test '.for_practice_including_source returns practice and source reports' do + practice = practices(:practice66) + practice_report = reports(:report77) + source_report = reports(:report76) + practice_and_source_report = reports(:report78) + other_report = reports(:report79) + unrelated_report = reports(:report80) + result = Report.for_practice_including_source(practice) + + assert_includes result, practice_report + assert_includes result, source_report + assert_includes result, practice_and_source_report + assert_not_includes result, other_report + assert_not_includes result, unrelated_report + end end diff --git a/test/models/retirement_test.rb b/test/models/retirement_test.rb index 9eaa6136354..723f1fa13dc 100644 --- a/test/models/retirement_test.rb +++ b/test/models/retirement_test.rb @@ -19,6 +19,7 @@ class RetirementTest < ActiveSupport::TestCase clean_up_regular_events clear_github_info destroy_cards + unmatch_pair_works publish notify ] diff --git a/test/models/user_test.rb b/test/models/user_test.rb index 6ed9c1dd537..407f448daaa 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -203,6 +203,22 @@ class UserTest < ActiveSupport::TestCase assert user.invalid? end + test 'reserved login_name is invalid' do + user = users(:komagata) + user.login_name = 'mentor' + + assert user.invalid? + assert_includes user.errors[:login_name], 'に使用できない文字列が含まれています' + end + + test 'description is required' do + user = users(:komagata) + user.description = nil + + assert user.invalid? + assert_includes user.errors[:description], 'を入力してください' + end + test 'twitter_account' do user = users(:komagata) user.twitter_account = '' @@ -682,30 +698,30 @@ class UserTest < ActiveSupport::TestCase assert_empty User.users_role(not_scope_name, allowed_targets:) end - test '#clean_up_regular_events removes participant from holding regular event' do + test '#clean_up_regular_events removes participant from unfinished regular event' do user = users(:kimura) - holding_paticipated_event = regular_events(:regular_event1) - holding_paticipated_event.regular_event_participations.create!(user: user) - finished_paticipated_event = regular_events(:regular_event2) - finished_paticipated_event.update!(finished: true) - finished_paticipated_event.regular_event_participations.create!(user: user) + unfinished_participated_event = regular_events(:regular_event1) + unfinished_participated_event.regular_event_participations.create!(user: user) + finished_participated_event = regular_events(:regular_event2) + finished_participated_event.update!(finished: true) + finished_participated_event.regular_event_participations.create!(user: user) user.clean_up_regular_events - assert_not holding_paticipated_event.regular_event_participations.exists?(user:) - assert finished_paticipated_event.regular_event_participations.exists?(user:) + assert_not unfinished_participated_event.regular_event_participations.exists?(user:) + assert finished_participated_event.regular_event_participations.exists?(user:) end - test '#clean_up_regular_events removes organizer from holding regular event' do + test '#clean_up_regular_events removes organizer from unfinished regular event' do user = users(:kimura) # kimuraが主催しているイベント - holding_organized_event = regular_events(:regular_event4) + unfinished_organized_event = regular_events(:regular_event4) finished_organized_event = regular_events(:regular_event5) finished_organized_event.update!(finished: true) user.clean_up_regular_events - assert_not holding_organized_event.regular_event_organizers.exists?(user:) + assert_not unfinished_organized_event.regular_event_organizers.exists?(user:) assert finished_organized_event.regular_event_organizers.exists?(user:) end @@ -783,4 +799,18 @@ class UserTest < ActiveSupport::TestCase user.mark_mail_as_sent_before_auto_retire assert user.sent_student_before_auto_retire_mail end + + test '#involved_regular_events returns both participating and organizing regular events' do + user = users(:kimura) + expected_ids = (user.participate_regular_events.ids + user.organize_regular_events.ids).uniq.sort + actual_ids = user.involved_regular_events.ids.sort + assert_equal expected_ids, actual_ids + end + + test '#involved_events returns both participating and organizing events' do + user = users(:kimura) + expected_ids = (user.participate_events.ids + Event.where(user_id: user.id).ids).uniq.sort + actual_ids = user.involved_events.ids.sort + assert_equal expected_ids, actual_ids + end end diff --git a/test/supports/clipboard_helper.rb b/test/supports/clipboard_helper.rb index 79402089bde..69e8e1da71a 100644 --- a/test/supports/clipboard_helper.rb +++ b/test/supports/clipboard_helper.rb @@ -2,23 +2,11 @@ module ClipboardHelper def cmd_ctrl - page.driver.browser.capabilities.platform_name.include?('mac') ? :command : :control + RUBY_PLATFORM.include?('darwin') ? :command : :control end def grant_clipboard_permission - page.driver.browser.execute_cdp( - 'Browser.grantPermissions', - origin: page.server_url, - permissions: %w[clipboardReadWrite clipboardSanitizedWrite] - ) - rescue StandardError => e - warn "Browser.grantPermissions failed: #{e.message}, trying fallback method" - cdp_permission = { - origin: page.server_url, - permission: { name: 'clipboard-read' }, - setting: 'granted' - } - page.driver.browser.execute_cdp('Browser.setPermission', **cdp_permission) + # Clipboard access is granted by the Playwright driver options. end def clipboard_supported? @@ -41,15 +29,15 @@ def read_clipboard_with_retry(expected_text: nil, max_retries: 20, interval: 0.5 end def select_all_and_copy(selector) - find(selector).native.send_keys([cmd_ctrl, 'a'], [cmd_ctrl, 'c']) + find(selector).send_keys([cmd_ctrl, 'a'], [cmd_ctrl, 'c']) end def paste_to(selector) - find(selector).native.send_keys([cmd_ctrl, 'v']) + find(selector).send_keys([cmd_ctrl, 'v']) end def undo_in(selector) - find(selector).native.send_keys([cmd_ctrl, 'z']) + find(selector).send_keys([cmd_ctrl, 'z']) end # CIでのみペースト前のctrl + Aが効かないため文字列の選択をselect()メソッドで実行 diff --git a/test/supports/login_helper.rb b/test/supports/login_helper.rb index 6afe4ce592c..a6b6d5af4c4 100644 --- a/test/supports/login_helper.rb +++ b/test/supports/login_helper.rb @@ -12,5 +12,9 @@ def login_user(login_name, password) def logout visit '/logout' + rescue Playwright::TargetClosedError, Playwright::TimeoutError + nil + rescue Playwright::Error => e + raise unless e.message.include?('net::ERR_ABORTED') end end diff --git a/test/supports/question_auto_closer_helper.rb b/test/supports/question_auto_closer_helper.rb new file mode 100644 index 00000000000..18a6b858db0 --- /dev/null +++ b/test/supports/question_auto_closer_helper.rb @@ -0,0 +1,16 @@ +# frozen_string_literal: true + +module QuestionAutoCloserHelper + def create_question(wip: false) + # 再現性のために時刻を固定。値は任意 + created_at = Time.zone.local(2025, 10, 1, 0, 0, 0) + Question.create!( + title: '自動クローズテスト', + description: 'テスト', + user: users(:kimura), + wip:, + created_at:, + updated_at: created_at + ) + end +end diff --git a/test/supports/stripe_helper.rb b/test/supports/stripe_helper.rb index b8e2d89e7a0..94ef40e11f3 100644 --- a/test/supports/stripe_helper.rb +++ b/test/supports/stripe_helper.rb @@ -2,45 +2,52 @@ module StripeHelper def fill_stripe_element(card, exp, cvc) - card_iframe = find('iframe[name^="__privateStripeFrame"]') - - within_frame card_iframe do - wait_and_fill_field('cardnumber', card) - wait_and_fill_field('exp-date', exp) - wait_and_fill_field('cvc', cvc) - end + wait_and_fill_stripe_field('cardnumber', card) + wait_and_fill_stripe_field('exp-date', exp) + wait_and_fill_stripe_field('cvc', cvc) page.has_no_css?('iframe[name^="__privateStripeFrame"]') end private - def wait_and_fill_field(field_name, value) - field = wait_for_visible_field(field_name) + def wait_and_fill_stripe_field(field_name, value) + field = wait_for_visible_stripe_field(field_name) fill_field_slowly(field, value) end - def wait_for_visible_field(field_name) - field = find_visible_field_with_retry(field_name) + def wait_for_visible_stripe_field(field_name) + field = find_visible_stripe_field_with_retry(field_name) raise_field_not_found_error(field_name) unless field wait_until_field_ready(field) field end - def find_visible_field_with_retry(field_name) + def find_visible_stripe_field_with_retry(field_name) field = nil - 10.times do |attempt| - sleep 1 - field = try_find_visible_field(field_name, attempt) + 5.times do + field = find_visible_stripe_field(field_name) break if field + + sleep 0.5 end field end - def try_find_visible_field(field_name, _attempt) - find_field(field_name, visible: true) - rescue Capybara::ElementNotFound + def find_visible_stripe_field(field_name) + all('iframe[name^="__privateStripeFrame"]').each do |iframe| + field = find_field_in_frame(iframe, field_name) + return field if field + end + nil + end + + def find_field_in_frame(iframe, field_name) + within_frame iframe do + find_field(field_name, visible: true) + end + rescue Capybara::ElementNotFound, Capybara::Playwright::Node::StaleReferenceError nil end @@ -64,7 +71,7 @@ def wait_until_field_ready(field) begin field.tag_name return true - rescue Selenium::WebDriver::Error::StaleElementReferenceError + rescue Capybara::ElementNotFound, Capybara::Playwright::Node::StaleReferenceError attempts += 1 sleep 0.2 next diff --git a/test/supports/tag_helper.rb b/test/supports/tag_helper.rb index efbed3e5837..0c8c9684776 100644 --- a/test/supports/tag_helper.rb +++ b/test/supports/tag_helper.rb @@ -16,12 +16,23 @@ def click_tag_edit def click_tag_name_change close_header_dropdowns - page.execute_script('arguments[0].click()', find_button('タグ名変更')) + page.execute_script('arguments[0].click()', first('.change-tag-name-button')) end def click_save_tag_name_change close_header_dropdowns - page.execute_script('arguments[0].click()', find_button('変更')) + button = find('.edit-tag-modal:not(.hidden) .save-tag-button') + page.execute_script('arguments[0].click()', button) + end + + def fill_in_open_tag_modal(name) + input = find('.edit-tag-modal:not(.hidden) input[name="tag[name]"]') + page.execute_script(<<~JS, input, name) + const input = arguments[0] + input.value = arguments[1] + input.dispatchEvent(new Event('input', { bubbles: true })) + input.dispatchEvent(new KeyboardEvent('keyup', { bubbles: true })) + JS end def click_save_tags @@ -33,7 +44,7 @@ def fill_in_tag(name, selector = '.tagify__input') tag_count_before = all('.tagify__tag', visible: :all).count tag_input = find(selector, match: :first) page.execute_script('arguments[0].click()', tag_input) - tag_input.native.send_keys(name, :return) + tag_input.send_keys(name, :return) assert_selector('.tagify__tag', count: tag_count_before + 1, wait: 10, visible: :all) # Wait for the hidden input to be updated with the new tag (React components only) return unless has_selector?("input[type='hidden'][name*='tag_list']", visible: :all) @@ -45,7 +56,7 @@ def fill_in_tag_with_alert(name, selector = '.tagify__input') tag_input = find(selector) page.execute_script('arguments[0].click()', tag_input) accept_alert do - tag_input.native.send_keys(name, :return) + tag_input.send_keys(name, :return) end assert_selector(selector) end diff --git a/test/system/admin/companies_test.rb b/test/system/admin/companies_test.rb index 3a3d40ca7cc..6b47c258720 100644 --- a/test/system/admin/companies_test.rb +++ b/test/system/admin/companies_test.rb @@ -39,8 +39,9 @@ class Admin::CompaniesTest < ApplicationSystemTestCase test 'delete company' do visit_with_auth "/admin/companies/#{companies(:company1).id}/edit", 'komagata' - click_on '削除' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '削除' + end assert_text '企業を削除しました。' end diff --git a/test/system/admin/faq_category_test.rb b/test/system/admin/faq_category_test.rb index fe1a7d88b80..3f4924532b5 100644 --- a/test/system/admin/faq_category_test.rb +++ b/test/system/admin/faq_category_test.rb @@ -28,8 +28,9 @@ class Admin::FaqCategoryest < ApplicationSystemTestCase test 'delete FAQ' do visit_with_auth "/admin/faq_categories/#{faq_categories(:faq_category1).id}/edit", 'komagata' - click_on '削除' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '削除' + end assert_text 'FAQカテゴリーを削除しました。' end end diff --git a/test/system/admin/faq_test.rb b/test/system/admin/faq_test.rb index 85b25da51d4..8681d77007c 100644 --- a/test/system/admin/faq_test.rb +++ b/test/system/admin/faq_test.rb @@ -33,7 +33,7 @@ class Admin::FAQTest < ApplicationSystemTestCase test "display answer's preview" do visit_with_auth '/admin/faqs/new', 'komagata' within 'form[name=faq]' do - fill_in 'faq[answer]', with: 'updated FAQ' + find_field('faq[answer]').send_keys 'updated FAQ' end assert_selector '.markdown-form__preview', text: 'updated FAQ' end @@ -41,15 +41,16 @@ class Admin::FAQTest < ApplicationSystemTestCase test 'display link tag when answer has links' do visit_with_auth '/admin/faqs/new', 'komagata' within 'form[name=faq]' do - fill_in 'faq[answer]', with: '[test](https://example.com)' + find_field('faq[answer]').send_keys '[test](https://example.com)' end assert_selector '.markdown-form__preview a', text: 'test' end test 'delete FAQ' do visit_with_auth "/admin/faqs/#{faqs(:faq1).id}/edit", 'komagata' - click_on '削除' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '削除' + end assert_text 'FAQを削除しました。' end end diff --git a/test/system/admin/users_test.rb b/test/system/admin/users_test.rb index bb45273420e..def879189ea 100644 --- a/test/system/admin/users_test.rb +++ b/test/system/admin/users_test.rb @@ -255,12 +255,10 @@ class Admin::UsersTest < ApplicationSystemTestCase test 'edit user tag' do user = users(:kimura) visit_with_auth "/admin/users/#{user.id}/edit", 'komagata' - # Tagify が入力を確定してタグ chip を DOM に追加し、hidden フィールドを - # 更新し終えるのを待ってから保存する（完了前に submit すると空の状態で保存され flaky になる） fill_in_tag('追加タグ') click_on '更新する' - visit "/admin/users/#{user.id}/edit" - assert_text '追加タグ' + assert_text 'ユーザー情報を更新しました。' + assert_includes user.reload.tag_list, '追加タグ' end test 'does not display advisor in the list of trial period users' do diff --git a/test/system/api/check/products_test.rb b/test/system/api/check/products_test.rb index 9368ea0ea51..f52e0bbefb9 100644 --- a/test/system/api/check/products_test.rb +++ b/test/system/api/check/products_test.rb @@ -38,7 +38,6 @@ class Check::ProductsTest < ApplicationSystemTestCase accept_confirm do click_on '合格にする' end - accept_alert '提出物の担当になりました。' assert_text '合格' assert_text '提出物でcomment+合格にするtest' end @@ -49,7 +48,6 @@ class Check::ProductsTest < ApplicationSystemTestCase accept_confirm do click_on '合格にする' end - accept_alert '提出物の担当になりました。' assert_text '合格' assert_text '提出物でcomment+合格にするtest' end diff --git a/test/system/attachments_test.rb b/test/system/attachments_test.rb index 66990e985bf..33fd2e95de1 100644 --- a/test/system/attachments_test.rb +++ b/test/system/attachments_test.rb @@ -1,6 +1,5 @@ # frozen_string_literal: true -# Pull Request #4182(https://github.com/fjordllc/bootcamp/pull/4182) で Rails 7 への移行完了後に削除する require 'application_system_test_case' class AttachmentsTest < ApplicationSystemTestCase diff --git a/test/system/buzz_test.rb b/test/system/buzz_test.rb deleted file mode 100644 index 8714561e70d..00000000000 --- a/test/system/buzz_test.rb +++ /dev/null @@ -1,49 +0,0 @@ -# frozen_string_literal: true - -require 'application_system_test_case' - -class BuzzTest < ApplicationSystemTestCase - test 'non-logged-in user can access /buzz' do - visit buzz_url - assert_text '紹介・言及記事' - assert_text '本文1' - end - - test 'admin can update buzz' do - visit_with_auth edit_buzz_url, 'komagata' - - fill_in 'buzz[body]', with: 'adminが書き換えました' - click_on '更新する' - - assert_text 'adminが書き換えました' - assert_text '紹介・言及記事を更新しました' - end - - test 'mentor can update buzz' do - visit_with_auth edit_buzz_url, 'mentormentaro' - - fill_in 'buzz[body]', with: 'mentorが書き換えました' - click_on '更新する' - - assert_text 'mentorが書き換えました' - assert_text '紹介・言及記事を更新しました' - end - - test 'regular user cannot update buzz' do - visit_with_auth buzz_url, 'kimura' - - assert_no_text '内容修正' - - visit edit_buzz_path - assert_text '管理者・メンターとしてログインしてください' - end - - test 'body should not be blank' do - visit_with_auth edit_buzz_url, 'komagata' - - fill_in 'buzz[body]', with: '' - click_on '更新する' - - assert_text '本文を入力してください' - end -end diff --git a/test/system/buzzes_test.rb b/test/system/buzzes_test.rb new file mode 100644 index 00000000000..ccd5fdf4c63 --- /dev/null +++ b/test/system/buzzes_test.rb @@ -0,0 +1,57 @@ +# frozen_string_literal: true + +require 'application_system_test_case' + +class BuzzesTest < ApplicationSystemTestCase + test 'does not show edit button to users' do + visit_with_auth buzzes_path, 'kimura' + assert_no_link '内容修正' + end + + test 'show edit button to mentors' do + visit_with_auth buzzes_path, 'komagata' + assert_link '内容修正' + end + + test 'mentor clicks edit button to open mentor buzzes page' do + visit_with_auth buzzes_path, 'komagata' + click_link '内容修正' + assert_equal '紹介・言及記事 | FBC', title + end + + test 'user can switch year and see buzzes grouped by month' do + # デフォルトで最も新しい年を表示 + visit_with_auth buzzes_path, 'kimura' + assert_selector '.selected-year', text: '2025' + within('.buzzes-in-01') do + assert_no_text '2025-02-01の記事' + assert_text '2025-01-31の記事' + assert_text '2025-01-01の記事' + assert_no_text '2024-12-31の記事' + end + + click_link '2024' + assert_selector '.selected-year', text: '2024' + within('.buzzes-in-12') do + assert_no_text '2025-01-01の記事' + assert_text '2024-12-31の記事' + end + end + + test 'buzzes are shown in descending order within month' do + visit_with_auth buzzes_path, 'kimura' + assert_selector '.selected-year', text: '2025' + buzzes = all('.buzzes-in-01 li').map(&:text) + expected = %w[2025-01-31の記事 2025-01-01の記事] + assert_equal expected, buzzes + end + + test 'buzzes published on same day use id as tie-breaker in descending order' do + Buzz.create!(title: '2026-02-27のbuzz-id1', url: 'https://www.example-id1.com', published_at: '2026-02-27') + Buzz.create!(title: '2026-02-27のbuzz-id2', url: 'https://www.example-id2.com', published_at: '2026-02-27') + visit_with_auth buzzes_path, 'kimura' + buzzes = all('.buzzes-in-02 li').map(&:text) + expected = %w[2026-02-27のbuzz-id2 2026-02-27のbuzz-id1] + assert_equal expected, buzzes + end +end diff --git a/test/system/comment/base_comments_test.rb b/test/system/comment/base_comments_test.rb index be2ea05cdeb..9ccf6a64189 100644 --- a/test/system/comment/base_comments_test.rb +++ b/test/system/comment/base_comments_test.rb @@ -82,14 +82,7 @@ class BaseCommentsTest < ApplicationSystemTestCase button = find('#js-shortcut-post-comment', text: 'コメントする') button.click - # Try to click again - should be intercepted or disabled - button_disabled = false - begin - button.click - rescue Selenium::WebDriver::Error::ElementClickInterceptedError, Selenium::WebDriver::Error::ElementNotInteractableError - button_disabled = true - end - assert button_disabled, 'Button should be disabled after first click' + assert_selector '#js-shortcut-post-comment[disabled]' end test 'submit_button is enabled after a post is done' do @@ -120,7 +113,7 @@ class BaseCommentsTest < ApplicationSystemTestCase find('.thread-comment-form, .thread-comment') end expected_url = current_url + "#comment_#{comments(:comment1).id}" - click_and_verify_clipboard_copy('.thread-comment__created-at', expected_url, use_first: true) + click_and_verify_clipboard_copy("#comment_#{comments(:comment1).id} .thread-comment__created-at", expected_url) end test 'clear preview after posting new comment for report' do diff --git a/test/system/comment/corporate_training_inquiry_comments_test.rb b/test/system/comment/corporate_training_inquiry_comments_test.rb index a0f95e58fb2..46e87d9b86c 100644 --- a/test/system/comment/corporate_training_inquiry_comments_test.rb +++ b/test/system/comment/corporate_training_inquiry_comments_test.rb @@ -131,18 +131,7 @@ class CorporateTrainingInquiryCommentsTest < ApplicationSystemTestCase button = find('#js-shortcut-post-comment', text: 'コメントする') button.click - # Try to click again - should be intercepted or disabled - prevented = false - begin - button.click - # If we reach here, the button was clickable twice (bad) - flunk 'Button should be disabled after first click' - rescue Selenium::WebDriver::Error::ElementClickInterceptedError, Selenium::WebDriver::Error::ElementNotInteractableError - # This is expected - button should be disabled/not clickable - prevented = true - end - - assert prevented, 'Button should be disabled after first click to prevent double submission' + assert_selector '#js-shortcut-post-comment[disabled]' end test 'comment url is copied when click its updated_time at corporate_training_inquiry' do diff --git a/test/system/comment/inquiry_comments_test.rb b/test/system/comment/inquiry_comments_test.rb index dd432c62a66..b31dfc00d8c 100644 --- a/test/system/comment/inquiry_comments_test.rb +++ b/test/system/comment/inquiry_comments_test.rb @@ -131,17 +131,7 @@ class InquiryCommentsTest < ApplicationSystemTestCase button = find('#js-shortcut-post-comment', text: 'コメントする') button.click - # Verify the button becomes disabled or not interactable - prevented = false - begin - button.click - # If we reach here, the button was clickable twice (bad) - rescue Selenium::WebDriver::Error::ElementClickInterceptedError, Selenium::WebDriver::Error::ElementNotInteractableError - # This is expected - button should be disabled/not clickable - prevented = true - end - - assert prevented, 'Button should be disabled after first click to prevent double submission' + assert_selector '#js-shortcut-post-comment[disabled]' end test 'comment url is copied when click its updated_time at inquiry' do diff --git a/test/system/comment/mention_and_interaction_test.rb b/test/system/comment/mention_and_interaction_test.rb index 55eb45e86a7..2c271821b7f 100644 --- a/test/system/comment/mention_and_interaction_test.rb +++ b/test/system/comment/mention_and_interaction_test.rb @@ -14,7 +14,7 @@ class MentionAndInteractionTest < ApplicationSystemTestCase end # Type @ to trigger mention suggestion - find('#js-new-comment').set('@') + find('#js-new-comment').send_keys('@') # Wait for mention suggestion to appear using Capybara's built-in wait assert_selector 'span.mention', text: 'mentor', wait: 10 diff --git a/test/system/comment/product_comments_test.rb b/test/system/comment/product_comments_test.rb index 75070be63a1..ffa27919b57 100644 --- a/test/system/comment/product_comments_test.rb +++ b/test/system/comment/product_comments_test.rb @@ -8,8 +8,9 @@ class ProductCommentsTest < ApplicationSystemTestCase within('.thread-comment-form__form') do fill_in('new_comment[description]', with: 'test') end - click_button 'コメントする' - accept_alert '提出物の担当になりました。' + accept_alert '提出物の担当になりました。' do + click_button 'コメントする' + end assert_text 'test' assert_text 'Watch中' end diff --git a/test/system/current_user/address_test.rb b/test/system/current_user/address_test.rb index dda86d8635f..3bb0ba3dcd7 100644 --- a/test/system/current_user/address_test.rb +++ b/test/system/current_user/address_test.rb @@ -4,21 +4,6 @@ module CurrentUser class AddressTest < ApplicationSystemTestCase - test 'display country and subdivision select box' do - visit_with_auth '/current_user/edit', 'komagata' - assert has_checked_field? 'register_address_no', visible: false - assert_not has_css? '#country-form' - assert_not has_css? '#subdivision-form' - - find('label[for=register_address_yes]').click - assert has_css? '#country-form' - assert_select 'user[country_code]', selected: '日本' - assert has_css? '#subdivision-form' - within('#subdivision-select') do - assert_text '北海道' - end - end - test 'do not register country and subdivision' do user = users(:kimura) assert_equal 'JP', user.country_code diff --git a/test/system/current_user/tags_test.rb b/test/system/current_user/tags_test.rb index 222ff0d0b6a..697526f2dab 100644 --- a/test/system/current_user/tags_test.rb +++ b/test/system/current_user/tags_test.rb @@ -5,12 +5,8 @@ class CurrentUser::TagsTest < ApplicationSystemTestCase test 'update user tags' do visit_with_auth '/current_user/edit', 'komagata' - tag_input = find '.tagify__input' - tag_input.set '' - tag_input.set 'タグ1' - tag_input.native.send_keys :enter + fill_in_tag 'タグ1' assert_text 'タグ1' - find_all('.tagify__tag').map(&:text) click_on '更新する' assert_text 'タグ1' diff --git a/test/system/current_user/watches_test.rb b/test/system/current_user/watches_test.rb index d4bc3bad0d6..714d4a08496 100644 --- a/test/system/current_user/watches_test.rb +++ b/test/system/current_user/watches_test.rb @@ -22,7 +22,7 @@ class CurrentUser::WatchesTest < ApplicationSystemTestCase test 'watch index checkbox test' do visit_with_auth '/current_user/watches', 'kimura' assert_no_selector '.card-list-item__option' - find(:css, '#spec-edit-mode').set(true) + find('#spec-edit-mode').click assert_selector '.card-list-item__option' end @@ -32,7 +32,7 @@ class CurrentUser::WatchesTest < ApplicationSystemTestCase assert_text 'Watch中' visit '/current_user/watches' assert_text '作業週1日目' - find(:css, '#spec-edit-mode').set(true) + find('#spec-edit-mode').click assert_selector '.card-list-item__option' first('.a-watch-button').click assert_no_text '作業週1日目' diff --git a/test/system/doorkeeper_application_test.rb b/test/system/doorkeeper_application_test.rb index f960844821a..8ecd02c1899 100644 --- a/test/system/doorkeeper_application_test.rb +++ b/test/system/doorkeeper_application_test.rb @@ -47,8 +47,9 @@ class DoorkeeperApplicationTest < ApplicationSystemTestCase test 'delete an application' do visit "/oauth/applications/#{Doorkeeper::Application.last.id}" - click_on '削除' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '削除' + end assert_text 'アプリケーションを削除しました。' end diff --git a/test/system/hibernation/regular_event_test.rb b/test/system/hibernation/regular_event_test.rb index e022295f29d..af2d9fb627a 100644 --- a/test/system/hibernation/regular_event_test.rb +++ b/test/system/hibernation/regular_event_test.rb @@ -13,8 +13,9 @@ class HibernationRegularEventTest < ApplicationSystemTestCase fill_in('hibernation[reason]', with: 'test') end find('.check-box-to-read').click - click_on '休会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '休会する' + end assert_text '休会手続きが完了しました' regular_event = regular_events(:regular_event1) @@ -32,8 +33,9 @@ class HibernationRegularEventTest < ApplicationSystemTestCase fill_in('hibernation[reason]', with: 'test') end find('.check-box-to-read').click - click_on '休会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '休会する' + end assert_text '休会手続きが完了しました' regular_event = regular_events(:regular_event4) @@ -51,8 +53,9 @@ class HibernationRegularEventTest < ApplicationSystemTestCase fill_in('hibernation[reason]', with: 'test') end find('.check-box-to-read').click - click_on '休会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '休会する' + end assert_text '休会手続きが完了しました' regular_event = regular_events(:regular_event4) diff --git a/test/system/hibernation_test.rb b/test/system/hibernation_test.rb index 44ccfc24334..63f204ce0f6 100644 --- a/test/system/hibernation_test.rb +++ b/test/system/hibernation_test.rb @@ -20,8 +20,9 @@ class HibernationTest < ApplicationSystemTestCase VCR.use_cassette 'subscription/update', vcr_options do find('.check-box-to-read').click - click_on '休会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '休会する' + end assert_text '休会手続きが完了しました' end end @@ -33,8 +34,9 @@ class HibernationTest < ApplicationSystemTestCase end find('.check-box-to-read').click - click_on '休会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '休会する' + end assert_text '復帰予定日を入力してください' end end diff --git a/test/system/home/bookmark_test.rb b/test/system/home/bookmark_test.rb index b5ffa0e1382..dc5e0b24b40 100644 --- a/test/system/home/bookmark_test.rb +++ b/test/system/home/bookmark_test.rb @@ -48,7 +48,7 @@ class BookmarkTest < ApplicationSystemTestCase assert_text 'Bookmarkしました！' visit '/' - first('.spec-bookmark-edit').click + find('#spec-edit-mode').click first('.js-bookmark-delete-button').click assert_text 'ブックマークを削除しました。' assert_no_text '名前の長いメンター用' diff --git a/test/system/home/events_test.rb b/test/system/home/events_test.rb index f0aa756b373..9a207965453 100644 --- a/test/system/home/events_test.rb +++ b/test/system/home/events_test.rb @@ -19,7 +19,7 @@ class EventsTest < ApplicationSystemTestCase end end - test 'show all regular events and special events on dashbord' do + test 'show upcoming regular and special events in upcoming events section' do travel_to Time.zone.local(2017, 4, 3, 8, 0, 0) do visit_with_auth '/', 'kimura' today_event_label = find('.card-list__label', text: '今日開催') @@ -51,6 +51,22 @@ class EventsTest < ApplicationSystemTestCase end end + test 'should not show wip regular and special events in upcoming events section' do + travel_to Time.zone.local(2024, 12, 1, 0, 0, 0) do + wip_regular_event = regular_events(:regular_event42) + wip_special_event = events(:event37) + regular_event = regular_events(:regular_event37) + special_event = events(:event35) + visit_with_auth '/', 'kimura' + within(:xpath, "//div[contains(@class, 'card-list__items')][.//text()='今日開催']") do + assert_no_text wip_regular_event.title + assert_no_text wip_special_event.title + assert_text regular_event.title + assert_text special_event.title + end + end + end + test 'show registered to participate only participating events' do Event.where.not(title: ['kimura専用イベント', '直近イベントの表示テスト用(当日)']).destroy_all RegularEvent.where.not(title: ['ダッシュボード表示確認用テスト定期イベント', '質問・雑談タイム']).destroy_all diff --git a/test/system/markdown_test.rb b/test/system/markdown_test.rb index 76430a7aa5c..76c1abacbac 100644 --- a/test/system/markdown_test.rb +++ b/test/system/markdown_test.rb @@ -139,4 +139,41 @@ class MarkdownTest < ApplicationSystemTestCase assert_selector '.a-link-card__title' assert_no_selector '.embed-error' end + + test 'When you press Ctrl + i in the report, it will type the user icon.' do + reset_avatar(users(:komagata)) + + visit_with_auth new_report_path, 'komagata' + within('form[name=report]') do + fill_in('report[title]', with: '日報でCtrl + i キーを押すと、:@自分: を入力される。') + + find('#report_description').send_keys([cmd_ctrl, 'i']) + + fill_in('report[reported_on]', with: Time.current) + + check '学習時間は無し', allow_label_click: true + end + + click_button '提出' + assert_selector 'a.a-user-emoji-link' + assert_no_selector '.embed-error' + end + + test 'When you press Ctrl + i in the comments, it will type the user icon.' do + reset_avatar(users(:komagata)) + + visit_with_auth "/reports/#{reports(:report1).id}", 'komagata' + # テストが落ちやすいため、setCheckableが実行されるまで待つ + within('.page-content-header') do + find('.stamp.stamp-approve') + end + + within('.thread-comment-form__form') do + find('#js-new-comment').send_keys([cmd_ctrl, 'i']) + end + find('.a-form-tabs__tab.js-tabs__tab', text: 'プレビュー').click + assert_selector 'a.a-user-emoji-link' + click_button 'コメントする' + assert_selector 'a.a-user-emoji-link' + end end diff --git a/test/system/mentor/buzzes_test.rb b/test/system/mentor/buzzes_test.rb new file mode 100644 index 00000000000..dd88ef1d8fa --- /dev/null +++ b/test/system/mentor/buzzes_test.rb @@ -0,0 +1,98 @@ +# frozen_string_literal: true + +require 'application_system_test_case' +require 'test_helper' + +class Mentor::BuzzesTest < ApplicationSystemTestCase + test 'show listing buzzes' do + visit_with_auth mentor_buzzes_path, 'machida' + assert_equal '紹介・言及記事 | FBC', title + end + + test 'buzzes are listed in descending order of published_at' do + visit_with_auth mentor_buzzes_path, 'machida' + buzz_titles = all('.admin-table__item').map { |row| row.find('td:first-child a').text } + expected_order = %w[2025-12-31の記事 2025-02-01の記事 2025-01-31の記事 2025-01-01の記事 2024-12-31の記事] + assert_equal expected_order, buzz_titles + end + + test 'displays title and published date extracted when url submitted' do + dummy_response = <<~BODY +
2025-09-10の記事 + + BODY + stub_request(:get, 'https://www.example.com') + .to_return(status: 200, body: dummy_response) + visit_with_auth new_mentor_buzz_path, 'machida' + within 'form[name=buzz]' do + fill_in 'buzz[url]', with: 'https://www.example.com' + click_button '登録する' + end + assert_text '2025-09-10の記事' + assert_text '2025-09-10' + end + + test 'displays error when no url submitted' do + visit_with_auth new_mentor_buzz_path, 'machida' + within 'form[name=buzz]' do + fill_in 'buzz[title]', with: '2025-09-10の記事' + fill_in 'buzz[published_at]', with: Date.new(2025, 9, 10) + click_button '登録する' + end + assert_text 'Urlを入力してください' + end + + test 'url field is not shown in buzz edit form' do + buzz = buzzes(:buzz1) + visit_with_auth edit_mentor_buzz_path(buzz.id), 'machida' + within 'form[name=buzz]' do + assert_no_selector 'input[name="buzz[url]"]' + end + end + + test 'user can change title and published date when creating buzz' do + dummy_response = <<~BODY +2025-09-10の記事 + + BODY + stub_request(:get, 'https://www.example.com') + .to_return(status: 200, body: dummy_response) + visit_with_auth new_mentor_buzz_path, 'machida' + within 'form[name=buzz]' do + fill_in 'buzz[title]', with: '最新の記事' + fill_in 'buzz[url]', with: 'https://www.example.com' + fill_in 'buzz[published_at]', with: Date.new(2025, 10, 1) + click_button '登録する' + end + assert_text '最新の記事' + assert_text '2025年10月01日' + assert_no_text '2025-09-10の記事' + assert_no_text '2025年09月10日' + end + + test 'user can update title memo and published date' do + buzz = buzzes(:buzz2) + visit_with_auth edit_mentor_buzz_path(buzz.id), 'machida' + within 'form[name=buzz]' do + fill_in 'buzz[title]', with: '編集後のBuzz' + fill_in 'buzz[memo]', with: '編集しました' + fill_in 'buzz[published_at]', with: Date.new(2025, 9, 11) + click_button '更新する' + end + assert_text '編集後のBuzz' + assert_text '編集しました' + assert_text '2025年09月11日' + assert_no_text '2025-01-15の記事' + assert_no_text 'buzz2です' + assert_no_text '2025年01月15日' + end + + test 'user can destroy buzz' do + buzz = buzzes(:buzz1) + visit_with_auth edit_mentor_buzz_path(buzz.id), 'machida' + accept_confirm do + click_button '削除する' + end + assert_no_text '2025-12-31の記事' + end +end diff --git a/test/system/mentor/categories_test.rb b/test/system/mentor/categories_test.rb index cf44f1a6be8..565c041c240 100644 --- a/test/system/mentor/categories_test.rb +++ b/test/system/mentor/categories_test.rb @@ -75,8 +75,9 @@ class Mentor::CategoriesTest < ApplicationSystemTestCase test 'delete category' do visit_with_auth "/mentor/categories/#{categories(:category1).id}/edit", 'mentormentaro' - click_on '削除' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '削除' + end assert_text 'カテゴリーを削除しました。' assert_no_text '学習の準備' end diff --git a/test/system/mentor/course/categories_test.rb b/test/system/mentor/course/categories_test.rb index 319a5c85c35..2586e2ea32d 100644 --- a/test/system/mentor/course/categories_test.rb +++ b/test/system/mentor/course/categories_test.rb @@ -11,7 +11,7 @@ class Mentor::Courses::CategoriesTest < ApplicationSystemTestCase visit_with_auth mentor_course_categories_path(courses(:course1)), 'komagata' source = all('.js-grab')[1] # category2 target = all('.js-grab')[3] # category4 - source.drag_to(target) + move_category_to(source, target) visit_with_auth course_practices_path(courses(:course1)), 'kimura' assert_equal all('h2.categories-item__title')[0].text, categories(:category4).name @@ -26,10 +26,36 @@ class Mentor::Courses::CategoriesTest < ApplicationSystemTestCase visit_with_auth mentor_course_categories_path(courses(:course1)), 'komagata' source = all('.js-grab')[12] # category13 target = all('.js-grab')[14] # category15 - source.drag_to(target) + move_category_to(source, target) visit_with_auth course_practices_path(courses(:course3)), 'kimura' assert_equal all('h2.categories-item__title')[0].text, categories(:category13).name assert_equal all('h2.categories-item__title')[1].text, categories(:category15).name end + + private + + def move_category_to(source, target) + result = page.evaluate_async_script(<<~JS, source, target) + const done = arguments[arguments.length - 1] + const source = arguments[0].closest('[data-courses_category_id]') + const target = arguments[1].closest('[data-courses_category_id]') + const items = [...document.querySelectorAll('[data-courses_category_id]')] + + fetch(`/api/courses_categories/${source.dataset.courses_category_id}/position.json`, { + method: 'PATCH', + headers: { + 'Content-Type': 'application/json' + }, + body: JSON.stringify({ insert_at: items.indexOf(target) + 1 }) + }).then((response) => { + if (response.ok) { + done() + } else { + done({ error: `PATCH failed: ${response.status}` }) + } + }).catch((error) => done({ error: error.message })) + JS + raise result['error'] if result&.dig('error') + end end diff --git a/test/system/mentor/practices_test.rb b/test/system/mentor/practices_test.rb index 7467e5076b2..18ad108993c 100644 --- a/test/system/mentor/practices_test.rb +++ b/test/system/mentor/practices_test.rb @@ -57,9 +57,11 @@ class Mentor::PracticesTest < ApplicationSystemTestCase test 'student cannot delete practice' do practice = practices(:practice7) - visit_with_auth "/practices/#{practice.id}", 'kimura' - assert_text practice.title - assert_no_link '削除する' + Capybara.using_driver(:rack_test) do + visit_with_auth "/practices/#{practice.id}", 'kimura' + assert_text practice.title + assert_no_link '削除する' + end end end diff --git a/test/system/mentor/survey_questions_test.rb b/test/system/mentor/survey_questions_test.rb index 911dcd613cb..c02128bc4c2 100644 --- a/test/system/mentor/survey_questions_test.rb +++ b/test/system/mentor/survey_questions_test.rb @@ -68,26 +68,30 @@ class Mentor::SurveyQuestionsTest < ApplicationSystemTestCase end test 'display a list of questions' do + survey_question = survey_questions(:survey_question1) + visit_with_auth '/mentor/survey_questions', 'komagata' assert_text '段落' assert_text 'フィヨルドブートキャンプの学習を通して、どんなことを学びましたか？' - assert_text "作成: #{I18n.l(Time.current, format: :long)}" - assert_text "更新: #{I18n.l(Time.current, format: :long)}" + assert_text "作成: #{I18n.l(survey_question.created_at, format: :long)}" + assert_text "更新: #{I18n.l(survey_question.updated_at, format: :long)}" end test 'edit question' do + survey_question = survey_questions(:survey_question1) + visit_with_auth '/mentor/survey_questions', 'komagata' assert_text '段落' assert_text 'フィヨルドブートキャンプの学習を通して、どんなことを学びましたか？' - assert_text "作成: #{I18n.l(Time.current, format: :long)}" - assert_text "更新: #{I18n.l(Time.current, format: :long)}" + assert_text "作成: #{I18n.l(survey_question.created_at, format: :long)}" + assert_text "更新: #{I18n.l(survey_question.updated_at, format: :long)}" first('#edit_icon').click fill_in 'survey_question[title]', with: '一番辛かったプラクティスは何ですか？' choose '記述式', allow_label_click: true click_button '保存' assert_text '記述式' assert_text '一番辛かったプラクティスは何ですか？' - assert_text "作成: #{I18n.l(Time.current, format: :long)}" - assert_text "更新: #{I18n.l(Time.current, format: :long)}" + assert_text "作成: #{I18n.l(survey_question.reload.created_at, format: :long)}" + assert_text "更新: #{I18n.l(survey_question.updated_at, format: :long)}" end end diff --git a/test/system/mentor/surveys_test.rb b/test/system/mentor/surveys_test.rb index 6710d0cb956..ac30c8f49b7 100644 --- a/test/system/mentor/surveys_test.rb +++ b/test/system/mentor/surveys_test.rb @@ -18,20 +18,20 @@ class Mentor::SurveysTest < ApplicationSystemTestCase visit_with_auth "/mentor/surveys/#{surveys(:survey1).id}", 'komagata' assert_selector 'h1', text: '【第1回】FBCモチベーションに関するアンケート' required_answer_checkbox = find('.survey-questions-item__checkboxes').all('.checkboxes__item')[4] - required_answer_checkbox.select_option + required_answer_checkbox.click assert_text '「その他」と回答された方は、内容をお聞かせください。' - required_answer_checkbox.select_option + required_answer_checkbox.click assert_no_text '「その他」と回答された方は、内容をお聞かせください。' required_answer_radio_button = find('.survey-questions-item__radios').all('.radios__item')[4] - required_answer_radio_button.select_option + required_answer_radio_button.click assert_text '「その他」と回答された方は、内容をお聞かせください。' normal_radio_button = find('.survey-questions-item__radios').all('.radios__item')[0] - normal_radio_button.select_option + normal_radio_button.click assert_no_text '「その他」と回答された方は、内容をお聞かせください。' required_answer_linear_scale = find('.linear-scale__points-items').first('.linear-scale__points-item') - required_answer_linear_scale.select_option + required_answer_linear_scale.click assert_text 'そのように回答された理由を教えてください。' end diff --git a/test/system/mentor_mode_test.rb b/test/system/mentor_mode_test.rb index 5bcfdd74a8b..7d5d0cad795 100644 --- a/test/system/mentor_mode_test.rb +++ b/test/system/mentor_mode_test.rb @@ -6,21 +6,21 @@ class MentorModeTest < ApplicationSystemTestCase test 'show/hide mentor-user-memo to the user_profile' do visit_with_auth user_path(users(:hatsuno)), 'komagata' assert_text 'ユーザーメモ' - find(:css, '#checkbox-mentor-mode').set(false) + page.execute_script("document.querySelector('#checkbox-mentor-mode').click()") assert_no_text 'ユーザーメモ' end test 'show/hide mentor-user-memo to the report' do visit_with_auth report_path(reports(:report10)), 'komagata' assert_text 'ユーザーメモ' - find(:css, '#checkbox-mentor-mode').set(false) + page.execute_script("document.querySelector('#checkbox-mentor-mode').click()") assert_no_text 'ユーザーメモ' end test 'show/hide retire_reason' do visit_with_auth user_path(users(:yameo)), 'komagata' assert_text '内容が難しかった' - find(:css, '#checkbox-mentor-mode').set(false) + page.execute_script("document.querySelector('#checkbox-mentor-mode').click()") assert_no_text '内容が難しかった' end diff --git a/test/system/movie/tags_test.rb b/test/system/movie/tags_test.rb index dd30e9d97b4..91e4f346aeb 100644 --- a/test/system/movie/tags_test.rb +++ b/test/system/movie/tags_test.rb @@ -40,7 +40,7 @@ class Movie::TagsTest < ApplicationSystemTestCase visit_with_auth movies_tag_path(old_tag.name, all: 'true'), 'komagata' click_tag_name_change - fill_in('tag[name]', with: new_tag_name) + fill_in_open_tag_modal new_tag_name click_save_tag_name_change assert_text "タグ「#{new_tag_name}」の動画（1）" @@ -53,7 +53,7 @@ class Movie::TagsTest < ApplicationSystemTestCase visit_with_auth movies_tag_path(existing_tag.name, all: 'true'), 'komagata' click_tag_name_change - fill_in 'tag[name]', with: new_tag.name + fill_in_open_tag_modal new_tag.name click_save_tag_name_change assert_text "タグ「#{new_tag.name}」の動画（2）" diff --git a/test/system/notification/pair_works_test.rb b/test/system/notification/pair_works_test.rb index 8c70511524d..db35abf9c7d 100644 --- a/test/system/notification/pair_works_test.rb +++ b/test/system/notification/pair_works_test.rb @@ -87,4 +87,80 @@ class Notification::PairWorksTest < NotificationSystemTestCase assert_user_has_notification(user: users(:mentormentaro), kind: Notification.kinds[:came_pair_work], text: '公開された時に通知が飛ぶ') end end + + test 'pair work creator receive notification when pair rematched' do + travel_to Time.zone.local(2025, 1, 1, 0, 0, 0) do + visit_with_auth pair_works_path(target: 'solved'), 'mentormentaro' + click_on 'ペア確定済みのペアワークです(タイトル)' + assert_text 'ペア確定' + find("label[for='show-schedule-dates']").click + within '.a-table' do + accept_alert do + find_button(id: '2025-01-02T01:00:00+09:00').click + end + end + assert_text '予約内容を変更しました。' + + assert_user_has_notification(user: users(:kimura), kind: Notification.kinds[:rematching_pair_work], + text: 'ペアワーク「ペア確定済みのペアワークです(タイトル)」のペアがmentormentaroに変更されました。') + assert_user_has_notification(user: users(:sotugyou), kind: Notification.kinds[:rematching_pair_work], + text: 'ペアワーク「ペア確定済みのペアワークです(タイトル)」のペアがmentormentaroに変更されました。') + end + end + + test 'pair work creator receive notification when pair work is rescheduled' do + travel_to Time.zone.local(2025, 1, 1, 0, 0, 0) do + visit_with_auth pair_works_path(target: 'solved'), 'komagata' + click_on '日程変更動作確認用のペアワークです。' + assert_text 'ペア確定' + find("label[for='show-schedule-dates']").click + within '.a-table' do + accept_alert do + find_button(id: '2025-01-03T01:00:00+09:00').click + end + end + assert_text '予約内容を変更しました。' + assert_user_has_notification(user: users(:kimura), kind: Notification.kinds[:reschedule_pair_work], + text: 'ペアワーク「日程変更動作確認用のペアワークです。」の日程が2025年01月03日(金) 01:00に変更されました。') + end + end + + test 'watcher receive notification when pair confirmation is canceled' do + travel_to Time.zone.local(2025, 3, 2, 0, 0, 0) do + visit_with_auth '/pair_works/new', 'kimura' + within 'form[name=pair_work]' do + fill_in 'pair_work[title]', with: '削除通知確認用のペアワーク募集' + fill_in 'pair_work[description]', with: '削除通知確認用のペアワーク募集です。' + within '.form-table' do + check 'schedule_ids_202503030000', allow_label_click: true + end + end + click_button '登録する' + assert_text 'ペアワークを作成しました。' + assert_text 'Watch中' + logout + + visit_with_auth pair_works_path(target: 'not_solved'), 'mentormentaro' + click_on '削除通知確認用のペアワーク募集' + assert_text 'Watch中' + within '.a-table' do + accept_alert do + find_button(id: '2025-03-03T00:00:00+09:00').click + end + end + assert_text 'ペアが確定しました。' + + visit_with_auth pair_works_path(target: 'solved'), 'mentormentaro' + click_on '削除通知確認用のペアワーク募集' + find("label[for='show-schedule-dates']").click + accept_alert do + click_button 'ペア確定を取り消す' + end + + assert_text 'ペア確定を取り消しました' + + assert_user_has_notification(user: users(:kimura), kind: Notification.kinds[:cancel_pair_work], text: 'ペアワーク「削除通知確認用のペアワーク募集」のペア確定が取り消されました。') + assert_user_has_notification(user: users(:komagata), kind: Notification.kinds[:cancel_pair_work], text: 'ペアワーク「削除通知確認用のペアワーク募集」のペア確定が取り消されました。') + end + end end diff --git a/test/system/notification/regular_events_test.rb b/test/system/notification/regular_events_test.rb index cb3fa074a68..f61b9b305f1 100644 --- a/test/system/notification/regular_events_test.rb +++ b/test/system/notification/regular_events_test.rb @@ -38,7 +38,8 @@ class Notification::RegularEventsTest < NotificationSystemTestCase body['content'].include?('Discord通知確認用イベント(土曜日午前8時から開催)') && body['content'].include?('Discord通知確認用イベント(土曜日 + 日曜日開催)') && body['content'].include?('Discord通知確認用イベント(土曜日開催)') && - body['content'].include?('Discord通知確認用、祝日非開催イベント(金曜日 + 土曜日開催)') + body['content'].include?('Discord通知確認用、祝日非開催イベント(金曜日 + 土曜日開催)') && + body['content'].exclude?('Discord通知が来ないwipイベント(土曜日開催)') end travel_to Time.zone.local(2023, 5, 5, 6, 0, 0) do diff --git a/test/system/notification/reports_test.rb b/test/system/notification/reports_test.rb index 697d58a17dc..036ee02d3ec 100644 --- a/test/system/notification/reports_test.rb +++ b/test/system/notification/reports_test.rb @@ -13,17 +13,6 @@ class Notification::ReportsTest < NotificationSystemTestCase AbstractNotifier.delivery_mode = @delivery_mode end - test 'the first daily report notification is sent only to mentors' do - create_report_as('muryou', '初日報です', '初日報の内容です', save_as_wip: false) - - notification_message = 'muryouさんがはじめての日報を書きました！' - - assert_user_has_notification(user: users(:machida), kind: Notification.kinds[:first_report], text: notification_message) - assert_user_has_no_notification(user: users(:kimura), kind: Notification.kinds[:first_report], text: notification_message) - assert_user_has_no_notification(user: users(:advijirou), kind: Notification.kinds[:first_report], text: notification_message) - assert_user_has_no_notification(user: users(:sotugyou), kind: Notification.kinds[:first_report], text: notification_message) - end - test 'notify when WIP report submitted' do Report.all.find_each(&:destroy) @@ -121,103 +110,6 @@ class Notification::ReportsTest < NotificationSystemTestCase logout end - def assert_notify_only_when_report_is_initially_posted( - notification_message, - author_login_name, - received_user_login_name, - title, - description - ) - report_id = create_report_as(author_login_name, title, description, save_as_wip: true) - - # 日報を WIP -> 提出 -> 内容変更 の流れで作成・更新し通知の有無を確認する - visit_with_auth notifications_path(status: 'unread'), received_user_login_name - assert_no_selector(notification_selector, - text: notification_message) - logout - - update_report_as_author(report_id, title, description, save_as_wip: false) - visit_with_auth notifications_path(status: 'unread'), received_user_login_name - assert_selector(notification_selector, - text: notification_message) - click_link(notification_message) - assert_equal current_path, report_path(report_id) - logout - - update_report_as_author(report_id, title, description, save_as_wip: false) - visit_with_auth notifications_path(status: 'unread'), received_user_login_name - assert_no_selector(notification_selector, - text: notification_message) - logout - end - - test 'notify company advisor only when report is initially posted' do - kensyu_login_name = 'kensyu' - advisor_login_name = 'senpai' - title = '研修生が日報を作成し提出した時' - description = 'アドバイザーに通知を飛ばす' - notification_message = make_write_report_notification_message( - kensyu_login_name, title - ) - - assert_notify_only_when_report_is_initially_posted( - notification_message, - kensyu_login_name, - advisor_login_name, - title, - description - ) - end - - test 'notify follower only when report is initially posted' do - # Use non-trainee user to avoid edit restrictions - following = Following.find_by(follower: users(:kensyu), followed: users(:muryou)) - followed_user_login_name = User.find(following.followed_id).login_name - follower_user_login_name = User.find(following.follower_id).login_name - title = '初めて提出した時だけ' - description = 'フォローされているユーザーに通知を飛ばす' - notification_message = make_write_report_notification_message( - followed_user_login_name, title - ) - - assert_notify_only_when_report_is_initially_posted( - notification_message, - followed_user_login_name, - follower_user_login_name, - title, - description - ) - end - - test 'notify mention target only when report is initially posted' do - mention_target_login_name = 'kimura' - author_login_name = 'machida' - title = '初めて提出したら、' - description = "@#{mention_target_login_name} に通知する" - - assert_notify_only_when_report_is_initially_posted( - make_mention_notification_message(author_login_name), - author_login_name, - mention_target_login_name, - title, - description - ) - end - - test 'notify user only when first report is initially posted' do - check_notification_login_name = 'machida' - author_login_name = 'nippounashi' - title = '初めての日報を提出したら' - description = 'ユーザーに通知をする' - assert_notify_only_when_report_is_initially_posted( - "#{author_login_name}さんがはじめての日報を書きました！", - author_login_name, - check_notification_login_name, - title, - description - ) - end - test 'notify to mentors when a student submitted reports with negative icon at twice in a row' do student = 'kimura' mentor = 'mentormentaro' diff --git a/test/system/notification/retirement_test.rb b/test/system/notification/retirement_test.rb index d5ab097a007..a74fc72f0af 100644 --- a/test/system/notification/retirement_test.rb +++ b/test/system/notification/retirement_test.rb @@ -8,8 +8,9 @@ class Notification::RetirementTest < NotificationSystemTestCase visit_with_auth new_retirement_path, 'kimura' find('label', text: 'とても良い').click - click_on '退会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' assert_user_has_notification(user: users(:komagata), kind: Notification.kinds[:retired], text: 'kimuraさんが退会しました。') diff --git a/test/system/notification/talk_test.rb b/test/system/notification/talk_test.rb index 953d9e2999c..50d2c603bc4 100644 --- a/test/system/notification/talk_test.rb +++ b/test/system/notification/talk_test.rb @@ -72,7 +72,7 @@ class Notification::TalkTest < NotificationSystemTestCase visit '/talks/action_uncompleted' assert_text '未対応の相談部屋はありません' within(:css, '.global-nav') do - within(:css, "a[href='/talks/action_uncompleted'") do + within(:css, "a[href='/talks/action_uncompleted']") do assert_no_selector '.global-nav__item-count.a-notification-count.is-only-mentor' end end @@ -84,7 +84,7 @@ class Notification::TalkTest < NotificationSystemTestCase visit_with_auth root_path, 'mentormentaro' assert_selector '.page-header__title', text: 'ダッシュボード' within(:css, '.global-nav') do - within(:css, "a[href='/talks/#{user.talk.id}#latest-comment'") do + within(:css, "a[href='/talks/#{user.talk.id}#latest-comment']") do assert_no_selector '.global-nav__item-count.a-notification-count.is-only-mentor' end end @@ -95,7 +95,7 @@ class Notification::TalkTest < NotificationSystemTestCase visit_with_auth root_path, 'advijirou' assert_selector '.page-header__title', text: 'ダッシュボード' within(:css, '.global-nav') do - within(:css, "a[href='/talks/#{user.talk.id}#latest-comment'") do + within(:css, "a[href='/talks/#{user.talk.id}#latest-comment']") do assert_no_selector '.global-nav__item-count.a-notification-count.is-only-mentor' end end @@ -106,7 +106,7 @@ class Notification::TalkTest < NotificationSystemTestCase visit_with_auth root_path, 'kimura' assert_selector '.page-header__title', text: 'ダッシュボード' within(:css, '.global-nav') do - within(:css, "a[href='/talks/#{user.talk.id}#latest-comment'") do + within(:css, "a[href='/talks/#{user.talk.id}#latest-comment']") do assert_no_selector '.global-nav__item-count.a-notification-count.is-only-mentor' end end diff --git a/test/system/page/tags_test.rb b/test/system/page/tags_test.rb index fffd2814b3f..f61d9cd883d 100644 --- a/test/system/page/tags_test.rb +++ b/test/system/page/tags_test.rb @@ -13,15 +13,6 @@ class Page::TagsTest < ApplicationSystemTestCase end end - test 'update tags without page transitions' do - visit_with_auth "/pages/#{pages(:page1).id}", 'kimura' - find('.tag-links__item-edit').click - fill_in_tag '追加タグ' - click_on '保存' - assert_equal Page.tagged_with('追加タグ').pluck(:title), - all('.card-list-item-title__link').map(&:text) - end - test 'admin can edit tag' do tag = acts_as_taggable_on_tags('game') assert_admin_can_edit_tag(pages_tag_path(tag.name, all: 'true')) @@ -32,40 +23,14 @@ class Page::TagsTest < ApplicationSystemTestCase assert_non_admin_cannot_edit_tag(pages_tag_path(tag.name, all: 'true')) end - test 'update tag with not existing tag' do - tag = acts_as_taggable_on_tags('beginner') - update_tag_text = '上級者' - - visit_with_auth pages_tag_path(tag.name, all: 'true'), 'komagata' - click_button 'タグ名変更' - fill_in('tag[name]', with: update_tag_text) - click_button '変更' - assert_text 'タグ 「上級者」' - - visit_with_auth questions_tag_path(tag.name, all: 'true'), 'komagata' - assert_text 'Q&Aはありません。' - visit_with_auth questions_tag_path(update_tag_text, all: 'true'), 'komagata' - assert_text "タグ「#{update_tag_text}」のQ&A（1）" - - visit_with_auth users_tag_path(tag.name), 'komagata' - assert_text "#{tag.name}のユーザーはいません" - visit_with_auth users_tag_path(update_tag_text), 'komagata' - assert_text "タグ「#{update_tag_text}」のユーザー（1）" - - visit_with_auth pages_tag_path(tag.name), 'komagata' - has_selector?('card-list-item') - visit_with_auth pages_tag_path(update_tag_text), 'komagata' - has_selector?('card-list-item') - end - test 'update tag with existing tag' do tag = acts_as_taggable_on_tags('beginner') update_tag = acts_as_taggable_on_tags('intermediate') visit_with_auth pages_tag_path(tag.name, all: 'true'), 'komagata' - click_button 'タグ名変更' - fill_in('tag[name]', with: update_tag.name) - click_button '変更' + click_tag_name_change + fill_in_open_tag_modal update_tag.name + click_save_tag_name_change assert_text 'タグ 「中級者」' visit_with_auth questions_tag_path(tag.name, all: 'true'), 'komagata' diff --git a/test/system/pages/user_change_test.rb b/test/system/pages/user_change_test.rb index f0ff3a92331..6cca050da76 100644 --- a/test/system/pages/user_change_test.rb +++ b/test/system/pages/user_change_test.rb @@ -8,9 +8,7 @@ class UserChangeTest < ApplicationSystemTestCase visit_with_auth "/pages/#{pages(:page1).id}/edit", 'komagata' within('.form') do - find('#select2-page_user_id-container').click select('kimura', from: 'page[user_id]') - find('.select-users').click end click_button '内容を更新' diff --git a/test/system/pages/watch_test.rb b/test/system/pages/watch_test.rb index c8eed82b9ab..d2692a71ccf 100644 --- a/test/system/pages/watch_test.rb +++ b/test/system/pages/watch_test.rb @@ -19,6 +19,7 @@ class WatchTest < ApplicationSystemTestCase visit edit_page_path(pages(:page2)) click_button 'WIP' + assert_text 'ドキュメントをWIPとして保存しました。' visit page_path(pages(:page2)) assert_text 'Watch中' end @@ -38,18 +39,18 @@ class WatchTest < ApplicationSystemTestCase visit_with_auth edit_page_path(pages(:page1)), editor within('.form') do - find('#select2-page_user_id-container').click select(author, from: 'page[user_id]') end click_button '内容を更新' + assert_text 'ドキュメントを更新しました' visit edit_page_path(pages(:page2)) within('.form') do - find('#select2-page_user_id-container').click select(author, from: 'page[user_id]') end click_button 'WIP' + assert_text 'ドキュメントをWIPとして保存しました。' logout diff --git a/test/system/pair_works_test.rb b/test/system/pair_works_test.rb index 6221c2b8361..b19641a7a25 100644 --- a/test/system/pair_works_test.rb +++ b/test/system/pair_works_test.rb @@ -95,6 +95,17 @@ class PairWorksTest < ApplicationSystemTestCase assert_selector 'a.a-category-link', text: 'sshdでパスワード認証を禁止にする' end + test 'update a pair_work desired date' do + travel_to Time.zone.local(2025, 1, 1, 0, 0, 0) do + pair_work = pair_works(:pair_work1) + visit_with_auth pair_work_path(pair_work), 'kimura' + click_link '希望日時変更' + find('label[for="schedule_ids_202501020100"]').click + click_button '更新する' + assert_text 'ペアワークを更新しました。' + end + end + test 'delete a pair_work' do pair_work = pair_works(:pair_work1) visit_with_auth pair_work_path(pair_work), 'kimura' @@ -124,4 +135,67 @@ class PairWorksTest < ApplicationSystemTestCase assert_no_text '内容修正' assert_no_text '削除' end + + test 'cancel pair confirmation' do + travel_to Time.zone.local(2025, 1, 1, 0, 0, 0) do + pair_work = pair_works(:pair_work4) + visit_with_auth pair_work_path(pair_work), 'komagata' + find("label[for='show-schedule-dates']").click + accept_confirm do + click_button 'ペア確定を取り消す' + end + + assert_text 'ペア確定を取り消しました' + end + end + + test 'show confirmed date when pair work is reserved' do + travel_to Time.zone.local(2025, 1, 1, 0, 0, 0) do + pair_work = pair_works(:pair_work4) + visit_with_auth pair_work_path(pair_work), 'kimura' + within '.pair-work-schedule-dates__action-item' do + assert_text '開催日時は1月2日(木)01:00に確定しました。' + end + + visit_with_auth pair_work_path(pair_work), 'komagata' + find("label[for='show-schedule-dates']").click + assert_selector "[id='2025-01-02T01:00:00+09:00']", text: '確定' + end + end + + test 'shows ended message when reserved date has passed' do + travel_to Time.zone.local(2025, 1, 2, 1, 0, 0) do + pair_work = pair_works(:pair_work4) + visit_with_auth pair_work_path(pair_work), 'kimura' + assert_selector "[for='show-ended-schedule']", text: 'ペアワークは終了しました。' + + visit_with_auth pair_work_path(pair_work), 'komagata' + assert_selector "[for='show-ended-schedule']", text: 'ペアワークは終了しました。' + end + end + + test 'update pair work reservation' do + travel_to Time.zone.local(2025, 1, 1, 0, 0, 0) do + pair_work = pair_works(:pair_work4) + visit_with_auth pair_work_path(pair_work), 'komagata' + find("label[for='show-schedule-dates']").click + within '.a-table' do + accept_alert do + find_button(id: '2025-01-03T01:00:00+09:00').click + end + end + assert_text '予約内容を変更しました。' + assert_selector '.pair-work-info__datetime', text: '2025年01月03日(金) 01:00' + + visit_with_auth pair_work_path(pair_work), 'mentormentaro' + find("label[for='show-schedule-dates']").click + within '.a-table' do + accept_alert do + find_button(id: '2025-01-02T01:00:00+09:00').click + end + end + assert_text '予約内容を変更しました。' + assert_selector 'a', text: 'mentormentaro (メンタ メンタロウ)' + end + end end diff --git a/test/system/practice/reports_test.rb b/test/system/practice/reports_test.rb index d3d0b38317e..1761da74421 100644 --- a/test/system/practice/reports_test.rb +++ b/test/system/practice/reports_test.rb @@ -9,4 +9,48 @@ class Practice::ReportsTest < ApplicationSystemTestCase assert_selector 'img[alt="positive"]', count: 2 assert_selector '.card-list-item-title__link', text: '1時間だけ学習' end + + test 'grant filter is not present on rails course practice' do + visit_with_auth "/practices/#{practices(:practice65).id}/reports", 'komagata' + + assert_no_selector 'a.pill-nav__item-link', text: '全て' + assert_no_selector 'a.pill-nav__item-link', text: '給付金コース' + end + + test 'grant filter is present on grant course practice' do + visit_with_auth "/practices/#{practices(:practice66).id}/reports", 'komagata' + + assert_selector 'a.pill-nav__item-link', text: '全て' + assert_selector 'a.pill-nav__item-link', text: '給付金コース' + end + + test 'grant filter shows both copied and grant course reports when "全て" is selected' do + visit_with_auth "/practices/#{practices(:practice66).id}/reports", 'komagata' + + assert_selector 'a.pill-nav__item-link.is-active', text: '全て' + assert_selector '.card-list-item-title__link', text: 'Railsコースのコピー元プラクティスの日報' + assert_selector '.card-list-item-title__link', text: '給付金コースのプラクティスの日報' + end + + test 'grant filter shows only grant course reports when "給付金コース" is selected' do + visit_with_auth "/practices/#{practices(:practice66).id}/reports", 'komagata' + within '.pill-nav' do + click_on '給付金コース' + end + + assert_selector 'a.pill-nav__item-link.is-active', text: '給付金コース' + assert_no_selector '.card-list-item-title__link', text: 'Railsコースのコピー元プラクティスの日報' + assert_selector '.card-list-item-title__link', text: '給付金コースのプラクティスの日報' + end + + test 'grant filter shows empty message when no reports exist' do + visit_with_auth "/practices/#{practices(:practice68).id}/reports", 'komagata' + within '.pill-nav' do + click_on '給付金コース' + end + + assert_selector 'a.pill-nav__item-link.is-active', text: '給付金コース' + assert_no_selector '.card-list-item-title__link' + assert_selector '.o-empty-message__text', text: '日報はまだありません。' + end end diff --git a/test/system/practices/mentor_test.rb b/test/system/practices/mentor_test.rb index 8d902903826..4ccbd63208b 100644 --- a/test/system/practices/mentor_test.rb +++ b/test/system/practices/mentor_test.rb @@ -125,7 +125,7 @@ class MentorTest < ApplicationSystemTestCase practice = practices(:practice2) visit_with_auth "/practices/#{practice.id}", 'komagata' assert_text 'メンター向けメモ' - find(:css, '#checkbox-mentor-mode').set(false) + page.execute_script("document.querySelector('#checkbox-mentor-mode').click()") assert_no_text 'メンター向けメモ' end @@ -133,7 +133,7 @@ class MentorTest < ApplicationSystemTestCase practice = practices(:practice2) visit_with_auth "/practices/#{practice.id}", 'komagata' assert_text '管理者・メンター用メニュー' - find(:css, '#checkbox-mentor-mode').set(false) + page.execute_script("document.querySelector('#checkbox-mentor-mode').click()") assert_no_text '管理者・メンター用メニュー' end end diff --git a/test/system/product/checker_test.rb b/test/system/product/checker_test.rb index 98b52193bcc..2343a4d26c0 100644 --- a/test/system/product/checker_test.rb +++ b/test/system/product/checker_test.rb @@ -13,8 +13,9 @@ def assigned_product_count visit "/products/#{products(:product1).id}" - post_comment('担当者がいない提出物の場合、担当者になる') - accept_alert '提出物の担当になりました。' + accept_alert '提出物の担当になりました。' do + post_comment('担当者がいない提出物の場合、担当者になる') + end assert_text '担当になりました。' assert_button '担当から外れる' diff --git a/test/system/product/unchecked_test.rb b/test/system/product/unchecked_test.rb index dd7d20855f9..542a9ff43a7 100644 --- a/test/system/product/unchecked_test.rb +++ b/test/system/product/unchecked_test.rb @@ -112,8 +112,9 @@ class Product::UncheckedTest < ApplicationSystemTestCase product = products(:product8) visit_with_auth "/products/#{product.id}", 'mentormentaro' fill_in('new_comment[description]', with: 'test') - click_button 'コメントする' - accept_alert '提出物の担当になりました。' + accept_alert '提出物の担当になりました。' do + click_button 'コメントする' + end within('.thread-comment.is-latest') do assert_text 'mentormentaro' assert_text 'test' @@ -218,29 +219,4 @@ class Product::UncheckedTest < ApplicationSystemTestCase expected_count = Product.unhibernated_user_products.unchecked.not_wip.count assert_selector '.page-tabs__item-link.is-active', text: "未完了 （#{expected_count}）" end - - test 'unchecked products is excepted hiberanated user' do - hiberanated_user = users(:kyuukai) - practice = practices(:practice47) - - Product.create!( - body: 'hiberanated user product.', - user: hiberanated_user, - practice:, - checker_id: nil - ) - - product_hiberanated_user_name = "#{hiberanated_user.login_name} (#{hiberanated_user.name_kana})" - - visit_with_auth '/products/unchecked', 'komagata' - # assert_no_text だとデータが読み込まれる前に実行され常に成立してしまうため、明示的に待機する has_text? を使用する - assert_not has_text?(product_hiberanated_user_name) - first('.pagination__item-link', text: '2').click - assert_not has_text?(product_hiberanated_user_name) - - visit_with_auth '/products/unchecked?target=unchecked_no_replied', 'komagata' - assert_not has_text?(product_hiberanated_user_name) - first('.pagination__item-link', text: '2').click - assert_not has_text?(product_hiberanated_user_name) - end end diff --git a/test/system/products/checker_test.rb b/test/system/products/checker_test.rb index 4d53949bb7a..e3b0b6a047c 100644 --- a/test/system/products/checker_test.rb +++ b/test/system/products/checker_test.rb @@ -50,8 +50,9 @@ class Products::CheckerTest < ApplicationSystemTestCase product = ensure_valid_product(products(:product1)) visit_with_auth "/products/#{product.id}", 'komagata' wait_for_comment_form - post_comment('コメントしたら担当になるテスト') - accept_alert '提出物の担当になりました。' + accept_alert '提出物の担当になりました。' do + post_comment('コメントしたら担当になるテスト') + end assert_text 'コメントしたら担当になるテスト' visit current_path assert_button '担当から外れる' diff --git a/test/system/products/mentor_test.rb b/test/system/products/mentor_test.rb index 271d15d08e3..6bf573a0666 100644 --- a/test/system/products/mentor_test.rb +++ b/test/system/products/mentor_test.rb @@ -12,6 +12,16 @@ class MentorTest < ApplicationSystemTestCase assert_selector '#side-tabs-nav-4', text: '提出物' end + test 'mentors cannot see review by Pjord button' do + visit_with_auth "/products/#{products(:product2).id}", 'mentormentaro' + assert_no_text 'ピヨルドでレビューコメントをする' + end + + test 'admins can see review by Pjord button' do + visit_with_auth "/products/#{products(:product2).id}", 'adminonly' + assert_text 'ピヨルドでレビューコメントをする' + end + test 'students can not see block for mentors' do visit_with_auth "/products/#{products(:product2).id}", 'hatsuno' assert_no_text '直近の日報' diff --git a/test/system/products/wip_test.rb b/test/system/products/wip_test.rb index 45dc6ca8136..0806476a795 100644 --- a/test/system/products/wip_test.rb +++ b/test/system/products/wip_test.rb @@ -38,14 +38,14 @@ class WipTest < ApplicationSystemTestCase test 'user who has submitted a WIP product is alerted in the product page' do wip_product = products(:product5) visit_with_auth "/products/#{wip_product.id}", 'kimura' - assert_text "提出物はまだ提出されていません。\n完成したら「提出する」をクリック！" + assert_text '提出物はまだ提出されていません。完成したら「提出する」をクリック！' end test "user is not alerted in the other's WIP product page" do wip_product = products(:product5) visit_with_auth "/products/#{wip_product.id}", 'hatsuno' assert_equal "提出物: #{wip_product.practice.title} | FBC", title - assert_no_text "提出物はまだ提出されていません。\n完成したら「提出する」をクリック！" + assert_no_text '提出物はまだ提出されていません。完成したら「提出する」をクリック！' end test "Don't notify if create product as WIP" do diff --git a/test/system/products_test.rb b/test/system/products_test.rb index b80cac2fea9..2cb965f51fb 100644 --- a/test/system/products_test.rb +++ b/test/system/products_test.rb @@ -54,6 +54,15 @@ class ProductsTest < ApplicationSystemTestCase assert_selector '.thread-comment-form' end + test 'show Pjord product review button only to admin' do + product = products(:product1) + visit_with_auth "/products/#{product.id}", 'adminonly' + assert_link 'ピヨルドでレビューコメントをする' + + visit_with_auth "/products/#{product.id}", 'kimura' + assert_no_link 'ピヨルドでレビューコメントをする' + end + test 'show user name_kana next to name' do product = products(:product1) visit_with_auth "/products/#{product.id}", 'kimura' diff --git a/test/system/question/tags_test.rb b/test/system/question/tags_test.rb index 724daec3bd8..58804e5e053 100644 --- a/test/system/question/tags_test.rb +++ b/test/system/question/tags_test.rb @@ -14,14 +14,6 @@ class Question::TagsTest < ApplicationSystemTestCase end end - test 'update tags without page transitions' do - visit_with_auth question_path(questions(:question2)), 'komagata' - find('.tag-links__item-edit').click - fill_in_tag '追加タグ' - click_on '保存' - assert_text '追加タグ' - end - test 'admin can edit tag' do tag = acts_as_taggable_on_tags('game') assert_admin_can_edit_tag(questions_tag_path(tag.name, all: 'true')) @@ -37,9 +29,9 @@ class Question::TagsTest < ApplicationSystemTestCase update_tag_text = '上級者' visit_with_auth questions_tag_path(tag.name, all: 'true'), 'komagata' - click_button 'タグ名変更' - fill_in('tag[name]', with: update_tag_text) - click_button '変更' + click_tag_name_change + fill_in_open_tag_modal update_tag_text + click_save_tag_name_change assert_text "タグ「#{update_tag_text}」のQ&A（1）" visit_with_auth questions_tag_path(tag.name, all: 'true'), 'komagata' @@ -61,9 +53,9 @@ class Question::TagsTest < ApplicationSystemTestCase update_tag = acts_as_taggable_on_tags('intermediate') visit_with_auth questions_tag_path(tag.name, all: 'true'), 'komagata' - click_button 'タグ名変更' - fill_in('tag[name]', with: update_tag.name) - click_button '変更' + click_tag_name_change + fill_in_open_tag_modal update_tag.name + click_save_tag_name_change assert_text "タグ「#{update_tag.name}」のQ&A（2）" visit_with_auth questions_tag_path(tag.name, all: 'true'), 'komagata' diff --git a/test/system/questions/answer_test.rb b/test/system/questions/answer_test.rb index 7d806cf9648..1f1565daa55 100644 --- a/test/system/questions/answer_test.rb +++ b/test/system/questions/answer_test.rb @@ -59,24 +59,5 @@ class AnswerTest < ApplicationSystemTestCase assert_text '削除する' assert_text 'Watch中' end - - test 'show number of comments' do - visit_with_auth questions_path(target: 'not_solved'), 'kimura' - assert_text 'コメント数表示テスト用の質問' - element = all('.card-list-item').find { |component| component.has_text?('コメント数表示テスト用の質問') } - within element do - assert_selector '.a-meta', text: '（1）' - end - end - - test "show number of comments when comments don't exist" do - visit_with_auth questions_path(target: 'not_solved'), 'kimura' - assert_text 'テストの質問' - - element = all('.card-list-item').find { |component| component.has_text?('テストの質問') } - within element do - assert_selector '.a-meta.is-important', text: '（0）' - end - end end end diff --git a/test/system/questions/tag_test.rb b/test/system/questions/tag_test.rb index ce544465e8e..5be6bc2d3ae 100644 --- a/test/system/questions/tag_test.rb +++ b/test/system/questions/tag_test.rb @@ -51,13 +51,13 @@ class TagTest < ApplicationSystemTestCase find('.tag-links__item-edit').click tag_input = first('.tagify__input') accept_alert do - tag_input.set "半角スペースは 使えない\t" + tag_input.send_keys '半角スペースは 使えない', :tab end click_button '保存する' find('.tag-links__item-edit').click tag_input = first('.tagify__input') accept_alert do - tag_input.set "全角スペースも 使えない\t" + tag_input.send_keys '全角スペースも 使えない', :tab end click_button '保存する' assert_equal question.tag_list.sort, all('.tag-links__item-link').map(&:text).sort @@ -69,7 +69,7 @@ class TagTest < ApplicationSystemTestCase find('.tag-links__item-edit').click tag_input = first('.tagify__input') accept_alert do - tag_input.set ".\t" + tag_input.send_keys '.', :tab end click_button '保存する' assert_equal question.tag_list.sort, all('.tag-links__item-link').map(&:text).sort diff --git a/test/system/questions/wip_test.rb b/test/system/questions/wip_test.rb index 438a844fe39..556d636f9dc 100644 --- a/test/system/questions/wip_test.rb +++ b/test/system/questions/wip_test.rb @@ -76,21 +76,6 @@ class WipTest < ApplicationSystemTestCase assert_text '質問をWIPとして保存しました。' end - test 'show a WIP question on the All Q&A list page' do - visit_with_auth questions_path, 'kimura' - assert_text 'wipテスト用の質問(wip中)' - element = all('.card-list-item').find { |component| component.has_text?('wipテスト用の質問(wip中)') } - within element do - assert_selector '.a-list-item-badge.is-wip', text: 'WIP' - end - end - - test 'not show a WIP question on the unsolved Q&A list page' do - visit_with_auth questions_path(target: 'not_solved'), 'kimura' - assert_no_text 'wipテスト用の質問(wip中)' - assert_selector 'h2', text: 'Q&A' - end - test "mentor's watch-button is not automatically on when new question is created as WIP" do visit_with_auth new_question_path, 'kimura' within 'form[name=question]' do diff --git a/test/system/reaction/micro_reports_test.rb b/test/system/reaction/micro_reports_test.rb index d9a5faf3b60..82a2179d4a8 100644 --- a/test/system/reaction/micro_reports_test.rb +++ b/test/system/reaction/micro_reports_test.rb @@ -6,7 +6,7 @@ class Reaction::MicroReportsTest < ApplicationSystemTestCase test 'show reaction of micro report' do visit_with_auth user_micro_reports_path(users(:hajime)), 'hatsuno' - assert_text "👍1\n❤️1" + assert_text '👍1❤️1' end test 'reaction to micro report' do @@ -14,7 +14,7 @@ class Reaction::MicroReportsTest < ApplicationSystemTestCase first('.js-reaction-dropdown-toggle').click first(".js-reaction-dropdown li[data-reaction-kind='eyes']").click - assert_text "👍1\n❤️1\n👀1" + assert_text '👍1❤️1👀1' end test 'delete reaction of micro report on dropdown' do diff --git a/test/system/reaction/product_test.rb b/test/system/reaction/product_test.rb index 5f37f666b0d..68f1bf18444 100644 --- a/test/system/reaction/product_test.rb +++ b/test/system/reaction/product_test.rb @@ -6,7 +6,7 @@ class Reaction::ProductsTest < ApplicationSystemTestCase test 'show reaction of product' do visit_with_auth product_path(products(:product12)), 'machida' - assert_text "🎉1\n👀1" + assert_text '🎉1👀1' end test 'reaction to product' do @@ -15,7 +15,7 @@ class Reaction::ProductsTest < ApplicationSystemTestCase first(".js-reaction-dropdown li[data-reaction-kind='eyes']").click using_wait_time 5 do - assert_text "🎉1\n👀2" + assert_text '🎉1👀2' end end diff --git a/test/system/regular_events/skip_date_test.rb b/test/system/regular_events/skip_date_test.rb new file mode 100644 index 00000000000..297e67c1775 --- /dev/null +++ b/test/system/regular_events/skip_date_test.rb @@ -0,0 +1,80 @@ +# frozen_string_literal: true + +require 'application_system_test_case' + +module RegularEvents + class SkipDateTest < ApplicationSystemTestCase + setup do + stub_request(:post, 'https://discord.com/api/webhooks/0123456789/all') + stub_request(:post, 'https://discord.com/api/webhooks/0123456789/admin') + stub_request(:post, 'https://discord.com/api/webhooks/0123456789/mentor') + end + + test 'create and show skip dates' do + travel_to Time.zone.local(2026, 4, 1, 6, 0, 0) do + visit_with_auth new_regular_event_path, 'kimura' + wait_for_regular_event_form + within 'form[name=regular_event]' do + fill_in 'regular_event[title]', with: 'チェリー本輪読会' + first('.choices__inner').click + within('.choices__list--dropdown') do + first('.choices__item--choice').click + end + first('.regular-event-repeat-rule').first('.regular-event-repeat-rule__frequency select').select('毎週') + first('.regular-event-repeat-rule').first('.regular-event-repeat-rule__day-of-the-week select').select('月曜日') + fill_in 'regular_event[start_at]', with: Time.zone.parse('19:00') + fill_in 'regular_event[end_at]', with: Time.zone.parse('20:00') + fill_in 'regular_event[description]', with: 'テスト' + click_on 'スキップする日を追加' + fill_in 'スキップする日', with: Time.zone.local(2026, 4, 6).to_date + fill_in '理由', with: '主催者の急用のため' + end + + assert_difference 'RegularEvent.count', 1 do + click_button '作成' + end + + within('.event-meta__item', text: '開催日時') do + assert_text '毎週月曜日19:00 〜 20:00（祝日は休み）' + end + + within('.event-meta__item', text: '次回開催日') do + assert_text '2026年04月13日' + end + + within('.a-card', text: '今後のイベント休み予定') do + assert_text '2026年04月06日' + assert_text '2026年05月04日' + assert_text '2026年07月20日' + assert_text '2026年09月21日' + assert_text '2026年10月12日' + end + end + end + + test 'out-of-rule skip dates are shown only to organizers and mentors' do + travel_to Time.zone.local(2026, 4, 1, 6, 0, 0) do + regular_event = regular_events(:regular_event7) + regular_event.regular_event_skip_dates.create!(skip_on: Date.new(2026, 4, 7), reason: '開催ルールと一致していないスキップする日') + + visit_with_auth regular_event_path(regular_event), 'kimura' + + within('.a-card.is-out-of-rule-skip-dates') do + assert_text '開催曜日と一致しない日がスキップ日として登録されています' + assert_text '2026年04月07日(火)' + end + + visit_with_auth regular_event_path(regular_event), 'komagata' + + within('.a-card.is-out-of-rule-skip-dates') do + assert_text '開催曜日と一致しない日がスキップ日として登録されています' + assert_text '2026年04月07日(火)' + end + + visit_with_auth regular_event_path(regular_event), 'hajime' + + assert_no_selector('.a-card.is-out-of-rule-skip-dates') + end + end + end +end diff --git a/test/system/regular_events_test.rb b/test/system/regular_events_test.rb index 0b0b07baccc..6bfe20e2c72 100644 --- a/test/system/regular_events_test.rb +++ b/test/system/regular_events_test.rb @@ -38,16 +38,18 @@ class RegularEventsTest < ApplicationSystemTestCase assert_selector '.card-list.a-card', text: 'その他' end - test 'show listing not finished regular events' do + test 'show listing not finished regular events without wip' do + wip_regular_event = regular_events(:regular_event42) visit_with_auth regular_events_path(target: 'not_finished'), 'kimura' assert_selector '.card-list.a-card .card-list-item', count: 22 + assert_no_selector '.card-list.a-card .card-list-item', text: wip_regular_event.title end test 'show listing all regular events' do visit_with_auth regular_events_path, 'kimura' assert_selector '.card-list.a-card .card-list-item', count: 25 visit regular_events_path(page: 2) - assert_selector '.card-list.a-card .card-list-item', count: 16 + assert_selector '.card-list.a-card .card-list-item', count: 18 end test 'using file uploading by file selection dialogue in textarea' do diff --git a/test/system/reports/markdown_test.rb b/test/system/reports/markdown_test.rb index de5c436030d..4cc192e6d69 100644 --- a/test/system/reports/markdown_test.rb +++ b/test/system/reports/markdown_test.rb @@ -27,13 +27,13 @@ class MarkdownTest < ApplicationSystemTestCase click_button '提出' click_link 'Raw' switch_to_window windows.last - assert_text '## this is heading2', exact: true + assert_text 'this is heading2' end test 'description of the daily report is previewed' do visit_with_auth '/reports/new', 'komagata' within('form[name=report]') do - fill_in('report[description]', with: "Markdown入力するとプレビューにHTMLで表示されている。\n # h1") + find_field('report[description]').send_keys "Markdown入力するとプレビューにHTMLで表示されている。\n # h1" end assert_selector '.js-preview.a-long-text.markdown-form__preview', text: 'Markdown入力するとプレビューにHTMLで表示されている。' do assert_selector 'h1', text: 'h1' @@ -44,7 +44,7 @@ class MarkdownTest < ApplicationSystemTestCase visit_with_auth report_path(reports(:report1)), 'komagata' click_link '内容修正' within('form[name=report]') do - fill_in('report[description]', with: "Markdown入力するとプレビューにHTMLで表示されている。\n # h1") + find_field('report[description]').send_keys([cmd_ctrl, 'a'], "Markdown入力するとプレビューにHTMLで表示されている。\n # h1") end assert_selector '.js-preview.markdown-form__preview', text: 'Markdown入力するとプレビューにHTMLで表示されている。' do assert_selector 'h1', text: 'h1' @@ -55,7 +55,7 @@ class MarkdownTest < ApplicationSystemTestCase visit_with_auth report_path(reports(:report1)), 'komagata' click_link '複製' within('form[name=report]') do - fill_in('report[description]', with: "Markdown入力するとプレビューにHTMLで表示されている。\n # h1") + find_field('report[description]').send_keys([cmd_ctrl, 'a'], "Markdown入力するとプレビューにHTMLで表示されている。\n # h1") end assert_selector '.js-preview.markdown-form__preview', text: 'Markdown入力するとプレビューにHTMLで表示されている。' do assert_selector 'h1', text: 'h1' diff --git a/test/system/reports/mentor_test.rb b/test/system/reports/mentor_test.rb index be94ac92cf8..1be972f99ee 100644 --- a/test/system/reports/mentor_test.rb +++ b/test/system/reports/mentor_test.rb @@ -45,7 +45,7 @@ class MentorTest < ApplicationSystemTestCase test 'show edit button when mentor is logged in and mentor mode is on in report detail page' do visit_with_auth report_path(reports(:report1)), 'mentormentaro' assert_text '内容修正' - find(:css, '#checkbox-mentor-mode').set(false) + page.execute_script("document.querySelector('#checkbox-mentor-mode').click()") assert_no_text '内容修正' end diff --git a/test/system/reports/validation_test.rb b/test/system/reports/validation_test.rb index 2334e0d91e8..f0e31db131e 100644 --- a/test/system/reports/validation_test.rb +++ b/test/system/reports/validation_test.rb @@ -30,7 +30,7 @@ class ValidationTest < ApplicationSystemTestCase fill_in('report[reported_on]', with: Date.new(2012, 12, 31)) end click_button '提出' - html_validation_message = page.find('#report_reported_on').native.attribute('validationMessage') + html_validation_message = page.evaluate_script("document.getElementById('report_reported_on').validationMessage") assert_not_nil html_validation_message assert_not_empty html_validation_message end diff --git a/test/system/reports_test.rb b/test/system/reports_test.rb index 356f8f23197..e41c91c9ebc 100644 --- a/test/system/reports_test.rb +++ b/test/system/reports_test.rb @@ -45,18 +45,7 @@ class ReportsTest < ApplicationSystemTestCase test 'URL copy button copies the current URL to the clipboard' do report = reports(:report10) visit_with_auth "/reports/#{report.id}", 'hajime' - cdp_permission_write = { - origin: page.server_url, - permission: { name: 'clipboard-write' }, - setting: 'granted' - } - page.driver.browser.execute_cdp('Browser.setPermission', **cdp_permission_write) - cdp_permission_read = { - origin: page.server_url, - permission: { name: 'clipboard-read' }, - setting: 'granted' - } - page.driver.browser.execute_cdp('Browser.setPermission', **cdp_permission_read) + grant_clipboard_permission click_button 'URLコピー' clip_text = page.evaluate_async_script('navigator.clipboard.readText().then(arguments[0])') assert_equal current_url, clip_text diff --git a/test/system/request_retirements_test.rb b/test/system/request_retirements_test.rb index 83dedbdc3d1..576e1254dcb 100644 --- a/test/system/request_retirements_test.rb +++ b/test/system/request_retirements_test.rb @@ -11,8 +11,9 @@ class RequestRetirementsTest < ApplicationSystemTestCase select 'kensyu', from: '退会をさせる方のアカウント' fill_in('退会申請理由', with: '退職してしまったため。') choose '削除する', allow_label_click: true - click_on '申請する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '申請する' + end assert_text '退会申請を受け付けました。' end diff --git a/test/system/require_login/users_test.rb b/test/system/require_login/users_test.rb index 97bef7ce612..9a18a2fa2ad 100644 --- a/test/system/require_login/users_test.rb +++ b/test/system/require_login/users_test.rb @@ -12,6 +12,12 @@ class UsersLoginTest < ApplicationSystemTestCase # セッションリセット時のタイムアウトは無視して続行 end + def after_teardown + super + rescue Net::ReadTimeout + # セッションリセット時のタイムアウトは無視して続行 + end + test 'cannot access users list without login' do assert_login_required('/users') end diff --git a/test/system/retirement_test.rb b/test/system/retirement_test.rb index 67ef36de11c..f9027b5524d 100644 --- a/test/system/retirement_test.rb +++ b/test/system/retirement_test.rb @@ -19,8 +19,9 @@ class RetirementsTest < ApplicationSystemTestCase user = users(:kananashi) visit_with_auth new_retirement_path, 'kananashi' find('label', text: 'とても良い').click - click_on '退会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' assert_equal Date.current, user.reload.retired_on assert_equal '😢 kananashiさんが退会しました。', users(:komagata).notifications.last.message @@ -32,8 +33,9 @@ class RetirementsTest < ApplicationSystemTestCase user = users(:osnashi) visit_with_auth new_retirement_path, 'osnashi' find('label', text: 'とても良い').click - click_on '退会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' assert_equal Date.current, user.reload.retired_on assert_equal '😢 osnashiさんが退会しました。', users(:komagata).notifications.last.message @@ -52,8 +54,9 @@ class RetirementsTest < ApplicationSystemTestCase Discord::Server.stub(:delete_text_channel, true) do visit_with_auth new_retirement_path, user.login_name find('label', text: 'とても良い').click - click_on '退会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' end assert_equal Date.current, user.reload.retired_on @@ -70,8 +73,9 @@ class RetirementsTest < ApplicationSystemTestCase user = users(:kananashi) visit_with_auth new_retirement_path, 'kananashi' find('label', text: 'とても良い').click - click_on '退会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' assert_equal Date.current, user.reload.retired_on end diff --git a/test/system/retirements/data_deletion_test.rb b/test/system/retirements/data_deletion_test.rb index 0d59ab03f1e..67cd881707f 100644 --- a/test/system/retirements/data_deletion_test.rb +++ b/test/system/retirements/data_deletion_test.rb @@ -69,8 +69,9 @@ class DataDeletionTest < ApplicationSystemTestCase visit_with_auth new_retirement_path, 'kimura' find('label', text: 'とても良い').click - click_on '退会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' visit_with_auth "regular_events/#{regular_event.id}", 'komagata' @@ -82,8 +83,9 @@ class DataDeletionTest < ApplicationSystemTestCase test 'retire with event organizer' do visit_with_auth new_retirement_path, 'hajime' find('label', text: 'とても良い').click - click_on '退会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' regular_event = regular_events(:regular_event4) @@ -92,8 +94,9 @@ class DataDeletionTest < ApplicationSystemTestCase visit_with_auth new_retirement_path, 'kimura' find('label', text: 'とても良い').click - click_on '退会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' visit_with_auth "regular_events/#{regular_event.id}", 'komagata' @@ -125,5 +128,19 @@ class DataDeletionTest < ApplicationSystemTestCase visit_with_auth new_retirement_path, regular_event.user.login_name assert_no_text 'ご自身が主催者である定期イベントがあります。' end + + test 'should unmatch when buddy has retired' do + travel_to Time.zone.local(2025, 1, 1, 0, 0, 0) do + visit_with_auth new_retirement_path, 'sotugyou' + find('label', text: 'とても良い').click + page.accept_confirm '本当によろしいですか？' do + click_on '退会する' + end + assert_text '退会処理が完了しました' + pair_work = pair_works(:pair_work2).reload + assert_nil pair_work.buddy_id + assert_nil pair_work.reserved_at + end + end end end diff --git a/test/system/retirements/validation_test.rb b/test/system/retirements/validation_test.rb index 84b86141d7f..493265426af 100644 --- a/test/system/retirements/validation_test.rb +++ b/test/system/retirements/validation_test.rb @@ -20,8 +20,9 @@ class ValidationTest < ApplicationSystemTestCase user = users(:discordinvalid) visit_with_auth new_retirement_path, 'discordinvalid' find('label', text: 'とても悪い').click - click_on '退会する' - page.accept_confirm + page.accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' assert_equal Date.current, user.reload.retired_on assert_equal '😢 discordinvalidさんが退会しました。', users(:komagata).notifications.last.message @@ -35,8 +36,9 @@ class ValidationTest < ApplicationSystemTestCase user = users(:twitterinvalid) visit_with_auth new_retirement_path, 'twitterinvalid' find('label', text: 'とても悪い').click - click_on '退会する' - page.accept_confirm + page.accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' assert_equal Date.current, user.reload.retired_on assert_equal '😢 twitterinvalidさんが退会しました。', users(:komagata).notifications.last.message diff --git a/test/system/sign_up/trainee_test.rb b/test/system/sign_up/trainee_test.rb index b227e165ca4..4a07190f208 100644 --- a/test/system/sign_up/trainee_test.rb +++ b/test/system/sign_up/trainee_test.rb @@ -124,7 +124,6 @@ class TraineeTest < ApplicationSystemTestCase select '学生', from: 'user[job]' find('label', text: 'Mac（Intel チップ）').click check 'Rubyの経験あり', allow_label_click: true - find('label', text: 'クレジットカード払い').click first('.choices__inner').click find('.choices__list--dropdown').click find('.choices__list').click @@ -133,10 +132,23 @@ class TraineeTest < ApplicationSystemTestCase find('label', text: '利用規約に同意').click end - fill_stripe_element('4242 4242 4242 4242', '12 / 50', '111') + page.execute_script(<<~JS) + const creditCardCheckBox = document.querySelector('.selectable-credit-card-box') + if (!creditCardCheckBox.checked) { + creditCardCheckBox.click() + } + JS + assert_no_selector '#card.hidden' + page.execute_script(<<~JS) + const hiddenInput = document.createElement('input') + hiddenInput.setAttribute('type', 'hidden') + hiddenInput.setAttribute('name', 'stripeToken') + hiddenInput.setAttribute('value', 'tok_visa') + document.getElementById('payment-form').appendChild(hiddenInput) + JS VCR.use_cassette 'sign_up/valid-card', record: :once, match_requests_on: %i[method uri] do - click_button '参加する' + page.execute_script("document.getElementById('payment-form').submit()") assert_text '研修生登録が完了しました' end assert User.find_by(email:).trainee? @@ -172,24 +184,25 @@ class TraineeTest < ApplicationSystemTestCase end test 'job seeker option is hidden for trainee invoice payment' do - visit '/users/new?role=trainee_invoice_payment' - assert_selector 'form[name=user]' - assert has_no_selector? "input[name='user[job_seeker]']", visible: :all + assert_job_seeker_option_hidden_for('trainee_invoice_payment') end test 'job seeker option is hidden for trainee credit card payment' do - visit '/users/new?role=trainee_credit_card_payment' - assert_selector 'form[name=user]' - # クレジットカード払いフォームが正しく描画されるのを待ってから不在を検査する - # （描画途中の別ページで誤判定することを避けるため） - assert_selector '#card' - assert has_no_selector? "input[name='user[job_seeker]']", visible: :all + assert_job_seeker_option_hidden_for('trainee_credit_card_payment') end test 'job seeker option is hidden for trainee select a payment method' do - visit '/users/new?role=trainee_select_a_payment_method' - assert_selector 'form[name=user]' - assert has_no_selector? "input[name='user[job_seeker]']", visible: :all + assert_job_seeker_option_hidden_for('trainee_select_a_payment_method') + end + + private + + def assert_job_seeker_option_hidden_for(role) + Capybara.using_driver(:rack_test) do + visit "/users/new?role=#{role}" + assert_selector 'form[name=user]' + assert_no_selector "input[name='user[job_seeker]']", visible: :all + end end end end diff --git a/test/system/sign_up/validation_test.rb b/test/system/sign_up/validation_test.rb index 2eb5c6ba734..de5ace6ebbe 100644 --- a/test/system/sign_up/validation_test.rb +++ b/test/system/sign_up/validation_test.rb @@ -16,55 +16,6 @@ class ValidationTest < ApplicationSystemTestCase Discord::Server.authorize_token = @bot_token end - test 'sign up with reserved login name' do - visit '/users/new' - within 'form[name=user]' do - fill_in 'user[login_name]', with: 'mentor' - fill_in 'user[email]', with: 'akiko@example.com' - fill_in 'user[name]', with: 'テスト 秋子' - fill_in 'user[name_kana]', with: 'テスト アキコ' - fill_in 'user[description]', with: 'テスト秋子です。' - fill_in 'user[password]', with: 'testtest' - fill_in 'user[password_confirmation]', with: 'testtest' - select '学生', from: 'user[job]' - find('label', text: 'Mac（Intel チップ）').click - check 'Rubyの経験あり', allow_label_click: true - find('label', text: 'アンチハラスメントポリシーに同意').click - find('label', text: '利用規約に同意').click - end - - fill_stripe_element('4242 4242 4242 4242', '12 / 50', '111') - - VCR.use_cassette 'sign_up/valid-card', record: :once do - click_button '参加する' - assert_text 'に使用できない文字列が含まれています' - end - end - - test 'sign up with empty description ' do - visit '/users/new' - within 'form[name=user]' do - fill_in 'user[login_name]', with: 'foo' - fill_in 'user[email]', with: 'siro@example.com' - fill_in 'user[name]', with: 'テスト 四郎' - fill_in 'user[name_kana]', with: 'テスト シロウ' - fill_in 'user[password]', with: 'testtest' - fill_in 'user[password_confirmation]', with: 'testtest' - select '学生', from: 'user[job]' - find('label', text: 'Mac（Intel チップ）').click - check 'Rubyの経験あり', allow_label_click: true - find('label', text: 'アンチハラスメントポリシーに同意').click - find('label', text: '利用規約に同意').click - end - - fill_stripe_element('5555 5555 5555 4444', '12 / 50', '111') - - VCR.use_cassette 'sign_up/valid-card', record: :once do - click_button '参加する' - assert_text '自己紹介を入力してください' - end - end - test 'hidden input learning time frames table' do visit '/users/new' assert_no_selector ".form-item.a-form-label[for='user_learning_time_frames']", text: '主な活動予定時間' diff --git a/test/system/sign_up_test.rb b/test/system/sign_up_test.rb index f31845b0526..35d41867ada 100644 --- a/test/system/sign_up_test.rb +++ b/test/system/sign_up_test.rb @@ -72,7 +72,7 @@ class SignUpTest < ApplicationSystemTestCase if has_selector?('.tagify__input') tag_input = find('.tagify__input') tag_input.set tag - tag_input.native.send_keys :return + tag_input.send_keys :return elsif has_selector?('input[name="user[tag_list]"]', visible: :hidden) page.execute_script("document.querySelector('input[name=\"user[tag_list]\"]').value = '#{tag}'") end diff --git a/test/system/user/events_test.rb b/test/system/user/events_test.rb index 45b14d9ba2c..38939fc5595 100644 --- a/test/system/user/events_test.rb +++ b/test/system/user/events_test.rb @@ -10,14 +10,40 @@ class User::EventsTest < ApplicationSystemTestCase assert nav.matches_css?('.is-active') end - test 'shows correct count of user participating events' do + test 'shows correct count of user involved events' do visit_with_auth "/users/#{users(:kimura).id}/events", 'kimura' - assert_selector '.tab-nav__item-link', text: "特別イベント(#{users(:kimura).participate_events.count})" + assert_selector '.tab-nav__item-link', text: "特別イベント(#{users(:kimura).involved_events.count})" end - test 'does not show events the user is not participating in' do + test 'does not show events the user is not involved in' do + participated_event = events(:event30) + non_participated_event = events(:event34) + start_at = 1.month.from_now + + participated_event.update!( + start_at:, + end_at: start_at + 2.hours, + open_start_at: start_at - 1.month, + open_end_at: start_at - 1.hour + ) + non_participated_event.update!( + user: users(:komagata), + start_at:, + end_at: start_at + 2.hours, + open_start_at: start_at - 1.month, + open_end_at: start_at - 1.hour + ) + + visit_with_auth "/users/#{users(:kimura).id}/events", 'kimura' + assert_text '未来のイベント(参加済)' + assert_no_text '過去のイベント' + end + + test 'shows events the user organizes but does not participate in' do visit_with_auth "/users/#{users(:kimura).id}/events", 'kimura' - assert_text 'kimura専用イベント' - assert_no_text '募集期間中のイベント(補欠者なし)' + + within('.card-list-item', text: 'ミートアップ') do + assert_text '主催' + end end end diff --git a/test/system/user/micro_reports_test.rb b/test/system/user/micro_reports_test.rb index 183e81bee3a..3fe9965b4c8 100644 --- a/test/system/user/micro_reports_test.rb +++ b/test/system/user/micro_reports_test.rb @@ -65,7 +65,7 @@ class MicroReportsTest < ApplicationSystemTestCase test 'content is interpreted as markdown in preview tab' do visit_with_auth user_micro_reports_path(users(:hatsuno)), 'hatsuno' - fill_in('micro_report[content]', with: "Markdown入力するとプレビューにHTMLで表示されている。\n # h1") + find_field('micro_report[content]').send_keys "Markdown入力するとプレビューにHTMLで表示されている。\n # h1" within('.micro-report-form-tabs') do click_on 'プレビュー' end @@ -152,8 +152,9 @@ class MicroReportsTest < ApplicationSystemTestCase within(".micro-report#micro_report_#{micro_report.id}") do assert_selector 'a', text: '削除する' - click_link_or_button '削除する' - page.accept_alert + page.accept_alert do + click_link_or_button '削除する' + end end assert_text '分報を削除しました。' @@ -178,8 +179,9 @@ class MicroReportsTest < ApplicationSystemTestCase assert_text '最初の分報' within(".micro-report#micro_report_#{micro_report.id}") do - click_link_or_button '削除する' - page.accept_alert + page.accept_alert do + click_link_or_button '削除する' + end end assert_text '分報を削除しました。' @@ -222,8 +224,9 @@ class MicroReportsTest < ApplicationSystemTestCase assert_selector '.pagination__item.is-active', text: '1' within('.micro-report[data-micro_report_content="分報1"]') do - click_link_or_button '削除する' - page.accept_alert + page.accept_alert do + click_link_or_button '削除する' + end end assert_text '分報を削除しました。' diff --git a/test/system/user/regular_events_test.rb b/test/system/user/regular_events_test.rb index 816ff3e7e93..4209fb412c5 100644 --- a/test/system/user/regular_events_test.rb +++ b/test/system/user/regular_events_test.rb @@ -3,21 +3,26 @@ require 'application_system_test_case' class User::RegularEventsTest < ApplicationSystemTestCase - test 'shows the regular event listing for a user ' do + test 'shows the regular event listing for a user' do visit_with_auth "/users/#{users(:komagata).id}/regular_events", 'komagata' assert_equal 'komagataのイベント一覧 | FBC', title nav = find('a.tab-nav__item-link', text: /定期イベント\(\d+\)/) assert nav.matches_css?('.is-active') end - test 'shows correct count of user participating regular events' do + test 'shows correct count of user involved regular events' do visit_with_auth "/users/#{users(:kimura).id}/regular_events", 'kimura' - assert_text "定期イベント(#{users(:kimura).participate_regular_events.count})" + assert_text "定期イベント(#{users(:kimura).involved_regular_events.count})" end - test 'does not show regular events the user is not participating in' do + test 'does not show regular events the user is not involved in' do visit_with_auth "/users/#{users(:kimura).id}/regular_events", 'kimura' assert_text '独習Git輪読会' assert_no_text '開発MTG' end + + test 'shows regular events the user organizes but does not participate in' do + visit_with_auth "/users/#{users(:kimura).id}/regular_events", 'kimura' + assert_text 'チェリー本輪読会' + end end diff --git a/test/system/user/tags_test.rb b/test/system/user/tags_test.rb index d1f6a3c4f31..2354ab869f0 100644 --- a/test/system/user/tags_test.rb +++ b/test/system/user/tags_test.rb @@ -52,7 +52,7 @@ class User::TagsTest < ApplicationSystemTestCase page.all('.tag-links__item-edit')[0].click tag_input = find('.tagify__input') tag_input.set 'タグタグ' - tag_input.native.send_keys :return + tag_input.send_keys :return assert_text 'タグタグ' find_all('.tagify__tag').map(&:text) click_button '保存する' @@ -92,8 +92,8 @@ class User::TagsTest < ApplicationSystemTestCase visit_with_auth users_tag_path(tag.name, all: 'true'), 'komagata' click_button 'タグ名変更' - fill_in('tag[name]', with: update_tag_text) - click_button '変更' + fill_in_open_tag_modal update_tag_text + click_save_tag_name_change assert_text 'タグ「上級者」' visit_with_auth users_tag_path(tag.name), 'komagata' @@ -113,8 +113,8 @@ class User::TagsTest < ApplicationSystemTestCase visit_with_auth users_tag_path(tag.name, all: 'true'), 'komagata' click_button 'タグ名変更' - fill_in('tag[name]', with: update_tag.name) - click_button '変更' + fill_in_open_tag_modal update_tag.name + click_save_tag_name_change assert_text 'タグ「中級者」' visit_with_auth users_tag_path(tag.name), 'komagata' @@ -142,7 +142,7 @@ class User::TagsTest < ApplicationSystemTestCase first('.tag-links__item-edit').click tag_input = find('.tagify__input') tag_input.set '#ハッシュハッシュ' - tag_input.native.send_keys :return + tag_input.send_keys :return click_button '保存する' assert_includes all('.tag-links__item-link').map(&:text), 'ハッシュハッシュ' @@ -172,8 +172,9 @@ class User::TagsTest < ApplicationSystemTestCase fill_in('hibernation[reason]', with: 'test') end find('.check-box-to-read').click - click_on '休会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '休会する' + end assert_text '休会手続きが完了しました' visit_with_auth users_tag_path(tag_name), 'komagata' @@ -203,8 +204,9 @@ class User::TagsTest < ApplicationSystemTestCase visit_with_auth new_retirement_path, 'kensyu' find('label', text: 'とても良い').click - click_on '退会する' - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_on '退会する' + end assert_text '退会処理が完了しました' visit_with_auth users_tag_path(tag_name), 'komagata' diff --git a/test/system/users/registration_test.rb b/test/system/users/registration_test.rb index e09fafca6b4..73f672bebc6 100644 --- a/test/system/users/registration_test.rb +++ b/test/system/users/registration_test.rb @@ -5,9 +5,8 @@ module Users class RegistrationTest < ApplicationSystemTestCase test 'GET /users/new' do - visit '/users/new' - # CI実行が遅い場合に備えて待ち時間を拡大する - using_wait_time 20 do + Capybara.using_driver(:rack_test) do + visit '/users/new' assert_selector 'h1.auth-form__title', text: 'FBC参加登録' assert_selector 'form[name=user]' end diff --git a/test/system/users_test.rb b/test/system/users_test.rb index fcb19573807..e9e8891e9b3 100644 --- a/test/system/users_test.rb +++ b/test/system/users_test.rb @@ -62,8 +62,9 @@ class UsersTest < ApplicationSystemTestCase test 'delete user' do user = users(:kimura) visit_with_auth "users/#{user.id}", 'komagata' - click_link "delete-#{user.id}" - page.driver.browser.switch_to.alert.accept + accept_confirm do + click_link "delete-#{user.id}" + end assert_text "#{user.name} さんを削除しました。" end diff --git a/test/system/welcome/meta_tags_test.rb b/test/system/welcome/meta_tags_test.rb index a1ce8f09191..a259a2d7b72 100644 --- a/test/system/welcome/meta_tags_test.rb +++ b/test/system/welcome/meta_tags_test.rb @@ -46,8 +46,8 @@ class MetaTagsTest < ApplicationSystemTestCase assert_selector "meta[name='twitter:title'][content='FAQ']", visible: false end - test 'GET /buzz' do - visit '/buzz' + test 'GET /buzzes' do + visit '/buzzes' assert_equal '紹介・言及記事 | FJORD BOOT CAMP（フィヨルドブートキャンプ）', title assert_selector "meta[property='og:title'][content='紹介・言及記事']", visible: false assert_selector "meta[name='twitter:title'][content='紹介・言及記事']", visible: false diff --git a/test/views/questions/question_partial_test.rb b/test/views/questions/question_partial_test.rb new file mode 100644 index 00000000000..dbaf2aa373e --- /dev/null +++ b/test/views/questions/question_partial_test.rb @@ -0,0 +1,28 @@ +# frozen_string_literal: true + +require 'test_helper' + +module Questions + class QuestionPartialTest < ActionView::TestCase + test 'renders WIP badge for WIP question' do + render partial: 'questions/question', locals: { question: questions(:question_for_wip) } + + assert_select '.card-list-item.is-wip' + assert_select '.a-list-item-badge.is-wip', text: 'WIP' + end + + test 'renders answer count' do + render partial: 'questions/question', locals: { question: questions(:question_for_comment_count) } + + assert_select '.a-meta', text: '回答・コメント（1）' + end + + test 'marks answer count as important when answer does not exist' do + question = questions(:question_for_wip) + + render partial: 'questions/question', locals: { question: } + + assert_select '.a-meta.is-important', text: '回答・コメント（0）' + end + end +end diff --git a/test/views/users/register_address_partial_test.rb b/test/views/users/register_address_partial_test.rb new file mode 100644 index 00000000000..586fcad192c --- /dev/null +++ b/test/views/users/register_address_partial_test.rb @@ -0,0 +1,33 @@ +# frozen_string_literal: true + +require 'test_helper' + +class Users::RegisterAddressPartialTest < ActionView::TestCase + test 'hides country and subdivision fields when address is not registered' do + render_register_address(users(:komagata)) + + assert_select 'input[name=register_address][value=no][checked=checked]' + assert_select '#country-form.is-hidden' + assert_select '#subdivision-form.is-hidden' + end + + test 'renders country and subdivision fields when address is registered' do + render_register_address(users(:kimura)) + + assert_select 'input[name=register_address][value=yes][checked=checked]' + assert_select '#country-form' + assert_select '#country-form.is-hidden', false + assert_select 'select#country-select[name="user[country_code]"] option[selected=selected]', text: '日本' + assert_select '#subdivision-form' + assert_select '#subdivision-form.is-hidden', false + assert_select 'select#subdivision-select[name="user[subdivision_code]"] option', text: '北海道' + end + + private + + def render_register_address(user) + form_with(model: user, url: current_user_path) do |f| + render partial: 'users/form/register_address', locals: { f:, user: } + end + end +end