Skip to content

Commit ecf075c

Browse files
Tell public patches that Ubuntu CI does not run test:docs.
Why: PR 11 added npm run test:docs and listed it with the other public Node suites. CONTRIBUTING still said those same suites run on Ubuntu CI and in npm test. The PR template also omitted test:docs. Changed: CONTRIBUTING now lists the Ubuntu CI Node suites and says that job skips test:app and test:docs. The PR template checklist includes test:docs. Front-door tests pin both. Verification: npm run agent:verify -- --profile spec-only --paths CONTRIBUTING.md,.github/pull_request_template.md,docs/test/front-door.test.mjs --session-dir task-sessions/test-docs-followup-20260820 Affected: CONTRIBUTING.md .github/pull_request_template.md docs/test/front-door.test.mjs Refs: #11 #8 Session: task-sessions/test-docs-followup-20260820
1 parent 2e759b3 commit ecf075c

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

.github/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
A public patch uses Node.js 20 and the Node suites that match the change.
88
You do not need the agent harness or a task session directory.
99

10-
- [ ] `npm run test:broker-core` / `npm run test:client` / `npm run test:harness-adoption` as applicable, or I explained why a deterministic test is not available
10+
- [ ] `npm run test:broker-core` / `npm run test:client` / `npm run test:harness-adoption` / `npm run test:docs` as applicable, or I explained why a deterministic test is not available
1111
- [ ] I did not commit private paths, credentials, generated Xcode projects, local broker state, or task-session artifacts
1212

1313
## Notes

CONTRIBUTING.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,9 @@ npm run test:harness-adoption
3838
Run `npm run test:docs` for doc, README, or template changes; it runs the `docs/test` front-door checks.
3939

4040
App work also needs XcodeGen and `npm run test:app`. The full suite is
41-
`npm test`. The same Node suites run on GitHub-hosted Ubuntu CI. That job
42-
does not run `npm run test:app`.
41+
`npm test`. GitHub-hosted Ubuntu CI runs public-surface, `test:broker-core`,
42+
`test:client`, and `test:harness-adoption`. That job does not run
43+
`npm run test:app` or `npm run test:docs`.
4344

4445
You do not need to run `agent:context`, `agent:verify`, or `agent:complete`,
4546
and you do not need to create a task session directory.

docs/test/front-door.test.mjs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,11 @@ test("CONTRIBUTING leads with a public Node-20 patch track that does not require
138138
|| human.includes("npm test"),
139139
"public track must name a Node test command that is not agent:*",
140140
);
141+
assert.ok(human.includes("npm run test:docs"), "public track must name test:docs");
142+
assert.ok(
143+
human.includes("does not run") && human.includes("npm run test:docs"),
144+
"public track must not claim Ubuntu CI runs test:docs",
145+
);
141146
assert.equal(human.includes("You do not need to run `agent:context`"), true);
142147
assert.equal(human.includes("$HOME/.codex"), false);
143148
assert.equal(human.includes("npm run agent:context --"), false);
@@ -277,6 +282,7 @@ test("PR template is a public-patch checklist and does not require the harness",
277282
assert.ok(template.includes("npm run test:broker-core"));
278283
assert.ok(template.includes("npm run test:client"));
279284
assert.ok(template.includes("npm run test:harness-adoption"));
285+
assert.ok(template.includes("npm run test:docs"));
280286
assert.ok(template.includes("Alpha"));
281287
assert.ok(template.includes("macOS"));
282288
assert.ok(template.includes("Xcode"));

0 commit comments

Comments
 (0)