Skip to content

[Python] Parameter getter of EquationOfState crashes kernel for parameters that cannot be parsed to f64 #318

Description

@g-bauer

The parameter getter can cause kernel crashes when a model's parameters cannot be parsed into arrays/matrices of f64 since the mappings use unwraps. This is annoying because it can happen e.g. by tapping TAB in a notebook on a model for auto-completion.

Quick fix: remove getter. If the method is called (and not used as getter), PyO3 will wrap the panic in an error which keeps the kernel alive.

Longer term: create a better way to retrieve parameters from a model.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pythonPython related feature or issue

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions