Skip to content

Commit c573946

Browse files
tmgbeduclaude
andcommitted
fix: remove debug import and fix SQLitePlatform alter sql mutation
- Remove stale `from dumpdie import dd` debug import from MorphTo.py - Fix compile_alter_sql mutating diff.from_table.added_columns in place via .pop() and .update(), causing KeyError and wrong column lists when to_sql() is called more than once (e.g. __aexit__ + test assertion). Work on dict copies so each call produces correct idempotent output. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent d7e8e88 commit c573946

2 files changed

Lines changed: 5 additions & 10 deletions

File tree

fastapi_startkit/src/fastapi_startkit/masoniteorm/relationships/MorphTo.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from dumpdie import dd
21
from fastapi_startkit.masoniteorm.models import registry
32
from .BaseRelationship import BaseRelationship
43
from ..collection import Collection

fastapi_startkit/src/fastapi_startkit/masoniteorm/schema/platforms/SQLitePlatform.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -211,23 +211,21 @@ def compile_alter_sql(self, diff):
211211
or diff.changed_columns
212212
or diff.added_foreign_keys
213213
):
214-
original_columns = diff.from_table.added_columns
214+
original_columns = dict(diff.from_table.added_columns)
215215
# pop off the dropped columns. No need for them here
216216
for column in diff.dropped_columns:
217-
original_columns.pop(column)
217+
original_columns.pop(column, None)
218218

219219
sql.append(
220220
"CREATE TEMPORARY TABLE __temp__{table} AS SELECT {original_column_names} FROM {table}".format(
221221
table=diff.name,
222-
original_column_names=", ".join(
223-
diff.from_table.added_columns.keys()
224-
),
222+
original_column_names=", ".join(original_columns.keys()),
225223
)
226224
)
227225

228226
sql.append("DROP TABLE {table}".format(table=self.wrap_table(diff.name)))
229227

230-
columns = diff.from_table.added_columns
228+
columns = dict(original_columns)
231229

232230
columns.update(diff.renamed_columns)
233231
columns.update(diff.changed_columns)
@@ -264,9 +262,7 @@ def compile_alter_sql(self, diff):
264262
quoted_table=self.wrap_table(diff.name),
265263
table=diff.name,
266264
new_columns=", ".join(self.columnize_names(columns)),
267-
original_column_names=", ".join(
268-
diff.from_table.added_columns.keys()
269-
),
265+
original_column_names=", ".join(columns.keys()),
270266
)
271267
)
272268
sql.append("DROP TABLE __temp__{table}".format(table=diff.name))

0 commit comments

Comments
 (0)