fix(orm): build correct SQLite URLs in ConnectionFactory.build_url() (#191)

SQLite was going through the same {scheme}://{user}:{pwd}@{host}:{port}/{db}
template as postgres/mysql, producing an empty port segment
(sqlite+aiosqlite://:@localhost:/database.sqlite) that crashes
SQLAlchemy's URL._assert_port(). SQLite connections have no
host/user/password/port, so build the URL as {scheme}:///{db} instead,
which also correctly yields a four-slash URL for absolute paths.

Author: tmgbedu

fastapi_startkit/src/fastapi_startkit/masoniteorm/connections/factory.py

@@ -26,11 +26,15 @@ def build_url(cls, config: dict) -> str:
 
         driver = config["driver"]
         scheme = cls.DRIVER_URLS[driver]
+        db = config.get("database", "")
+
+        if driver == "sqlite":
+            return f"{scheme}:///{db}"
+
         user = config.get("username", "")
         pwd = config.get("password", "")
         host = config.get("host", "localhost")
         port = config.get("port", "")
-        db = config.get("database", "")
         return f"{scheme}://{user}:{pwd}@{host}:{port}/{db}"
 
     @classmethod

fastapi_startkit/tests/masoniteorm/config/test_db_url.py

@@ -30,6 +30,35 @@ def test_postgres_config(self):
         url = ConnectionFactory.build_url(config)
         self.assertEqual(url, "postgresql+asyncpg://user:pass@db.example.com:5432/mydb")
 
+    def test_sqlite_config_relative_database(self):
+        config = {
+            "driver": "sqlite",
+            "database": "database.sqlite",
+        }
+        url = ConnectionFactory.build_url(config)
+        self.assertEqual(url, "sqlite+aiosqlite:///database.sqlite")
+
+    def test_sqlite_config_absolute_database(self):
+        config = {
+            "driver": "sqlite",
+            "database": "/var/data/database.sqlite",
+        }
+        url = ConnectionFactory.build_url(config)
+        self.assertEqual(url, "sqlite+aiosqlite:////var/data/database.sqlite")
+
+    def test_sqlite_config_ignores_host_user_password_port(self):
+        """SQLite has no host/user/password/port -- extra keys must not leak into the URL."""
+        config = {
+            "driver": "sqlite",
+            "database": "database.sqlite",
+            "host": "localhost",
+            "username": "root",
+            "password": "secret",
+            "port": "",
+        }
+        url = ConnectionFactory.build_url(config)
+        self.assertEqual(url, "sqlite+aiosqlite:///database.sqlite")
+
     def test_sqlite_config_via_url_passthrough(self):
         config = {
             "driver": "sqlite",