Skip to content

add_fbthrift_library should add include path for prefix #66

Description

@sin-ack

Commit 64e0e3f introduced includes from fb303 to fbthrift. This currently fails if one tries to build fb303 as a system library, because the include paths passed to thrift1 does not include /usr/include which is where the Thrift annotations included by fb303_thrift live (installed by a prior fbthrift installation). Either fbthrift1 should look at the prefix by default, or the CMake custom command generated by add_fbthrift_library should include it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions