Skip to content

Commit 588bfcd

Browse files
committed
Arm sidePanel setPanelBehavior at top level; onClicked wrap ate first click
1 parent c19ec48 commit 588bfcd

16 files changed

Lines changed: 48 additions & 48 deletions

File tree

examples/ai-chatgpt/src/background.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ if (isFirefoxLike) {
1313
browser.sidebarAction.open()
1414
})
1515
} else {
16-
chrome.action.onClicked.addListener(() => {
17-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
18-
})
16+
// setPanelBehavior only affects FUTURE action clicks — registering it
17+
// inside onClicked would swallow the first toolbar click.
18+
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
1919
}
2020

2121
chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {

examples/ai-claude/src/background.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ if (isFirefoxLike) {
1313
browser.sidebarAction.open()
1414
})
1515
} else {
16-
chrome.action.onClicked.addListener(() => {
17-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
18-
})
16+
// setPanelBehavior only affects FUTURE action clicks — registering it
17+
// inside onClicked would swallow the first toolbar click.
18+
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
1919
}
2020

2121
chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {

examples/ai-gemini/src/background.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ if (isFirefoxLike) {
1313
browser.sidebarAction.open()
1414
})
1515
} else {
16-
chrome.action.onClicked.addListener(() => {
17-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
18-
})
16+
// setPanelBehavior only affects FUTURE action clicks — registering it
17+
// inside onClicked would swallow the first toolbar click.
18+
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
1919
}
2020

2121
chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {

examples/ai-perplexity/src/background.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ if (isFirefoxLike) {
1313
browser.sidebarAction.open()
1414
})
1515
} else {
16-
chrome.action.onClicked.addListener(() => {
17-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
18-
})
16+
// setPanelBehavior only affects FUTURE action clicks — registering it
17+
// inside onClicked would swallow the first toolbar click.
18+
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
1919
}
2020

2121
chrome.runtime.onMessage.addListener((message, sender, sendResponse) => {

examples/javascript/src/background.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ if (isFirefoxLike) {
1919
}
2020

2121
if (!isFirefoxLike) {
22-
chrome.action.onClicked.addListener(() => {
23-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
24-
})
22+
// setPanelBehavior only affects FUTURE action clicks — registering it
23+
// inside onClicked would swallow the first toolbar click.
24+
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
2525
}
2626

2727
chrome.runtime.onMessage.addListener((message) => {

examples/playwright/src/background.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ if (isFirefoxLike) {
1919
}
2020

2121
if (!isFirefoxLike) {
22-
chrome.action.onClicked.addListener(() => {
23-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
24-
})
22+
// setPanelBehavior only affects FUTURE action clicks — registering it
23+
// inside onClicked would swallow the first toolbar click.
24+
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
2525
}

examples/preact/src/background.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ if (isFirefoxLike) {
1919
}
2020

2121
if (!isFirefoxLike) {
22-
chrome.action.onClicked.addListener(() => {
23-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
24-
})
22+
// setPanelBehavior only affects FUTURE action clicks — registering it
23+
// inside onClicked would swallow the first toolbar click.
24+
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
2525
}
2626

2727
chrome.runtime.onMessage.addListener((message) => {

examples/react/src/background.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ if (isFirefoxLike) {
1919
}
2020

2121
if (!isFirefoxLike) {
22-
chrome.action.onClicked.addListener(() => {
23-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
24-
})
22+
// setPanelBehavior only affects FUTURE action clicks — registering it
23+
// inside onClicked would swallow the first toolbar click.
24+
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
2525
}
2626

2727
chrome.runtime.onMessage.addListener((message) => {

examples/sidebar-antd/src/background.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ if (isFirefoxLike) {
1010
browser.sidebarAction.open()
1111
})
1212
} else {
13-
chrome.action.onClicked.addListener(() => {
14-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
15-
})
13+
// setPanelBehavior only affects FUTURE action clicks — registering it
14+
// inside onClicked would swallow the first toolbar click.
15+
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
1616
}

examples/sidebar-monorepo-turbopack/packages/extension/src/background.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ if (isFirefoxLike) {
2121
}
2222
} else {
2323
try {
24-
chrome.action?.onClicked.addListener(() => {
25-
chrome.sidePanel.setPanelBehavior({openPanelOnActionClick: true})
26-
})
24+
// setPanelBehavior only affects FUTURE action clicks — registering it
25+
// inside onClicked would swallow the first toolbar click.
26+
chrome.sidePanel?.setPanelBehavior({openPanelOnActionClick: true})
2727
} catch {
2828
// Ignore errors - best effort
2929
}

0 commit comments

Comments
 (0)