Fails to process PATCH request with empty records array

[PhilippKolmann]

Describe the bug
Caddy with PowerDNS API for DNS ACME tries to remove the set record via the following PATCH request:

{"name":"","type":"Zone","rrsets":[{"name":"_acme-challenge.x.y.z.","type":"TXT","ttl":0,"changetype":"REPLACE","records":[],"comments":[]}],"nameservers":[]}

Here is the error from the logs:

Uncaught TypeError: Exonet\\Powerdns\\Resources\\ResourceRecord::getRecords(): Return value must be of type array, null returned in vendor/exonet/powerdns-php/src/Resources/ResourceRecord.php:295
Stack trace:
  #0 vendor/exonet/powerdns-php/src/Transformers/RRSetTransformer.php(34): Exonet\\Powerdns\\Resources\\ResourceRecord->getRecords()
  #1 vendor/exonet/powerdns-php/src/Transformers/RRSetTransformer.php(18): Exonet\\Powerdns\\Transformers\\RRSetTransformer->transformResourceRecord()
  #2 vendor/exonet/powerdns-php/src/Connector.php(77): Exonet\\Powerdns\\Transformers\\RRSetTransformer->transform()
  #3 vendor/exonet/powerdns-php/src/Zone.php(68): Exonet\\Powerdns\\Connector->patch()

To Reproduce
try to delete a record via PATCH and empty records.

Expected behavior
Accept a null answer from PowerDNS and forward this to the caller.

[trizz]

Hi @PhilippKolmann,

Thanks for your issue. Unfortunately, due to time limitations, we are not going to fix this right now. A PR is welcome, but please keep in mind that, if at all possible, it should not be a breaking change. For example, instead of changing the return type to ?array, it should return an empty array.