Skip to content

Commit be4b60d

Browse files
committed
ci: skip feedback artifacts after preflight failure
1 parent 36b9e47 commit be4b60d

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

.github/workflows/review-feedback-backfill.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ jobs:
4343
fi
4444
4545
- name: Run review feedback backfill
46+
id: backfill
4647
run: |
4748
set +e
4849
ruby .github/scripts/sweep-recent-review-feedback.rb \
@@ -72,7 +73,7 @@ jobs:
7273
exit "${status}"
7374
7475
- name: Upload review feedback 30-day ledger
75-
if: always()
76+
if: ${{ always() && steps.backfill.outcome != 'skipped' }}
7677
uses: actions/upload-artifact@v4
7778
with:
7879
name: review-feedback-30d-ledger
@@ -83,7 +84,7 @@ jobs:
8384
retention-days: 90
8485

8586
- name: Upload review feedback 30-day guardrail backlog
86-
if: always()
87+
if: ${{ always() && steps.backfill.outcome != 'skipped' }}
8788
uses: actions/upload-artifact@v4
8889
with:
8990
name: review-feedback-30d-guardrail-backlog

.github/workflows/review-feedback-sentinel.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ jobs:
4343
fi
4444
4545
- name: Sweep recent merged PR feedback
46+
id: sweep
4647
run: |
4748
set +e
4849
ruby .github/scripts/sweep-recent-review-feedback.rb \
@@ -74,7 +75,7 @@ jobs:
7475
exit "${status}"
7576
7677
- name: Upload review feedback ledger
77-
if: always()
78+
if: ${{ always() && steps.sweep.outcome != 'skipped' }}
7879
uses: actions/upload-artifact@v4
7980
with:
8081
name: review-feedback-ledger
@@ -83,7 +84,7 @@ jobs:
8384
retention-days: 30
8485

8586
- name: Upload review feedback guardrail backlog
86-
if: always()
87+
if: ${{ always() && steps.sweep.outcome != 'skipped' }}
8788
uses: actions/upload-artifact@v4
8889
with:
8990
name: review-feedback-guardrail-backlog

0 commit comments

Comments
 (0)