Skip to content

Add typecheck script to packages/vscode-extension on main #154

Description

@DrumRobot

Context

PR #143 (spike Custom Editor, addressing #138) added "typecheck": "tsc --noEmit" to packages/vscode-extension/package.json in commit 2d10016. Running this surfaced 4 latent type errors in src/extension.ts — calls to isStale / clearStale / deletedStaleProjectCount that were never wired through in core.

main currently has the same latent bug, but pnpm -r typecheck silently skips vscode-extension because there is no typecheck script. PR #146 removes the inert calls and would resolve the typecheck error once the script is in place.

Proposed

  1. Add "typecheck": "tsc --noEmit" to packages/vscode-extension/package.json on main
  2. Land PR fix(vscode): remove inert stale-project cleanup calls #146 first (or together) to avoid red CI on main once the script is added

Verification

  • pnpm -r typecheck runs vscode-extension and exits 0 on main
  • No regression in pnpm build

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions