Symfony 8 compatibility

[mariusjp]

Feature Request

Your composer.json is set to a very specific Symfony version.
Why not set it to ^7.0 | ^8.0?

Link to the discussion where the feature request was discussed, if any.

No response

Contribution Checks

• I have verified whether this feature request was already discussed.
• I am familiar with "Bug or Feature?"

[ericsizemore]

I swear GitHub be failing to notify me on some things. But thank you @mariusjp - I've made some changes in the latest commit, just looks like I need to take care of some lingering PHPStan errors. Could you give it a try for me, and let me know if you run into any issues?

[mariusjp]

Thank you for working on this library! I have been using rregeer's for years and discovered it was "abandoned" and you continued the work.
Just tested "dev-master" and it works without issue!
I'm on PHP 8.5 and Symfony 8.0.5

Just a deprecation warning:

Deprecated: Implicit conversion from float-string "20.18" to int loses precision in /var/www/html/vendor/esi/phpunit-coverage-check/src/Command/CoverageCheckCommand.php on line 146

[ericsizemore]

Thank you for working on this library! I have been using rregeer's for years and discovered it was "abandoned" and you continued the work. Just tested "dev-master" and it works without issue! I'm on PHP 8.5 and Symfony 8.0.5

Just a deprecation warning:

Deprecated: Implicit conversion from float-string "20.18" to int loses precision in /var/www/html/vendor/esi/phpunit-coverage-check/src/Command/CoverageCheckCommand.php on line 146

Of course! I was looking for a code coverage/coverage check soution when I came across Richard's library. I thought it was great then it kind of went from there. :)

For the deprecation you are getting, just so I could possibly try reproducing it, could you tell me the command you're running? E.g.:

php vendor/bin/coverage-check path/to/clover.xml 100

[mariusjp]

I'm running this as a composer script:
vendor/bin/coverage-check var/coverage/clover.xml 20.18

"check-coverage": "vendor/bin/coverage-check var/coverage/clover.xml 4.18",

On Richard's version I could use 2 decimals to be very precise and strict about the coverage. With a large codebase it could matter.
Looking at the deprecation message, you cast it to an int, so you loose precision.
I could live with that, but just to let you know I did use this.

[ericsizemore]

I'm running this as a composer script: vendor/bin/coverage-check var/coverage/clover.xml 20.18

"check-coverage": "vendor/bin/coverage-check var/coverage/clover.xml 4.18",

On Richard's version I could use 2 decimals to be very precise and strict about the coverage. With a large codebase it could matter. Looking at the deprecation message, you cast it to an int, so you loose precision. I could live with that, but just to let you know I did use this.

Ah, yes, I see. The threshold is set/treated as an int throughout the library. It shouldn't take much to expand that to accept floats as well. I'll have to work on that. :)

Edit: Seems symfony/console doesn't like that idea, however.

Untyped, Union or Intersection types are not supported for command arguments.

[mariusjp]

I think the Command input should be string, and then interpret it as float from that point onward (after some sanity checks obviously).

Want me to whip something up to help you?

[ericsizemore]

That's along the lines of what I was thinking after digging into symfony/console a bit more. Figured in the command it could be string, then do some checks/casting within Esi\CoverageCheck\CoverageCheck.

And sure, I'm always open to help. Never hurts to have another set of eyes on it :)

[mariusjp]

First WIP, but just to show you some progress:
#528

I'm not really happy with how I set this up right now. Don't like the structure of what is checked where, but just to tag you along with the solution.