Skip to content

Extension output does not end with a newline #787

Description

@Daimona

The extension's output does not end with a newline, thus creating readability issues with content that follows. For example, from https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php83/49988/consoleFull (will be autodeleted in two weeks):

Detected 1 test where the duration exceeded the global maximum duration (0.100).

# Duration Test
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
1    0.108 MediaWiki\Extension\AbuseFilter\Tests\Integration\AbuseFilterSchemaTest::testSchemasHaveAutoGeneratedFiles with data set "tables.json" ('/workspace/src/extensions/Abu...s.json')
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
     0.000
      └─── secondsWorker exited with status 0

There is no newline, so the "Worker exited with status 0" part from the CI runner ends up as part of the extension's output.

Similarly when there are hidden tests:

Detected 12 tests where the duration exceeded the global maximum duration (0.100).

 # Duration Test
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[...]
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      0.000
       └─── seconds

There are 2 additional slow tests that are not listed here.Worker exited with status 0

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions