From 3d7abe5da5c9d818a874df8be49123f4f6f2663c Mon Sep 17 00:00:00 2001 From: Richard Hagen Date: Mon, 6 Jul 2026 15:52:16 +0200 Subject: [PATCH 1/3] fix: remove setting shared-secret upfront --- cmd/createApplication.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/cmd/createApplication.go b/cmd/createApplication.go index f9360cb..aef8585 100644 --- a/cmd/createApplication.go +++ b/cmd/createApplication.go @@ -48,7 +48,6 @@ var createApplicationCmd = &cobra.Command{ } repository, _ := cmd.Flags().GetString(flagnames.Repository) - sharedSecret, _ := cmd.Flags().GetString(flagnames.SharedSecret) configBranch, _ := cmd.Flags().GetString(flagnames.ConfigBranch) configFile, _ := cmd.Flags().GetString(flagnames.ConfigFile) configurationItem, _ := cmd.Flags().GetString(flagnames.ConfigurationItem) @@ -78,7 +77,6 @@ var createApplicationCmd = &cobra.Command{ RadixConfigFullName: configFile, ReaderAdGroups: readerAdGroups, Repository: &repository, - SharedSecret: &sharedSecret, }, }) From 57658df23648cb1131733049d434562b9bb2c5f8 Mon Sep 17 00:00:00 2001 From: Richard Hagen Date: Fri, 31 Jul 2026 16:25:42 +0200 Subject: [PATCH 2/3] fix: remove shared-secret option from create application command --- cmd/createApplication.go | 3 +-- pkg/flagnames/names.go | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/cmd/createApplication.go b/cmd/createApplication.go index aef8585..94f23c1 100644 --- a/cmd/createApplication.go +++ b/cmd/createApplication.go @@ -40,7 +40,7 @@ var createApplicationCmd = &cobra.Command{ Use: "application", Short: "Create application", Long: "Creates a Radix application in the cluster", - Example: `rx create application --application your-application-name --repository https://github.com/your-repository --config-branch main --ad-groups abcdef-1234-5678-9aaa-abcdefgf --reader-ad-groups=23456789--9123-4567-8901-23456701 --shared-secret someSecretPhrase12345 --acknowledge-warnings --configuration-item "YOUR PROJECT CONFIG ITEM" --context playground`, + Example: `rx create application --application your-application-name --repository https://github.com/your-repository --config-branch main --ad-groups abcdef-1234-5678-9aaa-abcdefgf --reader-ad-groups=23456789--9123-4567-8901-23456701 --acknowledge-warnings --configuration-item "YOUR PROJECT CONFIG ITEM" --context playground`, RunE: func(cmd *cobra.Command, args []string) error { appName, err := config.GetAppNameFromConfigOrFromParameter(cmd, flagnames.Application) if err != nil { @@ -141,7 +141,6 @@ func init() { createCmd.AddCommand(createApplicationCmd) createApplicationCmd.Flags().StringP(flagnames.Application, "a", "", "Name of the application to create") createApplicationCmd.Flags().StringP(flagnames.Repository, "", "", "The GitHub repository URL") - createApplicationCmd.Flags().StringP(flagnames.SharedSecret, "", "", "(Optional) Shared secret for the webhook. It is needed when use a GitHub webhook.") createApplicationCmd.Flags().StringP(flagnames.ConfigBranch, "", "", "Name of the branch where Radix will read your radixconfig.yaml from") createApplicationCmd.Flags().StringP(flagnames.ConfigFile, "", "", "(Optional) Name of the radix config file. Defaults to radixconfig.yaml") createApplicationCmd.Flags().StringSliceP(flagnames.AdminADGroups, "", []string{}, "Admin groups (UUIDs of Microsoft Entra groups). Optional for the Playground context") diff --git a/pkg/flagnames/names.go b/pkg/flagnames/names.go index 32b8617..4cd2f3c 100644 --- a/pkg/flagnames/names.go +++ b/pkg/flagnames/names.go @@ -41,7 +41,6 @@ const ( Repository = "repository" Schema = "schema" Secret = "secret" - SharedSecret = "shared-secret" Since = "since" SkipValidation = "skip-validation" StrictValidation = "strict-validation" From ba2fd146928c1756c94167e965d813760a8b1b32 Mon Sep 17 00:00:00 2001 From: Richard Hagen Date: Fri, 31 Jul 2026 16:26:23 +0200 Subject: [PATCH 3/3] fix: remove shared-secret parameter from application creation command --- hack/setup_application.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hack/setup_application.sh b/hack/setup_application.sh index 72fb3e0..5503872 100755 --- a/hack/setup_application.sh +++ b/hack/setup_application.sh @@ -24,8 +24,7 @@ PUBLIC_KEY=$(rx create application \ --token-environment \ --from-config \ --repository $REPOSITORY \ - --owner $OWNER \ - --shared-secret $SHARED_SECRET 2>&1) + --owner $OWNER 2>&1) # Wait for application to be reconciled sleep 3