Hello, as part of an Open Science course we are encouraged to try running open source code made available by other colleagues. As I am not an expert in your field, I tried to simply run the code and check the output.
In general, I had a first simple problem from Git when trying to clone the repository. It was not cloned entirely. I got an error concerning git-lfs: command not found. I never used this Git extension before.
Second, I tried the Matlab scripts. There was only one simple issue with the global variable SAVE_PLOTS that was not recognized by the subroutine calling it. As a quick search I found what MATLAB documentation states "Global variables can be troublesome, so it is better to avoid using them.". Globals might have some bugs and it would be hard to find them. A solution might be using anonymous functions as recommended by the documentation.
Besides that, the Matlab scripts run perfectly, and with the descriptive figures and short animation saved much of the work was self-explanatory.
Hello, as part of an Open Science course we are encouraged to try running open source code made available by other colleagues. As I am not an expert in your field, I tried to simply run the code and check the output.
In general, I had a first simple problem from Git when trying to clone the repository. It was not cloned entirely. I got an error concerning git-lfs: command not found. I never used this Git extension before.
Second, I tried the Matlab scripts. There was only one simple issue with the global variable SAVE_PLOTS that was not recognized by the subroutine calling it. As a quick search I found what MATLAB documentation states "Global variables can be troublesome, so it is better to avoid using them.". Globals might have some bugs and it would be hard to find them. A solution might be using anonymous functions as recommended by the documentation.
Besides that, the Matlab scripts run perfectly, and with the descriptive figures and short animation saved much of the work was self-explanatory.