Skip to content

Inconsistent CLI long options #36

Description

@bnubald

The add_splits() method here have inconsistent delimiters. E.g.

  • --processing-splits
  • --split-names
  • --split_starts
  • --split_ends
  • --split-head
  • --split-tail

Some here use hyphens, others using underscores. For consistency, use hyphens throughout? Any downstream usage I've seen so far has been using the short options, so, shouldn't cause a cascade change. 🤞🏼 ?

def add_splits(self):
self.add_argument("-ps",
"--processing-splits",
type=csv_arg,
required=False,
default=None)
self.add_argument("-sn",
"--split-names",
type=csv_arg,
required=False,
default=None)
self.add_argument("-ss",
"--split_starts",
type=csv_of_date_args,
required=False,
default=[])
self.add_argument("-se",
"--split_ends",
type=csv_of_date_args,
required=False,
default=[])
self.add_argument("-sh",
"--split-head",
help="Split dates head, number of time steps to include before",
type=int,
default=0)
self.add_argument("-st",
"--split-tail",
help="Split dates tail, number of time steps to include after",
type=int,
default=0)
return self

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions